[ http://jira.jboss.com/jira/browse/JBPM-1172?page=all ] Ronald van Kuijk updated JBPM-1172: ----------------------------------- Component/s: Core Engine Complexity: Medium an easy change without having to introduce an explicit template attribute is to have the core search for a 'task-reminder-<taskname>' template first and if none found, use the default 'task-reminder' template. Any comments? This could be implemented very easily and extended in 3.3 (or 4) to use explicit templates. But we could also leave it in 3.3/4 like proposed here -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBPM-1172?page=worklog#action_12412261 ] Ronald van Kuijk logged work on JBPM-1172: ------------------------------------------ Time Spent: 1 hour Remaining Estimate: 2 hours Time Spent: 1 hour took me 1 hour to 'fix' this as proposed AND have a deploy (parse) time warning if a configured mail template is not found. Still have to finish the tests for this, but this seems very interesting. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBPM-1172?page=comments#action_12412263 ] Ronald van Kuijk commented on JBPM-1172: ---------------------------------------- cool, there is NO test for createMailDelegation in JpdlXmlReader... lucky me... I added this if (!Mail.templateExists(template)) { if (template.startsWith(Event.EVENTTYPE_TASK_ASSIGN)) { template = Event.EVENTTYPE_TASK_ASSIGN; } else if (template.startsWith("task-reminder")) { template = "task-reminder"; } else { log.warn("Mail template \"" + template + "\" not found. Will cause run-time problems"); } } to this method so not much can go wrong and I added public static boolean templateExists(String templateName) { if (templateName != null) { templates = new HashMap(); String mailTemplatesResource = JbpmConfiguration.Configs.getString("resource.mail.templates"); org.w3c.dom.Element mailTemplatesElement = XmlUtil.parseXmlResource(mailTemplatesResource).getDocumentElement(); List mailTemplateElements = XmlUtil.elements(mailTemplatesElement, "mail-template"); Iterator iter = mailTemplateElements.iterator(); while (iter.hasNext()) { org.w3c.dom.Element mailTemplateElement = (org.w3c.dom.Element) iter.next(); if (templateName.equals(mailTemplateElement.getAttribute("name"))) { return true; } } } return false; } to the base Mail class. This method in this class will also be used if the mail class is overridden by the property jbpm.mail.class.name or mail.class.name I would want to implement a test for this, but there is NO template test at all (at least not that I can find). I'll see what I can come up with... will not be extensive though... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBPM-1172?page=all ] Thomas Diesler updated JBPM-1172: --------------------------------- Fix Version/s: (was: jBPM jPDL 3.2.4) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPM-1172?page=com.atlassian.jira.plug... ] Thomas Diesler resolved JBPM-1172. ---------------------------------- Resolution: Rejected Future jBPM3 releases can only contain bug fixes. All effort goes into jBPM4. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira