[ https://jira.jboss.org/jira/browse/JBPM-2759?page=com.atlassian.jira.plug... ] Martin Putz updated JBPM-2759: ------------------------------ Attachment: jbpm-test-db-JBPM-2759.diff Attaching the modified test case for business time subtractions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPM-2759?page=com.atlassian.jira.plug... ] Ronald van Kuijk commented on JBPM-2759: ---------------------------------------- Martin, The testcase you provided works, but I created two additional ones, crossing month boundaries and leap year day boundaries. Those do not work and I did not try crossing year boundaries yet, and I only used days in the subtraction. Not weeks, months etc... So either my tests are incorrect, or some more work needs to be done. Strange thing is that I thought there were explicit BusinessCalender tests, but I could not find them. Maybe they were only in jBPM 3. Unfortunately, I have no time to dig into this further. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPM-2759?page=com.atlassian.jira.plug... ] Ronald van Kuijk updated JBPM-2759: ----------------------------------- Attachment: SubtractAdditionalTests.diff Additional tests for leapyear, month boundary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBPM-2759?page=com.atlassian.jira.plug... ] Martin Putz updated JBPM-2759: ------------------------------ Attachment: jbpm-test-db-JBPM-2759_v2.diff Fixed TimerTest.testTimerELSubtractBusinessLeap, which simply had an incorrect start date. One note regarding calculations with +/- business days: with the default setup (jbpm.businesscalendar.cfg.xml), a business day is defined to have 7.5 hours, whereas internal calculations are based on 8 hrs. To have exact results, the businessXXXinMillis fields in BusinessCalendarImpl would need to be set when the businesscalender config file is parsed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBPM-2759?page=com.atlassian.jira.plugin.sy... ] Huisheng Xu resolved JBPM-2759. ------------------------------- Assignee: Huisheng Xu Fix Version/s: jBPM 4.5 (was: jBPM 4.x) Resolution: Done Done, checked in r6592. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira