Rename: PDL->VDL

From Simon_Lessard at DMR.CA Sun Aug 16 04:45:03 2020 Content-Type: multipart/mixed; boundary="===============4685153334928765150==" MIME-Version: 1.0 From: Simon Lessard To: jsr-314-open-mirror at lists.jboss.org Subject: Re: [jsr-314-open] More spec issues Date: Tue, 31 Mar 2009 10:25:12 -0400 Message-ID: In-Reply-To: 18893.33682.295981.766984@sun.com --===============4685153334928765150== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, = I'm working on MyFaces. Alright for the other comments. = = Regards, = ~ Simon = ________________________________ From: JSR 314 Open Mailing list on behalf of Ed Burns Sent: Fri 3/27/2009 9:55 PM To: JSR-314-OPEN(a)JCP.ORG Subject: Re: [jsr-314-open] More spec issues >>>>> On Fri, 27 Mar 2009 11:15:08 -0400, Simon Lessard said: SL> Hi all, SL> I have a couple more issues I found while implementing the latest SL> spec: Thanks. Can you share with the EG if you're doing a complete new Impl? This would be big news for me because AFAIK, Sun and Apache are the only ones doing new JSF2 impls. SL> * ViewHandler.FACELETS_VIEW_MAPPINGS_PARAM_NAME: The doc says that I'll let others chime in on that one. The behavior as specified seems useful to me. SL> * ViewHandler.getPageDeclarationLanguage(): JavaDoc gives two SL> default implementations, one invoking the factory from FactoryFinder SL> (useful) and the throws UnsupportedOperationException SL> one. Personally, I'd keep only the real method here as the SL> processing doesn't involve any private/non standard API; I see your point, but we did it this way to allow JSF 1.2 ViewHandlers to easily be detected, so we'll leave this the same as well. SL> * AjaxBehavior.getHints(): JavaDoc says it should return an emprt SL> Set (like ClientBehaviorBase), making the method declaration in SL> AjaxBehavior useless. However Mojarra returns a Set containing SL> SUBMITTING, so I assume the code is right and the JavaDoc wrong SL> here; Roger integrted this one. SL> * UIComponentBase.initialStateMarked(): This method is not defined SL> in the JavaDoc while the two others from PartialStateHolder are. I think this one's ok as is. SL> * ExternalContext.getRequestCookieMap(): Can the return value be SL> changed from Map to Map please? We can't do that because Cookie is declared in the Servlet spec, and Portlet people wouldn't be happy if we added that to our API. SL> * PageDeclarationLanguageFactory.getPageDeclarationLanguage(String SL> viewId): The JavaDoc says that ClassNotFoundException should be SL> thrown when no valid PLD can be found. However, SL> ClassNotFoundException is a checked exception and the method does SL> not that this exception in its throws clause. The doc should either SL> says to wrap it in a FacesException or add ClassNotFoundException to SL> the throws clause; I've removed the @throws ClassNotFoundException SL> * ExceptionHandler.handle(): The spec specifies that this method SL> should only throw a FacesException if an internal error occurs while SL> handling the exception. However, it also says to throw either SL> ServletException or PortletException depending on the environment SL> and those are checked exception not declared in the throws SL> clause. Mojarra wrap them in a FacesException, so the spec mighth SL> ave to be ajusted to reflect that. SL> That's all for now, SL> ~ Simon SL> ________________________________ SL> From: JSR 314 Open Mailing list on behalf of Ed Burns SL> Sent: Fri 3/27/2009 10:30 AM SL> To: JSR-314-OPEN(a)JCP.ORG SL> Subject: Rename: PDL->VDL SL> We have "View" everywhere else, so we should rename SL> PageDeclarationLanguage to ViewDeclarationLanguage. SL> I'm taking care of this now. SL> Ed SL> -- SL> | ed.burns(a)sun.com | office: 408 884 9519 OR x31640 SL> | homepage: | http://ridingthecrest.com/ SL> Rename: PDL->VDL SL> SL> SL> SL>

Hi all,

SL>

I have a couple more issues I found whil= e implementing the latest spec:

SL>

ViewHandler.FACELETS_VIEW_MAPPINGS_PARA= M_NAME: The doc says that the implementation should also read original Face= lets' param for the purpose of defining mappings. I don't think that's a go= od idea. Facelets was not a standard up to that point and users shouldn't r= eally expect no migration effort at all. I know that enforcing that param w= ould allow xisting applications using facelet.jar to be deployed in 2.0 env= ironment, but to my kn=C3=B2wledge, no other spec read some non standard co= ntext params (I may be wrong though). If we do enforce the original paramet= ers, then we'll be stuck with it forever so at least let use only that one = and not define a new one;
ViewHandler.getPageDeclarationLanguage(= ): JavaDoc gives two default implementations, one invoking the factory from= FactoryFinder (useful) and the throws UnsupportedOperationException one. P= ersonally, I'd keep only the real method here as the processing doesn't inv= olve any private/non standard API;
AjaxBehavior.getHints(): JavaDoc says i= t should return an emprt Set (like ClientBehaviorBase), making the method d= eclaration in AjaxBehavior useless. However Mojarra returns a Set containin= g SUBMITTING, so I assume the code is right and the JavaDoc wrong here;

SL>

UIComponentBase.initialStateMarked(): T= his method is not defined in the JavaDoc while the two others from PartialS= tateHolder are.

SL>

ExternalContext.getRequestCookieMap(): = Can the return value be changed from Map<String,Object> to Map<Str= ing, Cookie> please?

SL>

PageDeclarationLanguageFactory.getPageD= eclarationLanguage(String viewId): The JavaDoc says that ClassNotFoundExcep= tion should be thrown when no valid PLD can be found. However, ClassNotFoun= dException is a checked exception and the method does not that this excepti= on in its throws clause. The doc should either says to wrap it in a FacesEx= ception or add ClassNotFoundException to the throws clause;

SL>

ExceptionHandler.handle(): The spec spe= cifies that this method should only throw a FacesException if an internal e= rror occurs while handling the exception. However, it also says to throw ei= ther ServletException or PortletException depending on the environment and = those are checked exception not declared in the throws clause. Mojarra wrap= them in a FacesException, so the spec mighth ave to be ajusted to reflect = that.

SL>

That's all for now,

SL>

~ Simon

SL>

From: JSR 314 Open M= ailing list on behalf of Ed Burns
Sent: Fri 3/27/2009 10:30 AMTo: JSR-314-OPEN(a)JCP.ORG
Subject: Rename: PDL->VDL

SL>

We have "View" everywhere else, so we should renamePageDeclarationLanguage to ViewDeclarationLanguage.

I'm taking car= e of this now.

Ed
--
| ed.burns(a)sun.com | office: 408 = 884 9519 OR x31640
| homepage: = | http://ridingthecrest.com/<= /A>