On 10/28/10 3:22 AM, Ed Burns wrote:

On Wed, 20 Oct 2010 18:32:56 -0400, Andy Schwartz <andy.schwartz@oracle.com> said:


AS> I have attached a patch to issue 893 that implements these changes.  See:

I have reviewed and applied the most recent patch for 893 that is
attached to the issue (take3).  I see no reason not to commit it so I'll
do so presently.

Awesome!

Leonardo, In your opinion, do we need to make any changes to
NavigationHandler so that the new ViewDeclarationLanguage.viewExists()
method is consulted?  I would expect this might need to be done.

Oh, woops - yep. ConfigurableNavigationHandler implementations should use VDL.viewExists() instead of ExternalContext.getResource() to test for view existence when determining whether implicit navigation is possible. Actually, any place where we were using ExternalContext.getResource() to check for a physical view needs to go through VDL.viewExists() now. I believe that ViewHandler.deriveViewId() and implicit navigation are the only 2 places where this comes up, though I will double check that later today.

Andy, for completeness, don't we need to implement viewExists() for JSP?

In the patch that I provided, I included a concrete implementation of viewExists() in ViewDeclarationLanguage - one that calls ExternalContext.getResource(). This is sufficient for JspViewHandlingStategy, which inherits this implementation.

In any case, I've committed revision 8686 with this fix, and also made
the necessary spec changes, to the Frame document as well.

Great news. Thanks Ed!

Andy

Ed