We should just go ahead an improve the admin api. Then we make sure this is used when testing. Anyone doing changes to the admin endpoints should in the future write tests for it, which should use the admin api.

On 21 October 2015 at 11:16, Marek Posolda <mposolda@redhat.com> wrote:
The nicer API will be good, but IMO it is more important the REST endpoints are up-to-date . Which is not the case now. I believe the autogeneration will help with having the admin-client endpoints synced with the stuff from server.

Unfortunately it seems to me that it will be challenge to have nice API and autogeneration at the same time :-\

Marek


On 21/10/15 09:40, Stian Thorgersen wrote:
I don't like the use of RestEasy client for these in the first place. It doesn't make a very nice Java library IMO. Something like:

   void createRealm(RealmRepresentation rep) throws AdminException

Would be much better than:

   Response createRealm(RealmRepresentation rep)

Under the covers the implementation could use RestEasy client, but I don't think the current approach creates a very nice API.

On 21 October 2015 at 09:31, Marek Posolda <mposolda@redhat.com> wrote:
Was wondering if resteasy has some way to autogenerate REST endpoints inside integration/admin-client to be automatically synced with the REST endpoints from keycloak-services ?

So for example when I add new REST endpoint on server-side into org.keycloak.services.resources .RealmsResource class, the admin-client class org.keycloak.admin.client.resource.RealmsResource will be automatically updated too . Ideally there can be maven target executed on demand for update admin-client sources. That would help to avoid unsynced endpoints in admin-client - issues like https://issues.jboss.org/browse/KEYCLOAK-1967 .

Marek

_______________________________________________
keycloak-dev mailing list
keycloak-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev