On 1/21/2016 2:28 PM, Stian Thorgersen wrote:

I'm wasn't planing on having a lengthy discussion about code style. It's usually just a matter of personal preference and folks do get used to most things.

Questions are:

* Should we have a code style?

I've seen too many teams waste time arguing about code style. I think that our team is mature enough that we wouldn't let that happen, but having strict enforcement never seems to provide much payoff, imo.

I think a middle ground is to just publish some general guidelines of basic standards we can all agree with. Then if someone strays too far, just ask them to fix it.

* What IDEs are Keycloak devs using (I'm crossing my fingers everyone says IntelliJ)

NetBeans

* Should we enable the checkstyle plugin?

Something that checks the license and possibly authorship/copyright is probably important. Beyond that, I'm not sure how useful checkstyle would be.

In NetBeans, every time I create a new class I use a template that lets me choose the license. Surely other IDE's have a way to do this?

With regards to the actual style my first thought was to base it on WildFly code style (we do build on top of it after all). However, they do not have one for IntelliJ, which makes it a no go IMO. Further I don't particularly want to craft one (and try to get configs for IntelliJ match Eclipse, which also passes the checkstyle). So do anyone have suggestions of other projects we can borrow from?

If we're going to incorporate a code style and re-format the current code case now is a very good time.
_______________________________________________
keycloak-dev mailing list
keycloak-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev