[JBoss JIRA] (ARTIF-712) Refactor ArtifactSet, PagedResult, etc.
by Brett Meyer (JIRA)
[ https://issues.jboss.org/browse/ARTIF-712?page=com.atlassian.jira.plugin.... ]
Brett Meyer updated ARTIF-712:
------------------------------
Summary: Refactor ArtifactSet, PagedResult, etc. (was: Optimize ArtifactSet, PagedResult, etc.)
> Refactor ArtifactSet, PagedResult, etc.
> ---------------------------------------
>
> Key: ARTIF-712
> URL: https://issues.jboss.org/browse/ARTIF-712
> Project: Artificer
> Issue Type: Sub-task
> Reporter: Brett Meyer
> Assignee: Brett Meyer
> Fix For: 1.0.0.Beta2
>
>
> ArtifactSet#list should never be used server-side unless absolutely necessary (feeds, etc.). Ex: PagedResult is currently handed the list (bad), instead of given an iterator (good). The latter would allow the BaseArtifactTypes to be visited/built on-demand, rather than all up-front.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-712) Optimize ArtifactSet, PagedResult, etc.
by Brett Meyer (JIRA)
Brett Meyer created ARTIF-712:
---------------------------------
Summary: Optimize ArtifactSet, PagedResult, etc.
Key: ARTIF-712
URL: https://issues.jboss.org/browse/ARTIF-712
Project: Artificer
Issue Type: Sub-task
Reporter: Brett Meyer
Assignee: Brett Meyer
Fix For: 1.0.0.Beta2
ArtifactSet#list should never be used server-side unless absolutely necessary (feeds, etc.). Ex: PagedResult is currently handed the list (bad), instead of given an iterator (good). The latter would allow the BaseArtifactTypes to be visited/built on-demand, rather than all up-front.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-711) Performance enhancements
by Brett Meyer (JIRA)
Brett Meyer created ARTIF-711:
---------------------------------
Summary: Performance enhancements
Key: ARTIF-711
URL: https://issues.jboss.org/browse/ARTIF-711
Project: Artificer
Issue Type: Enhancement
Reporter: Brett Meyer
Assignee: Brett Meyer
Fix For: 1.0.0.Beta2
Tracks necessary performance enhancements, discovered during profiling
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-710) Optimize Hibernate Search query
by Brett Meyer (JIRA)
[ https://issues.jboss.org/browse/ARTIF-710?page=com.atlassian.jira.plugin.... ]
Brett Meyer resolved ARTIF-710.
-------------------------------
Resolution: Done
For now, making a few assumptions. I only added the artifact model and type to the index. That should cover the vast majority of use cases. Also, with that in mind, the query didn't have to be delayed until the main query is executed, since when we hit the full-text predicate, we would have already hit the model/type path.
> Optimize Hibernate Search query
> -------------------------------
>
> Key: ARTIF-710
> URL: https://issues.jboss.org/browse/ARTIF-710
> Project: Artificer
> Issue Type: Enhancement
> Affects Versions: 1.0.0.Beta1
> Reporter: Brett Meyer
> Assignee: Brett Meyer
> Fix For: 1.0.0.Beta2
>
>
> Currently, if a full-text search method is found by the query visitor, it builds up a separate Hibernate Search query, with the search keyword as the only constraint. The resulting artifact IDs are then used as a "where id in (...)" constraint on the original query.
> It would be more performant to delay the Search query until execution of the original query. Several artifact fields could also be indexed and used to limit the full-text search's results. For instance, if the query starts with /s-ramp/xsd/XsdDocument, we could index 'model' and 'type'. Then, match those indexes using the model/type, helping to reduce the size of the eventual list of IDs. The same is probably true for other types of predicates.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-710) Optimize Hibernate Search query
by Brett Meyer (JIRA)
Brett Meyer created ARTIF-710:
---------------------------------
Summary: Optimize Hibernate Search query
Key: ARTIF-710
URL: https://issues.jboss.org/browse/ARTIF-710
Project: Artificer
Issue Type: Enhancement
Affects Versions: 1.0.0.Beta1
Reporter: Brett Meyer
Assignee: Brett Meyer
Fix For: 1.0.0.Beta2
Currently, if a full-text search method is found by the query visitor, it builds up a separate Hibernate Search query, with the search keyword as the only constraint. The resulting artifact IDs are then used as a "where id in (...)" constraint on the original query.
It would be more performant to delay the Search query until execution of the original query. Several artifact fields could also be indexed and used to limit the full-text search's results. For instance, if the query starts with /s-ramp/xsd/XsdDocument, we could index 'model' and 'type'. Then, match those indexes using the model/type, helping to reduce the size of the eventual list of IDs. The same is probably true for other types of predicates.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-708) Support Java 8
by Brett Meyer (JIRA)
[ https://issues.jboss.org/browse/ARTIF-708?page=com.atlassian.jira.plugin.... ]
Brett Meyer resolved ARTIF-708.
-------------------------------
Fix Version/s: 1.0.0.Beta2
Resolution: Done
> Support Java 8
> --------------
>
> Key: ARTIF-708
> URL: https://issues.jboss.org/browse/ARTIF-708
> Project: Artificer
> Issue Type: Task
> Affects Versions: 1.0.0.Beta1
> Reporter: Brett Meyer
> Assignee: Brett Meyer
> Fix For: 1.0.0.Beta2
>
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
> (default-compile) on project artificer-repository-hibernate: Compilation
> failure: Compilation failure:
> [ERROR]
> /home/theute/Projects/Artificer/artificer/repository/hibernate/src/main/java/org/artificer/repository/hibernate/HibernateEntityFactory.java:[60,59]
> cannot access javax.servlet.Filter
> [ERROR] class file for javax.servlet.Filter not found
> [ERROR]
> /home/theute/Projects/Artificer/artificer/repository/hibernate/src/main/java/org/artificer/repository/hibernate/query/ArtificerToHibernateQueryVisitor.java:[577,19]
> incomparable types: java.lang.Object and boolean
> [ERROR]
> /home/theute/Projects/Artificer/artificer/repository/hibernate/src/main/java/org/artificer/repository/hibernate/query/ArtificerToHibernateQueryVisitor.java:[579,26]
> incomparable types: java.lang.Object and boolean
> this is the JDK I use:
> theute@X1Carbon:artificer (master)$ java -version
> openjdk version "1.8.0_45"
> OpenJDK Runtime Environment (build 1.8.0_45-b14)
> OpenJDK 64-Bit Server VM (build 25.45-b02, mixed mode)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-707) Uncaught GWT Error: Cannot read property 'indexOf' of null
by Thomas Heute (JIRA)
[ https://issues.jboss.org/browse/ARTIF-707?page=com.atlassian.jira.plugin.... ]
Thomas Heute commented on ARTIF-707:
------------------------------------
Nice thanks. can't wait to see the 500 artifacts :)
> Uncaught GWT Error: Cannot read property 'indexOf' of null
> ----------------------------------------------------------
>
> Key: ARTIF-707
> URL: https://issues.jboss.org/browse/ARTIF-707
> Project: Artificer
> Issue Type: Bug
> Components: UI
> Affects Versions: 1.0.0.Beta1
> Reporter: Thomas Heute
> Assignee: Brett Meyer
> Fix For: 1.0.0.Beta2
>
>
> While playing with the UI, I tried to upload some random artifacts (In that case I tried to upload artificer-1.0.0.Beta1.zip itself.
> I get an error in the UI:
> Uncaught GWT Error!
> Exception caught: (TypeError) : Cannot read property 'indexOf' of null
> and a message remains forever:
> Importing Artifact(s)
> Please wait while your import is processed...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years
[JBoss JIRA] (ARTIF-707) Uncaught GWT Error: Cannot read property 'indexOf' of null
by Brett Meyer (JIRA)
[ https://issues.jboss.org/browse/ARTIF-707?page=com.atlassian.jira.plugin.... ]
Brett Meyer resolved ARTIF-707.
-------------------------------
Resolution: Done
> Uncaught GWT Error: Cannot read property 'indexOf' of null
> ----------------------------------------------------------
>
> Key: ARTIF-707
> URL: https://issues.jboss.org/browse/ARTIF-707
> Project: Artificer
> Issue Type: Bug
> Components: UI
> Affects Versions: 1.0.0.Beta1
> Reporter: Thomas Heute
> Assignee: Brett Meyer
> Fix For: 1.0.0.Beta2
>
>
> While playing with the UI, I tried to upload some random artifacts (In that case I tried to upload artificer-1.0.0.Beta1.zip itself.
> I get an error in the UI:
> Uncaught GWT Error!
> Exception caught: (TypeError) : Cannot read property 'indexOf' of null
> and a message remains forever:
> Importing Artifact(s)
> Please wait while your import is processed...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years