[JBoss JIRA] (RTGOV-457) Situation json now includes 'properties' and 'situationProperties'
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/RTGOV-457?page=com.atlassian.jira.plugin.... ]
Gary Brown updated RTGOV-457:
-----------------------------
Git Pull Request: https://github.com/Governance/rtgov/pull/124
> Situation json now includes 'properties' and 'situationProperties'
> ------------------------------------------------------------------
>
> Key: RTGOV-457
> URL: https://issues.jboss.org/browse/RTGOV-457
> Project: RTGov (Run Time Governance)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Gary Brown
> Assignee: Gary Brown
> Fix For: 2.0.0.Final
>
>
> In the recent move from JPA to Hibernate ORM it was found that queries could not work on properties, as 'properties' is a hibernate keyword - so the situationProperties property was added and the old properties getter/setter deprecated, to maintain programmatic backward compatibility. The db schema is ok as the column name is the same.
> Moving forward it is probably better that the json reflects the object properties, so should use 'situationProperties' - so need to mark 'properties' as transient so not converted to json.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years
[JBoss JIRA] (RTGOV-457) Situation json now includes 'properties' and 'situationProperties'
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/RTGOV-457?page=com.atlassian.jira.plugin.... ]
Gary Brown resolved RTGOV-457.
------------------------------
Resolution: Done
> Situation json now includes 'properties' and 'situationProperties'
> ------------------------------------------------------------------
>
> Key: RTGOV-457
> URL: https://issues.jboss.org/browse/RTGOV-457
> Project: RTGov (Run Time Governance)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Gary Brown
> Assignee: Gary Brown
> Fix For: 2.0.0.Final
>
>
> In the recent move from JPA to Hibernate ORM it was found that queries could not work on properties, as 'properties' is a hibernate keyword - so the situationProperties property was added and the old properties getter/setter deprecated, to maintain programmatic backward compatibility. The db schema is ok as the column name is the same.
> Moving forward it is probably better that the json reflects the object properties, so should use 'situationProperties' - so need to mark 'properties' as transient so not converted to json.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years
[JBoss JIRA] (RTGOV-329) Consider refactoring/cleanup of ActivtyServerLogger
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/RTGOV-329?page=com.atlassian.jira.plugin.... ]
Gary Brown commented on RTGOV-329:
----------------------------------
Can you be more specific about (3)? What problem do you see potentially occuring?
> Consider refactoring/cleanup of ActivtyServerLogger
> ---------------------------------------------------
>
> Key: RTGOV-329
> URL: https://issues.jboss.org/browse/RTGOV-329
> Project: RTGov (Run Time Governance)
> Issue Type: Quality Risk
> Security Level: Public(Everyone can see)
> Components: Activity Collector
> Affects Versions: 1.0.0.Final
> Reporter: Jiri Pechanec
> Assignee: Gary Brown
> Fix For: 2.1.0.Final
>
> Attachments: Performance.java
>
>
> 1) I consider the code to be overcomplicated - are we really getting any performance boost with reusing the ArrayList of events? I found on the web that clear() might be even slower than new allocation
> 2) There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess
> 3) I am not sure if it is wise to mix synchronization on Java level - _timer in BatchedActivityUnitLogger - and Java EE level - method synchornization on @Singleton
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years
[JBoss JIRA] (RTGOV-329) Consider refactoring/cleanup of ActivtyServerLogger
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/RTGOV-329?page=com.atlassian.jira.plugin.... ]
Gary Brown edited comment on RTGOV-329 at 6/19/14 4:05 AM:
-----------------------------------------------------------
(2) "There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess"
True, but they are no important pieces of information - so if they are slightly inaccurate because of concurrent update, it is not a significant issue - compared to the performance impact of synchronization on every failure report, on the off chance a concurrent update is happening.
was (Author: objectiser):
(2) "There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess"
True, but they are no important pieces of information - so if they slightly inaccurate because of concurrent update, it is no a significant issue - compared to the performance impact of synchronization on every failure report, just in case.
> Consider refactoring/cleanup of ActivtyServerLogger
> ---------------------------------------------------
>
> Key: RTGOV-329
> URL: https://issues.jboss.org/browse/RTGOV-329
> Project: RTGov (Run Time Governance)
> Issue Type: Quality Risk
> Security Level: Public(Everyone can see)
> Components: Activity Collector
> Affects Versions: 1.0.0.Final
> Reporter: Jiri Pechanec
> Assignee: Gary Brown
> Fix For: 2.1.0.Final
>
> Attachments: Performance.java
>
>
> 1) I consider the code to be overcomplicated - are we really getting any performance boost with reusing the ArrayList of events? I found on the web that clear() might be even slower than new allocation
> 2) There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess
> 3) I am not sure if it is wise to mix synchronization on Java level - _timer in BatchedActivityUnitLogger - and Java EE level - method synchornization on @Singleton
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years
[JBoss JIRA] (RTGOV-329) Consider refactoring/cleanup of ActivtyServerLogger
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/RTGOV-329?page=com.atlassian.jira.plugin.... ]
Gary Brown commented on RTGOV-329:
----------------------------------
(2) "There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess"
True, but they are no important pieces of information - so if they slightly inaccurate because of concurrent update, it is no a significant issue - compared to the performance impact of synchronization on every failure report, just in case.
> Consider refactoring/cleanup of ActivtyServerLogger
> ---------------------------------------------------
>
> Key: RTGOV-329
> URL: https://issues.jboss.org/browse/RTGOV-329
> Project: RTGov (Run Time Governance)
> Issue Type: Quality Risk
> Security Level: Public(Everyone can see)
> Components: Activity Collector
> Affects Versions: 1.0.0.Final
> Reporter: Jiri Pechanec
> Assignee: Gary Brown
> Fix For: 2.1.0.Final
>
> Attachments: Performance.java
>
>
> 1) I consider the code to be overcomplicated - are we really getting any performance boost with reusing the ArrayList of events? I found on the web that clear() might be even slower than new allocation
> 2) There is unsynced access to fields _sequenceNumber and _failuresSinceLastSuccess
> 3) I am not sure if it is wise to mix synchronization on Java level - _timer in BatchedActivityUnitLogger - and Java EE level - method synchornization on @Singleton
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years