From portal-commits at lists.jboss.org Mon Apr 30 18:30:17 2007
Content-Type: multipart/mixed; boundary="===============5035692427696338198=="
MIME-Version: 1.0
From: portal-commits at lists.jboss.org
To: portal-commits at lists.jboss.org
Subject: [portal-commits] JBoss Portal SVN: r7157 -
 trunk/core-samples/src/main/org/jboss/portal/core/portlet/test/event.
Date: Mon, 30 Apr 2007 18:30:17 -0400
Message-ID: <E1HieNt-0000yU-LU@committer01.frg.pub.inap.atl.jboss.com>

--===============5035692427696338198==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Author: julien(a)jboss.com
Date: 2007-04-30 18:30:17 -0400 (Mon, 30 Apr 2007)
New Revision: 7157

Modified:
   trunk/core-samples/src/main/org/jboss/portal/core/portlet/test/event/Use=
rCounterListener.java
Log:
counter++ is not thread safe

Modified: trunk/core-samples/src/main/org/jboss/portal/core/portlet/test/ev=
ent/UserCounterListener.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/core-samples/src/main/org/jboss/portal/core/portlet/test/event/Us=
erCounterListener.java	2007-04-30 20:26:12 UTC (rev 7156)
+++ trunk/core-samples/src/main/org/jboss/portal/core/portlet/test/event/Us=
erCounterListener.java	2007-04-30 22:30:17 UTC (rev 7157)
@@ -26,6 +26,7 @@
 import org.jboss.portal.api.event.PortalEventContext;
 import org.jboss.portal.api.event.PortalEventListener;
 import org.jboss.portal.api.user.event.UserAuthenticationEvent;
+import EDU.oswego.cs.dl.util.concurrent.SynchronizedLong;
 =

 /**
  * @author <a href=3D"mailto:theute(a)jboss.org">Thomas Heute</a>
@@ -34,8 +35,11 @@
 public class UserCounterListener implements PortalEventListener
 {
    =

-   private int counter =3D 0;
-   private int counterEver =3D 0;
+   /** . */
+   private final SynchronizedLong counter =3D new SynchronizedLong(0);
+
+   /** . */
+   private final SynchronizedLong counterEver =3D new SynchronizedLong(0);
    =

    public void onEvent(PortalEventContext eventContext, PortalEvent event)
    {
@@ -44,15 +48,15 @@
          UserAuthenticationEvent userEvent =3D (UserAuthenticationEvent)ev=
ent;
          if (userEvent.getType() =3D=3D UserAuthenticationEvent.SIGN_IN)
          {
-            counter++;
-            counterEver++;
+            counter.increment();
+            counterEver.increment();
          }
          else if (userEvent.getType() =3D=3D UserAuthenticationEvent.SIGN_=
OUT)
          {
-            counter--;
+            counter.decrement();
          }
-         System.out.println("Counter     : " + counter);
-         System.out.println("Counter ever: " + counterEver);
+         System.out.println("Counter     : " + counter.get());
+         System.out.println("Counter ever: " + counterEver.get());
       }
    }
 }


--===============5035692427696338198==--