From portal-commits at lists.jboss.org Mon Jul  7 08:30:10 2008
Content-Type: multipart/mixed; boundary="===============4865786287884673391=="
MIME-Version: 1.0
From: portal-commits at lists.jboss.org
To: portal-commits at lists.jboss.org
Subject: [portal-commits] JBoss Portal SVN: r11312 -
 modules/presentation/trunk/presentation/src/main/java/org/jboss/portal/presentation/impl/model.
Date: Mon, 07 Jul 2008 08:30:10 -0400
Message-ID: <E1KFpr8-0006W3-Fp@committer01.frg.pub.inap.atl.jboss.com>

--===============4865786287884673391==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Author: julien(a)jboss.com
Date: 2008-07-07 08:30:10 -0400 (Mon, 07 Jul 2008)
New Revision: 11312

Modified:
   modules/presentation/trunk/presentation/src/main/java/org/jboss/portal/p=
resentation/impl/model/UpdatePhase.java
Log:
bit of javadoc

Modified: modules/presentation/trunk/presentation/src/main/java/org/jboss/p=
ortal/presentation/impl/model/UpdatePhase.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/presentation/trunk/presentation/src/main/java/org/jboss/portal/=
presentation/impl/model/UpdatePhase.java	2008-07-07 12:26:25 UTC (rev 11311)
+++ modules/presentation/trunk/presentation/src/main/java/org/jboss/portal/=
presentation/impl/model/UpdatePhase.java	2008-07-07 12:30:10 UTC (rev 11312)
@@ -29,6 +29,12 @@
 import java.util.HashMap;
 =

 /**
+ * The update phase takes care of applying the result produced by the diff=
 phase to the viewport context.
+ * It is splitted into two phases, the first one performs removals and the=
 second one performs updates
+ * and loadings. The main reason of having two phases is to deal with obje=
ct moves within the same viewport
+ * scope. If a load resulting from a move would be applied before the obje=
ct is evicted it would result
+ * of a corruption of the viewport scope (two objects with the same id).
+ *
  * @author <a href=3D"mailto:julien(a)jboss-portal.org">Julien Viet</a>
  * @version $Revision: 630 $
  */
@@ -53,6 +59,9 @@
       perform2ndPhase();
    }
 =

+   /**
+    * The first phase take care of removals.
+    */
    private void perform1stPhase()
    {
       perform1stPhase(rootDiff);
@@ -127,6 +136,9 @@
       }
    }
 =

+   /**
+    * The second phase takes care of updates and loads.
+    */
    private void perform2ndPhase()
    {
       perform2ndPhase(rootDiff);
@@ -196,7 +208,7 @@
          }
          else if (diff instanceof ObjectDiff.Update)
          {
-            // Nothing ?
+            // Nothing
          }
          else if (diff instanceof ObjectDiff.Skip)
          {


--===============4865786287884673391==--