On Wed, Jul 11, 2018 at 7:09 PM Pavol Loffay <ploffay@redhat.com> wrote:
On Wed, Jul 11, 2018 at 6:51 PM Alessio Soldano <asoldano@redhat.com> wrote:I've pushed a fix for the ResteasyServletInitializer to master https://github.com/resteasy/Resteasy/commit/1b3870b0b7210a8b4ab70eb51fc903abdaac9b41 ; we'll double check it with tck before next release, anyway.Going back to the issue, 3.0.24 basically removes any doubt I had regarding recent asyn changes, it's quite an old version.The AsyncListener ... is this https://github.com/pavolloffay/smallrye-opentracing/blob/00f6c4dced4990b4e7ec0af57671399b6877f8a4/tck/src/test/java/io/smallrye/opentracing/ServletContextTracingInstaller.java#L27-L31 what you're referring to and which you believe is not working? it's really a servlet/undertow thing btw...Yes the AsyncListener is added in the filter which your link references.Martin also commented here https://issues.jboss.org/browse/UNDERTOW-1258?focusedCommentId=13603809&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13603809 on this issues.On Wed, Jul 11, 2018 at 2:40 PM, Martin Kouba <mkouba@redhat.com> wrote:Also note that we use a modified ResteasyServletInitializer to init resteasy in the TCK: https://github.com/smallrye/smallrye-opentracing/pull/4/files#diff-ec8fa59dbdd6534b47de691e766aff61
M
Dne 11.7.2018 v 13:29 Martin Kouba napsal(a):
You're right, 3.0.24.Final.
Dne 11.7.2018 v 13:09 Pavol Loffay napsal(a):
Hi Alessio,
resteasy version in Thorntail and SmallRye should be the same - 3.0.24.Final. I have added Ken and Martin in case I am wrong.
Regards,
On Wed, Jul 11, 2018 at 11:30 AM Alessio Soldano <asoldano@redhat.com <mailto:asoldano@redhat.com>> wrote:
CC-ing Pavol, not sure he's subscribed to the list
On Wed, Jul 11, 2018 at 11:29 AM, Alessio Soldano
<asoldano@redhat.com <mailto:asoldano@redhat.com>> wrote:
Hi Pavol,
I'm forwarding this to the dev-list, so that the whole team can
read and help.
Can you start by telling which version of RESTEasy was used in
the previous and current integration?
There's been a bunch of changes around async lately, which might
possibly be related to the issue you're seeing.
Cheers
---------- Forwarded message ----------
From: *Pavol Loffay* <ploffay@redhat.com
<mailto:ploffay@redhat.com>>
Date: Tue, Jul 10, 2018 at 6:15 PM
Subject: Microprofile-OpenTracing Async issues in TCK when
running on Wildfly
To: Alessio Soldano <asoldano@redhat.com
<mailto:asoldano@redhat.com>>
Cc: jean-frederic clere <jclere@redhat.com
<mailto:jclere@redhat.com>>
Hi Alessio,
Jean Frederic pointed me to you as the contact for issues
related to Resteasy/undertow in Wildfly.
I am migrating Microprofile-OpenTracing implementation from
Thorntail [1] to SmallRye [2]. TCK in Thorntail was passing
fine. Now when it's deployed on Wildfly a test for async
endpoint is failing. Basically, the AsyncListener (added in
filter) which reports some data is never called.
The issue is described on the PR
https://github.com/smallrye/smallrye-opentracing/pull/4#issuecomment-403847333.
Could you please have a look and comment on the PR? Is it safe
to rely on AsyncListener. Can it happen that the listener added
in the filter will not be invoked?
[1]:
https://github.com/thorntail/thorntail/tree/master/fractions/microprofile/microprofile-opentracing
[2]: https://github.com/smallrye/smallrye-opentracing/pull/4
Regards,
--
PAVOL LOFFAY
SOFTWARE ENGINEER
Red Hat<https://www.redhat.com/>
M: +41791562647
<https://red.ht/sig>
--
Alessio Soldano
Associate Manager
Red Hat
<https://www.redhat.com>
<https://red.ht/sig>
--
Alessio Soldano
Associate Manager
Red Hat
<https://www.redhat.com>
<https://red.ht/sig>
--
PAVOL LOFFAY
SOFTWARE ENGINEER
Red Hat<https://www.redhat.com/>
M: +41791562647 <javascript:void(0);>
<https://red.ht/sig>
--
Martin Kouba
Senior Software Engineer
Red Hat, Czech Republic
----
