3:28 p.m.
Author: justi9
Date: 2007-10-16 16:28:34 -0400 (Tue, 16 Oct 2007)
New Revision: 1097
Modified:
mgmt/cumin/python/cumin/queue.py
mgmt/cumin/python/cumin/realm.py
mgmt/cumin/python/cumin/server.py
mgmt/cumin/python/wooly/__init__.py
mgmt/cumin/python/wooly/parameters.py
mgmt/cumin/python/wooly/resources.py
mgmt/misc/templates.py
mgmt/notes/Todo
Log:
Remove some out of date XXXs.
Modified: mgmt/cumin/python/cumin/queue.py
===================================================================
--- mgmt/cumin/python/cumin/queue.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/cumin/queue.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -162,8 +162,6 @@
self.queue_name = TextInput(app, "queue_name", self)
self.add_child(self.queue_name)
- # XXX Convert tuning stuff into single subwidget
-
self.latency_priority = Parameter(app, "tuning")
self.latency_priority.set_default("m")
self.add_parameter(self.latency_priority)
Modified: mgmt/cumin/python/cumin/realm.py
===================================================================
--- mgmt/cumin/python/cumin/realm.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/cumin/realm.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -37,7 +37,7 @@
def get_items(self, session, vhost):
return sorted_by(vhost.realm_items())
- # XXX just parked here
+ # just parked here
def do_process(self, session, queue):
for realm in self.get(session):
if realm not in queue.realm_items():
Modified: mgmt/cumin/python/cumin/server.py
===================================================================
--- mgmt/cumin/python/cumin/server.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/cumin/server.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -67,15 +67,6 @@
frame = self.show_mode(session, self.prop)
return self.page().set_current_frame(session, frame)
- # XXX need to set frames in these
- def show_queue(self, session, queue):
- vhost = self.show_virtual_host(session, queue.virtual_host)
- return vhost.show_queue(session, queue)
-
- def show_exchange(self, session, exchange):
- vhost = self.show_virtual_host(session, exchange.virtual_host)
- return vhost.show_exchange(session, exchange)
-
def render_title(self, session, server):
return "Server '%s'" % server.name
Modified: mgmt/cumin/python/wooly/__init__.py
===================================================================
--- mgmt/cumin/python/wooly/__init__.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/wooly/__init__.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -459,7 +459,6 @@
return value
def set(self, key, value):
- # XXX interesting idea for debugging: catch where things get set
#if key.startswith("server.vhost.queue.edit.durable"):
# raise Exception()
Modified: mgmt/cumin/python/wooly/parameters.py
===================================================================
--- mgmt/cumin/python/wooly/parameters.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/wooly/parameters.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -2,7 +2,6 @@
from wooly import *
-# XXX the marshal side of this is not implemented
class ListParameter(Parameter):
def __init__(self, app, name, param):
super(ListParameter, self).__init__(app, name)
Modified: mgmt/cumin/python/wooly/resources.py
===================================================================
--- mgmt/cumin/python/wooly/resources.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/cumin/python/wooly/resources.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -61,7 +61,6 @@
try:
path = os.path.join(dir, name)
- # XXX +1 exposing template resolution is useful
#print "Looking for resource '%s'" % path
file = open(path, "r")
Modified: mgmt/misc/templates.py
===================================================================
--- mgmt/misc/templates.py 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/misc/templates.py 2007-10-16 20:28:34 UTC (rev 1097)
@@ -35,10 +35,8 @@
</div>
</form>
<script defer="defer">
-var id = "{id}";
(function() {
- // XXX elements[0] is a fieldset, at least in firefox
- var elem = wooly.doc().elem(id).node.elements[1];
+ var elem = wooly.doc().elem("{id}").node.elements[1];
elem.focus();
elem.select();
}())
Modified: mgmt/notes/Todo
===================================================================
--- mgmt/notes/Todo 2007-10-16 20:09:57 UTC (rev 1096)
+++ mgmt/notes/Todo 2007-10-16 20:28:34 UTC (rev 1097)
@@ -94,3 +94,5 @@
* Add status box to exchange view
* Add group type to group add,edit
+
+ * Add the marshal side of ListParameter