Author: justi9
Date: 2007-10-31 10:36:36 -0400 (Wed, 31 Oct 2007)
New Revision: 1192
Modified:
mgmt/cumin/python/cumin/broker.strings
mgmt/cumin/python/cumin/client.strings
mgmt/cumin/python/cumin/exchange.strings
mgmt/cumin/python/cumin/page.strings
mgmt/cumin/python/cumin/queue.strings
mgmt/cumin/python/cumin/widgets.strings
mgmt/notes/justin-todo.txt
Log:
Moves status columns all the way to the right.
Replaces inline styles for right-aligned columns with a shorter class
attr.
Renames some name columns to "Name" or other appropriate field titles.
Modified: mgmt/cumin/python/cumin/broker.strings
===================================================================
--- mgmt/cumin/python/cumin/broker.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/broker.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -46,8 +46,8 @@
<th>Broker</th>
<th>Profile</th>
<th>Cluster</th>
+ <th>Load</th>
<th>Status</th>
- <th>Load</th>
</tr>
{items}
@@ -61,8 +61,8 @@
<td>{item_link}</td>
<td>{item_profile_link}</td>
<td>{item_cluster_link}</td>
+ <td>{item_load}</td>
<td>{item_status}</td>
- <td>{item_load}</td>
</tr>
[BrokerConfigTab.css]
Modified: mgmt/cumin/python/cumin/client.strings
===================================================================
--- mgmt/cumin/python/cumin/client.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/client.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -9,12 +9,12 @@
<table class="mobjects">
<tr>
<th><input type="checkbox"/></th>
- <th>Client</th>
+ <th>Address</th>
+ <th class="ralign">Msgs. Produced</th>
+ <th class="ralign">Bytes Produced</th>
+ <th class="ralign">Msgs. Consumed</th>
+ <th class="ralign">Bytes Consumed</th>
<th>Status</th>
- <th style="text-align: right;">Msgs. Produced</th>
- <th style="text-align: right;">Bytes Produced</th>
- <th style="text-align: right;">Msgs. Consumed</th>
- <th style="text-align: right;">Bytes Consumed</th>
</tr>
{items}
@@ -25,11 +25,11 @@
<tr>
<td><input type="checkbox"/></td>
<td>{item_link}</td>
+ <td class="ralign">{item_messages_produced}</td>
+ <td class="ralign">{item_messages_consumed}</td>
+ <td class="ralign">{item_bytes_produced}</td>
+ <td class="ralign">{item_bytes_consumed}</td>
<td>{item_status}</td>
- <td style="text-align: right;">{item_messages_produced}</td>
- <td style="text-align: right;">{item_messages_consumed}</td>
- <td style="text-align: right;">{item_bytes_produced}</td>
- <td style="text-align: right;">{item_bytes_consumed}</td>
</tr>
[ClientView.html]
@@ -67,10 +67,10 @@
<table class="mobjects">
<tr>
<th><input type="checkbox"/></th>
- <th>Session</th>
+ <th>Name</th>
+ <th class="ralign">Remaining Lifespan</th>
+ <th class="ralign">Frames Outstanding</th>
<th>Status</th>
- <th style="text-align: right;">Remaining Lifespan</th>
- <th style="text-align: right;">Frames Outstanding</th>
</tr>
{items}
@@ -80,7 +80,7 @@
<tr>
<td><input type="checkbox"/></td>
<td>{item_name}</td>
+ <td class="ralign">{item_remaining_lifespan}</td>
+ <td class="ralign">{item_frames_outstanding}</td>
<td>{item_status}</td>
- <td style="text-align: right;">{item_remaining_lifespan}</td>
- <td style="text-align: right;">{item_frames_outstanding}</td>
</tr>
Modified: mgmt/cumin/python/cumin/exchange.strings
===================================================================
--- mgmt/cumin/python/cumin/exchange.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/exchange.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -14,13 +14,13 @@
[ExchangeSet.html]
<table class="ExchangeSet mobjects">
<tr>
- <th>Exchange</th>
- <th>Configuration</th>
+ <th>Name</th>
+ <th>Queue Bindings</th>
+ <th class="ralign">Msgs. Received</th>
+ <th class="ralign">Bytes Received</th>
+ <th class="ralign">Msgs. Routed</th>
+ <th class="ralign">Bytes Routed</th>
<th>Status</th>
- <th style="text-align: right;">Msgs. Received</th>
- <th style="text-align: right;">Bytes Received</th>
- <th style="text-align: right;">Msgs. Routed</th>
- <th style="text-align: right;">Bytes Routed</th>
</tr>
{items}
@@ -30,11 +30,11 @@
<tr>
<td>{item_link}</a></td>
<td>{item_config}</td>
+ <td class="ralign">{item_messages_received}</td>
+ <td class="ralign">{item_bytes_received}</td>
+ <td class="ralign">{item_messages_routed}</td>
+ <td class="ralign">{item_bytes_routed}</td>
<td>{item_status}</td>
- <td style="text-align: right;">{item_messages_received}</td>
- <td style="text-align: right;">{item_bytes_received}</td>
- <td style="text-align: right;">{item_messages_routed}</td>
- <td style="text-align: right;">{item_bytes_routed}</td>
</tr>
[ExchangeForm.html]
@@ -104,7 +104,7 @@
<tr>
<th>Queue</th>
<th>Key</th>
- <th style="text-align: right;">Messages Matched</th>
+ <th class="ralign">Messages Matched</th>
</tr>
{items}
@@ -114,7 +114,7 @@
<tr>
<td><a href="{item_href}">Queue
'{item_name}'</a></td>
<td>{item_binding_key}</td>
- <td style="text-align: right;">{item_messages_matched}</td>
+ <td class="ralign">{item_messages_matched}</td>
</tr>
[ExchangeStatistics.html]
@@ -145,8 +145,8 @@
<tr>
<th><input type="checkbox"/></th>
<th>Producer</th>
- <th style="text-align: right;">Msgs. Produced</th>
- <th style="text-align: right;">Bytes Produced</th>
+ <th class="ralign">Msgs. Produced</th>
+ <th class="ralign">Bytes Produced</th>
</tr>
{items}
@@ -156,6 +156,6 @@
<tr>
<td><input type="checkbox"/></td>
<td>{item_name}</td>
- <td style="text-align: right;">{item_messages_produced}</td>
- <td style="text-align: right;">{item_bytes_produced}</td>
+ <td class="ralign">{item_messages_produced}</td>
+ <td class="ralign">{item_bytes_produced}</td>
</tr>
Modified: mgmt/cumin/python/cumin/page.strings
===================================================================
--- mgmt/cumin/python/cumin/page.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/page.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -513,6 +513,10 @@
width: 100%;
}
+.ralign, table.mobjects .ralign {
+ text-align: right;
+}
+
[CuminPage.html]
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
Modified: mgmt/cumin/python/cumin/queue.strings
===================================================================
--- mgmt/cumin/python/cumin/queue.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/queue.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -12,15 +12,15 @@
<button>Purge Messages</button>
</div>
- <table class="QueueSet mobjects">
+ <table class="mobjects">
<tr>
<th><input type="checkbox"/></th>
- <th>Queue</th>
- <th>Configuration</th>
+ <th>Name</th>
+ <th>Exchange Bindings</th>
+ <th class="ralign">Msg. Depth</th>
+ <th class="ralign">Byte Depth</th>
+ <th class="ralign">Consumers</th>
<th>Status</th>
- <th style="text-align: right;">Msg. Depth</th>
- <th style="text-align: right;">Byte Depth</th>
- <th style="text-align: right;">Consumers</th>
</tr>
{items}
@@ -32,10 +32,10 @@
<td><input type="checkbox"/></td>
<td>{item_link}</a></td>
<td>{item_config}</td>
+ <td class="ralign">{item_message_depth}</td>
+ <td class="ralign">{item_byte_depth}</td>
+ <td class="ralign">{item_consumers}</td>
<td>{item_status}</td>
- <td style="text-align: right;">{item_message_depth}</td>
- <td style="text-align: right;">{item_byte_depth}</td>
- <td style="text-align: right;">{item_consumers}</td>
</tr>
[QueueForm.html]
@@ -141,7 +141,7 @@
<tr>
<th>Exchange</th>
<th>Key</th>
- <th style="text-align: right;">Messages Matched</th>
+ <th class="ralign">Messages Matched</th>
</tr>
{items}
@@ -151,7 +151,7 @@
<tr>
<td><a href="{item_href}">Exchange
'{item_name}'</a></td>
<td>{item_binding_key}</td>
- <td style="text-align: right;">{item_messages_matched}</td>
+ <td class="ralign">{item_messages_matched}</td>
</tr>
[QueueBindingAdd.html]
@@ -243,9 +243,9 @@
<tr>
<th><input type="checkbox"/></th>
<th>Consumer</th>
- <th style="text-align: right;">Msgs. Consumed</th>
- <th style="text-align: right;">Bytes Consumed</th>
- <th style="text-align: right;">Msgs. Unacked</th>
+ <th class="ralign">Msgs. Consumed</th>
+ <th class="ralign">Bytes Consumed</th>
+ <th class="ralign">Msgs. Unacked</th>
</tr>
{items}
@@ -255,7 +255,7 @@
<tr>
<td><input type="checkbox"/></td>
<td>{item_name}</td>
- <td style="text-align: right;">{item_messages_consumed}</td>
- <td style="text-align: right;">{item_bytes_consumed}</td>
- <td style="text-align: right;">{item_unacked_messages}</td>
+ <td class="ralign">{item_messages_consumed}</td>
+ <td class="ralign">{item_bytes_consumed}</td>
+ <td class="ralign">{item_unacked_messages}</td>
</tr>
Modified: mgmt/cumin/python/cumin/widgets.strings
===================================================================
--- mgmt/cumin/python/cumin/widgets.strings 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/cumin/python/cumin/widgets.strings 2007-10-31 14:36:36 UTC (rev 1192)
@@ -6,9 +6,10 @@
<div class="body">
<div>{confirm}</div>
<div>{cancel}</div>
-{hidden_inputs}
+ {hidden_inputs}
</div>
</form>
<script>
wooly.doc().elem("{id}").node.elements[1].focus();
</script>
+
Modified: mgmt/notes/justin-todo.txt
===================================================================
--- mgmt/notes/justin-todo.txt 2007-10-31 14:31:36 UTC (rev 1191)
+++ mgmt/notes/justin-todo.txt 2007-10-31 14:36:36 UTC (rev 1192)
@@ -104,8 +104,6 @@
* Move q,e to server level (using default vhost)
- * Replace all those inline td styles with a class attr
-
* Make sure nav links are so marked
* Make the status lights also be links to an appropriate view