From jira-events at lists.jboss.org Mon Dec 17 15:12:44 2007 Content-Type: multipart/mixed; boundary="===============1768616626803398186==" MIME-Version: 1.0 From: Alexander Smirnov (JIRA) To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Resolved: (RF-1012) org.ajax4jsf.io.parser.FastHtmlParser enters infinite loop Date: Mon, 17 Dec 2007 15:12:43 -0500 Message-ID: <15213603.1197922363887.JavaMail.jira@cloud.prod.atl2.jboss.com> In-Reply-To: 28342948.1190739771402.JavaMail.jira@cloud.prod.atl2.jboss.com --===============1768616626803398186== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ http://jira.jboss.com/jira/browse/RF-1012?page=3Dall ] Alexander Smirnov resolved RF-1012. ----------------------------------- Fix Version/s: 3.1.3 Resolution: Done This is a real error. Suggested changes applied. > org.ajax4jsf.io.parser.FastHtmlParser enters infinite loop > ---------------------------------------------------------- > > Key: RF-1012 > URL: http://jira.jboss.com/jira/browse/RF-1012 > Project: RichFaces > Issue Type: Bug > Affects Versions: 3.1.0 > Environment: RF 3.1 GA > Reporter: Doug Chasman > Assigned To: Alexander Smirnov > Fix For: 3.1.3, 3.2.0 > > > The following check will never return false because of the incorrect cast= to char (unsigned): > char c; > while ((c =3D (char)in.read()) > 0) { > ... > } > The following is my proposed fix: > int nextChar; > while ((nextChar =3D in.read()) > 0) { > char c =3D (char)nextChar; > ... > } > Also if the content being parsed does not include at least one tag a clos= ing is still appended. Ideally, and injection = would function properly regardless of the lack of structure of the content. -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= p://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1768616626803398186==--