From jira-events at lists.jboss.org Wed Oct 14 03:55:05 2009 Content-Type: multipart/mixed; boundary="===============6728085832790425939==" MIME-Version: 1.0 From: =?utf-8?q?Andreas_H=C3=B6hmann_=28JIRA=29_=3Cjira-events_at_lists=2Ejboss?= =?utf-8?q?=2Eorg=3E?= To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Created: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class Date: Wed, 14 Oct 2009 03:55:05 -0400 Message-ID: <1885516285.1255506905723.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com> --===============6728085832790425939== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable I would be nice to have the BaseXML redirecting-code in a util-class -------------------------------------------------------------------- Key: RF-7984 URL: https://jira.jboss.org/jira/browse/RF-7984 Project: RichFaces Issue Type: Feature Request Affects Versions: 3.3.2.GA Reporter: Andreas H=C3=B6hmann Priority: Minor I wrote a special spring security entry point to handle missing authenticat= ion *after* a a4j-request: /** * {@inheritDoc} */ @Override protected void sendRedirect(final HttpServletRequest theRequest, final Ht= tpServletResponse theResponse, final String theUrl) throws IOException { if (!isAjaxRequest(theRequest)) { LOG.debug("normal redirect to " + theUrl); super.sendRedirect(theRequest, theResponse, theUrl); } else { LOG.debug("ajax redirect to " + theUrl); final FilterServletResponseWrapper servletResponseWrapper =3D new Fil= terServletResponseWrapper(theResponse); final Writer output =3D resetResponse(theResponse, servletResponseWra= pper, "redirect"); theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, the= Url); // For buggy XmlHttpRequest realisations repeat headers in // output.write("\n" + "" + "" + "" + ""); output.flush(); theResponse.flushBuffer(); } } Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.BaseX= MLFilter to reuse it. It would be nice to have a "A4JResponseUtils" with this methods: - boolean isAjaxRequest(final ServletRequest request) - void sendRedirect(final HttpServletRequest theRequest, final HttpServletR= esponse theResponse, final String theUrl) The advantage of such a utils-class would be a always compatibly thirdparty= code (integration code), if the redirecting-code changes in a4j my code sh= ould still work :D -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============6728085832790425939==-- From jira-events at lists.jboss.org Mon Oct 26 09:38:07 2009 Content-Type: multipart/mixed; boundary="===============7059976963116405161==" MIME-Version: 1.0 From: Nick Belaevski (JIRA) To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Updated: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class Date: Mon, 26 Oct 2009 09:38:07 -0400 Message-ID: <1383191337.1256564287127.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1885516285.1255506905723.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com --===============7059976963116405161== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/jira/browse/RF-7984?page=3Dcom.atlassian.jira= .plugin.system.issuetabpanels:all-tabpanel ] Nick Belaevski updated RF-7984: ------------------------------- Component/s: core Fix Version/s: 4.0.0.BETA1 Assignee: Nick Belaevski > I would be nice to have the BaseXML redirecting-code in a util-class > -------------------------------------------------------------------- > > Key: RF-7984 > URL: https://jira.jboss.org/jira/browse/RF-7984 > Project: RichFaces > Issue Type: Feature Request > Components: core > Affects Versions: 3.3.2.GA > Reporter: Andreas H=C3=B6hmann > Assignee: Nick Belaevski > Priority: Minor > Fix For: 4.0.0.BETA1 > > > I wrote a special spring security entry point to handle missing authentic= ation *after* a a4j-request: > /** > * {@inheritDoc} > */ > @Override > protected void sendRedirect(final HttpServletRequest theRequest, final = HttpServletResponse theResponse, > final String theUrl) throws IOException { > if (!isAjaxRequest(theRequest)) { > LOG.debug("normal redirect to " + theUrl); > super.sendRedirect(theRequest, theResponse, theUrl); > } else { > LOG.debug("ajax redirect to " + theUrl); > final FilterServletResponseWrapper servletResponseWrapper =3D new F= ilterServletResponseWrapper(theResponse); > final Writer output =3D resetResponse(theResponse, servletResponseW= rapper, "redirect"); > theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, t= heUrl); > // For buggy XmlHttpRequest realisations repeat headers in > // > output.write("\n" > + "" + " + AjaxContainerRenderer.AJAX_FLAG_HEADER + "\" content=3D\"redi= rect\" />" + " + AjaxContainerRenderer.AJAX_LOCATION_HEADER + "\" content=3D\"= " + theUrl + "\" />" + ""); > output.flush(); > theResponse.flushBuffer(); > } > } > Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.Bas= eXMLFilter to reuse it. > It would be nice to have a "A4JResponseUtils" with this methods: > - boolean isAjaxRequest(final ServletRequest request) > - void sendRedirect(final HttpServletRequest theRequest, final HttpServle= tResponse theResponse, final String theUrl) > The advantage of such a utils-class would be a always compatibly thirdpar= ty code (integration code), if the redirecting-code changes in a4j my code = should still work :D -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============7059976963116405161==-- From jira-events at lists.jboss.org Tue Jun 8 10:02:38 2010 Content-Type: multipart/mixed; boundary="===============3100315122514616718==" MIME-Version: 1.0 From: Nick Belaevski (JIRA) To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Resolved: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class Date: Tue, 08 Jun 2010 10:02:38 -0400 Message-ID: <526429515.3345.1276005758232.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1885516285.1255506905723.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com --===============3100315122514616718== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/RF-7984?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:all-tabpanel ] Nick Belaevski resolved RF-7984. -------------------------------- Fix Version/s: (was: 4.0.0.Milestone1) Resolution: Out of Date Filter is not used in RF anymore. = > I would be nice to have the BaseXML redirecting-code in a util-class > -------------------------------------------------------------------- > > Key: RF-7984 > URL: https://jira.jboss.org/browse/RF-7984 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) = > Components: core > Affects Versions: 3.3.2.GA > Reporter: Andreas H=C3=B6hmann > Assignee: Nick Belaevski > Priority: Minor > > I wrote a special spring security entry point to handle missing authentic= ation *after* a a4j-request: > /** > * {@inheritDoc} > */ > @Override > protected void sendRedirect(final HttpServletRequest theRequest, final = HttpServletResponse theResponse, > final String theUrl) throws IOException { > if (!isAjaxRequest(theRequest)) { > LOG.debug("normal redirect to " + theUrl); > super.sendRedirect(theRequest, theResponse, theUrl); > } else { > LOG.debug("ajax redirect to " + theUrl); > final FilterServletResponseWrapper servletResponseWrapper =3D new F= ilterServletResponseWrapper(theResponse); > final Writer output =3D resetResponse(theResponse, servletResponseW= rapper, "redirect"); > theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, t= heUrl); > // For buggy XmlHttpRequest realisations repeat headers in > // > output.write("\n" > + "" + " + AjaxContainerRenderer.AJAX_FLAG_HEADER + "\" content=3D\"redi= rect\" />" + " + AjaxContainerRenderer.AJAX_LOCATION_HEADER + "\" content=3D\"= " + theUrl + "\" />" + ""); > output.flush(); > theResponse.flushBuffer(); > } > } > Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.Bas= eXMLFilter to reuse it. > It would be nice to have a "A4JResponseUtils" with this methods: > - boolean isAjaxRequest(final ServletRequest request) > - void sendRedirect(final HttpServletRequest theRequest, final HttpServle= tResponse theResponse, final String theUrl) > The advantage of such a utils-class would be a always compatibly thirdpar= ty code (integration code), if the redirecting-code changes in a4j my code = should still work :D -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============3100315122514616718==-- From jira-events at lists.jboss.org Tue Jun 8 10:02:38 2010 Content-Type: multipart/mixed; boundary="===============8111236943937637159==" MIME-Version: 1.0 From: Nick Belaevski (JIRA) To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Updated: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class Date: Tue, 08 Jun 2010 10:02:38 -0400 Message-ID: <2082002585.3349.1276005758437.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1885516285.1255506905723.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com --===============8111236943937637159== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/RF-7984?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:all-tabpanel ] Nick Belaevski updated RF-7984: ------------------------------- Comment: was deleted (was: Filter is not used in RF anymore. ) > I would be nice to have the BaseXML redirecting-code in a util-class > -------------------------------------------------------------------- > > Key: RF-7984 > URL: https://jira.jboss.org/browse/RF-7984 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) = > Components: core > Affects Versions: 3.3.2.GA > Reporter: Andreas H=C3=B6hmann > Assignee: Nick Belaevski > Priority: Minor > > I wrote a special spring security entry point to handle missing authentic= ation *after* a a4j-request: > /** > * {@inheritDoc} > */ > @Override > protected void sendRedirect(final HttpServletRequest theRequest, final = HttpServletResponse theResponse, > final String theUrl) throws IOException { > if (!isAjaxRequest(theRequest)) { > LOG.debug("normal redirect to " + theUrl); > super.sendRedirect(theRequest, theResponse, theUrl); > } else { > LOG.debug("ajax redirect to " + theUrl); > final FilterServletResponseWrapper servletResponseWrapper =3D new F= ilterServletResponseWrapper(theResponse); > final Writer output =3D resetResponse(theResponse, servletResponseW= rapper, "redirect"); > theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, t= heUrl); > // For buggy XmlHttpRequest realisations repeat headers in > // > output.write("\n" > + "" + " + AjaxContainerRenderer.AJAX_FLAG_HEADER + "\" content=3D\"redi= rect\" />" + " + AjaxContainerRenderer.AJAX_LOCATION_HEADER + "\" content=3D\"= " + theUrl + "\" />" + ""); > output.flush(); > theResponse.flushBuffer(); > } > } > Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.Bas= eXMLFilter to reuse it. > It would be nice to have a "A4JResponseUtils" with this methods: > - boolean isAjaxRequest(final ServletRequest request) > - void sendRedirect(final HttpServletRequest theRequest, final HttpServle= tResponse theResponse, final String theUrl) > The advantage of such a utils-class would be a always compatibly thirdpar= ty code (integration code), if the redirecting-code changes in a4j my code = should still work :D -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============8111236943937637159==-- From jira-events at lists.jboss.org Tue Jun 8 10:02:38 2010 Content-Type: multipart/mixed; boundary="===============0315805740373411922==" MIME-Version: 1.0 From: Nick Belaevski (JIRA) To: richfaces-issues at lists.jboss.org Subject: [richfaces-issues] [JBoss JIRA] Commented: (RF-7984) I would be nice to have the BaseXML redirecting-code in a util-class Date: Tue, 08 Jun 2010 10:02:38 -0400 Message-ID: <615213335.3352.1276005758521.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1885516285.1255506905723.JavaMail.jboss@jira01.app.mwc.hst.phx2.redhat.com --===============0315805740373411922== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/RF-7984?page=3Dcom.atlassian.jira.plugi= n.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534476#action= _12534476 ] = Nick Belaevski commented on RF-7984: ------------------------------------ Filter is not used in RF 4.x anymore. > I would be nice to have the BaseXML redirecting-code in a util-class > -------------------------------------------------------------------- > > Key: RF-7984 > URL: https://jira.jboss.org/browse/RF-7984 > Project: RichFaces > Issue Type: Feature Request > Security Level: Public(Everyone can see) = > Components: core > Affects Versions: 3.3.2.GA > Reporter: Andreas H=C3=B6hmann > Assignee: Nick Belaevski > Priority: Minor > > I wrote a special spring security entry point to handle missing authentic= ation *after* a a4j-request: > /** > * {@inheritDoc} > */ > @Override > protected void sendRedirect(final HttpServletRequest theRequest, final = HttpServletResponse theResponse, > final String theUrl) throws IOException { > if (!isAjaxRequest(theRequest)) { > LOG.debug("normal redirect to " + theUrl); > super.sendRedirect(theRequest, theResponse, theUrl); > } else { > LOG.debug("ajax redirect to " + theUrl); > final FilterServletResponseWrapper servletResponseWrapper =3D new F= ilterServletResponseWrapper(theResponse); > final Writer output =3D resetResponse(theResponse, servletResponseW= rapper, "redirect"); > theResponse.setHeader(AjaxContainerRenderer.AJAX_LOCATION_HEADER, t= heUrl); > // For buggy XmlHttpRequest realisations repeat headers in > // > output.write("\n" > + "" + " + AjaxContainerRenderer.AJAX_FLAG_HEADER + "\" content=3D\"redi= rect\" />" + " + AjaxContainerRenderer.AJAX_LOCATION_HEADER + "\" content=3D\"= " + theUrl + "\" />" + ""); > output.flush(); > theResponse.flushBuffer(); > } > } > Currently i'm must copy the redirecting-code from org.ajax4jsf.webapp.Bas= eXMLFilter to reuse it. > It would be nice to have a "A4JResponseUtils" with this methods: > - boolean isAjaxRequest(final ServletRequest request) > - void sendRedirect(final HttpServletRequest theRequest, final HttpServle= tResponse theResponse, final String theUrl) > The advantage of such a utils-class would be a always compatibly thirdpar= ty code (integration code), if the redirecting-code changes in a4j my code = should still work :D -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============0315805740373411922==--