From jira-events at lists.jboss.org Wed Mar 27 04:42:42 2013
Content-Type: multipart/mixed; boundary="===============8160519415707976435=="
MIME-Version: 1.0
From: David Lee (JIRA) <jira-events at lists.jboss.org>
To: richfaces-issues at lists.jboss.org
Subject: [richfaces-issues] [JBoss JIRA] (RF-12860) AccordionItem.js with
 error cause browser crash
Date: Wed, 27 Mar 2013 04:42:42 -0400
Message-ID: <JIRA.12487682.1363862211000.22130.1364373762005@jira02.app.mwc.hst.phx2.redhat.com>
In-Reply-To: JIRA.12487682.1363862211000@jira02.app.mwc.hst.phx2.redhat.com

--===============8160519415707976435==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


    [ https://issues.jboss.org/browse/RF-12860?page=3Dcom.atlassian.jira.pl=
ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12763370#com=
ment-12763370 ] =


David Lee commented on RF-12860:
--------------------------------

Hi Jan,

I been tried for your code,
and true...it won't happened.

And I tried to find what's wrong in my code,
I found if I add the following JavaScript it will crash.

But I add these code to your code it's fine.
Still trying to debug.

<script type=3D"text/javascript">

		//<![CDATA[
/*
       * For Map
       * =

       */
      Array.prototype.remove =3D function(s) {
          for (var i =3D 0; i < this.length; i++) {
              if (s =3D=3D this[i])
                  this.splice(i, 1);
          }
      };

      function Map() {
          this.keys =3D new Array();
          this.data =3D new Object();

          this.put =3D function(key, value) {
              if(this.data[key] =3D=3D null){
                  this.keys.push(key);
              }
              this.data[key] =3D value;
          };

          this.get =3D function(key) {
              return this.data[key];
          };

          this.remove =3D function(key) {
              this.keys.remove(key);
              this.data[key] =3D null;
          };

          this.each =3D function(fn){
              if(typeof fn !=3D 'function'){
                  return;
              }
              var len =3D this.keys.length;
              for(var i=3D0;i<len;i++){
                  var k =3D this.keys[i];
                  fn(k,this.data[k],i);
              }
          };

          this.entrys =3D function() {
              var len =3D this.keys.length;
              var entrys =3D new Array(len);
              for (var i =3D 0; i < len; i++) {
                  entrys[i] =3D {
                      key : this.keys[i],
                      value : this.data[i]
                  };
              }
              return entrys;
          };

          this.isEmpty =3D function() {
              return this.keys.length =3D=3D 0;
          };

          this.size =3D function(){
              return this.keys.length;
          };

          this.toString =3D function(){
              var s =3D "{";
              for(var i=3D0;i<this.keys.length;i++,s+=3D','){
                  var k =3D this.keys[i];
                  s +=3D k+"=3D"+this.data[k];
              }
              s+=3D"}";
              return s;
          };
      }
      =

      //]]> =

    </script>
                =

> AccordionItem.js with error cause browser crash
> -----------------------------------------------
>
>                 Key: RF-12860
>                 URL: https://issues.jboss.org/browse/RF-12860
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) =

>          Components: component-output
>    Affects Versions: 4.3.0.Final
>         Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
>            Reporter: David Lee
>            Assignee: Jan Papousek
>              Labels: javascript, rich:accordionItem
>             Fix For: 4.3.2
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error] 	=

> h -=3D items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> }); =

> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira

--===============8160519415707976435==--