From issues at jboss.org Thu Mar  6 04:53:34 2014
Content-Type: multipart/mixed; boundary="===============5232110196876396486=="
MIME-Version: 1.0
From: =?utf-8?q?Luk=C3=A1=C5=A1_Fry=C4=8D_=28JIRA=29_=3Cissues_at_jboss=2Eorg?=
 =?utf-8?q?=3E?=
To: richfaces-issues at lists.jboss.org
Subject: [richfaces-issues] [JBoss JIRA] (RF-13567) JavaScriptService executes
 javascript before the complete event
Date: Thu, 06 Mar 2014 04:53:34 -0500
Message-ID: <JIRA.12534240.1394090128000.8045.1394099614207@jira02.app.mwc.hst.phx2.redhat.com>
In-Reply-To: JIRA.12534240.1394090128000@jira02.app.mwc.hst.phx2.redhat.com

--===============5232110196876396486==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


    [ https://issues.jboss.org/browse/RF-13567?page=3Dcom.atlassian.jira.pl=
ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12950600#com=
ment-12950600 ] =


Luk=C3=A1=C5=A1 Fry=C4=8D edited comment on RF-13567 at 3/6/14 4:52 AM:
---------------------------------------------------------

Brian, I don't think this is incorrect behavior unless I miss something.

* onbeforedomupdate is called
* DOM is updated by JSF
** note: this step may execute <script>s included in the response (not comp=
letely sure when it is evaluated)
* javascriptService is called on before complete event
* oncomplete is called

So the elements should be placed in the DOM already when DOM is updated. ^

Is it not possible that JSF DOM update causes to add a <script> with jQuery=
 plugin execution and it is this script execution that adds elements you ex=
pect to be present already?

----

Note: the oncomplete event serves as notification for the user to know that=
 every synchronous update of the page caused by partial response was proces=
sed. There should be no RichFaces specific logic following the execution of=
 oncomplete event.

                =

      was (Author: lfryc):
    Brian, I don't think this is incorrect behavior unless I miss something.

* onbeforedomupdate is called
* DOM is updated by JSF
* javascriptService is called on before complete event
* oncomplete is called

So the elements should be placed in the DOM already when DOM is updated. ^

Is it not possible that JSF DOM update causes to add a <script> with jQuery=
 plugin execution and it is this script execution that adds elements you ex=
pect to be present already?

----

Note: the oncomplete event serves as notification for the user to know that=
 every synchronous update of the page caused by partial response was proces=
sed. There should be no RichFaces specific logic following the execution of=
 oncomplete event.

                  =

> JavaScriptService executes javascript before the complete event
> ---------------------------------------------------------------
>
>                 Key: RF-13567
>                 URL: https://issues.jboss.org/browse/RF-13567
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) =

>            Reporter: Brian Leathem
>
> Using the javascript service to execute jQuery plugins ends up with the p=
lugin being executed before the new elements are placed in the DOM.  This r=
esults in stale element references during subsequent plugin execution.
> Console log with r:log enabled:
> {code}
> RichFaces: New request added to queue. Queue requestGroupingId changed to=
 form1:richTable:0:collapsibleSubTable log.js:195
> RichFaces: Queue will wait 0ms before submit log.js:195
> RichFaces: richfaces.queue: will submit request NOW log.js:195
> RichFaces: Received 'begin' event from <tbody id=3Dform1:richTable:0:coll=
apsibleSubTable class=3Drf-cst ...> log.js:195
> Destroy called for sub-table-bridge of element: form1:richTable:0:collaps=
ibleSubTable sub-table-bridge.js:89
> Destroy called for sub-table of element: form1:richTable:0:collapsibleSub=
Table sub-table.js:71
> RichFaces: Received 'beforedomupdate' event from <tbody id=3Dform1:richTa=
ble:0:collapsibleSubTable class=3Drf-cst ...> log.js:195
> RichFaces: <span>Server returned responseText: </span><span class=3D"rf-l=
og-entry-msg-xml">&lt;partial-response id=3D"j_id1"&gt;&lt;changes&gt;&lt;u=
pdate id=3D"form1:richTable:0:collapsibleSubTable"&gt;&lt;![CDATA[&lt;tbody=
 id=3D"form1:richTable:0:collapsibleSubTable" class=3D"rf-cst"&gt;&lt;tr id=
=3D"form1:richTable:0:collapsibleSubTable:f" class=3D"rf-cst-ftr"&gt;&lt;td=
 class=3D"rf-cst-ftr-c" colspan=3D"3"&gt;footer&lt;ul class=3D"data-scrolle=
r " id=3D"form1:richTable:0:collapsibleSubTable:subscroller"&gt;&lt;li&gt;&=
lt;a class=3D"rf-ds-btn rf-ds-btn-first rf-ds-dis" id=3D"form1:richTable:0:=
collapsibleSubTable:subscroller_ds_f"&gt;=C2=AB=C2=AB=C2=AB=C2=AB&lt;/a&gt;=
&lt;/li&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-fastrwd rf-ds-dis" =
id=3D"form1:richTable:0:collapsibleSubTable:subscroller_ds_fr"&gt;=C2=AB=C2=
=AB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-prev r=
f-ds-dis" id=3D"form1:richTable:0:collapsibleSubTable:subscroller_ds_prev"&=
gt;=C2=AB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-=
next rf-ds-dis" id=3D"form1:richTable:0:collapsibleSubTable:subscroller_ds_=
next"&gt;=C2=BB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-d=
s-btn-fastfwd rf-ds-dis" id=3D"form1:richTable:0:collapsibleSubTable:subscr=
oller_ds_ff"&gt;=C2=BB=C2=BB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"r=
f-ds-btn rf-ds-btn-last rf-ds-dis" id=3D"form1:richTable:0:collapsibleSubTa=
ble:subscroller_ds_l"&gt;=C2=BB=C2=BB=C2=BB=C2=BB&lt;/a&gt;&lt;/li&gt;&lt;s=
cript type=3D"text/javascript"&gt;new RichFaces.ui.DataScroller("form1:rich=
Table:0:collapsibleSubTable:subscroller",function(event,element,data){RichF=
aces.ajax("form1:richTable:0:collapsibleSubTable:subscroller",event,{"param=
eters":{"form1:richTable:0:collapsibleSubTable:subscroller:page":data.page}=
 ,"incId":"1"} )},{"digitals":{} ,"buttons":{} ,"currentPage":1} )&lt;/scri=
pt&gt;&lt;/ul&gt;&lt;/td&gt;&lt;/tr&gt;&lt;tr id=3D"form1:richTable:0:colla=
psibleSubTable:sc" style=3D"display: none;"&gt;&lt;td&gt;&lt;input id=3D"fo=
rm1:richTable:0:collapsibleSubTable:state" name=3D"form1:richTable:0:collap=
sibleSubTable:state" type=3D"hidden" value=3D"0" /&gt;&lt;input id=3D"form1=
:richTable:0:collapsibleSubTable:options" name=3D"form1:richTable:0:collaps=
ibleSubTable:options" type=3D"hidden" /&gt;&lt;/td&gt;&lt;/tr&gt;&lt;/tbody=
&gt;]]&gt;&lt;/update&gt;&lt;update id=3D"j_id1:javax.faces.ViewState:0"&gt=
;&lt;![CDATA[-7868019542578483246:-4058924891838140372]]&gt;&lt;/update&gt;=
&lt;extension id=3D"org.richfaces.extension"&gt;&lt;complete&gt;RichFaces.j=
Query(document.getElementById('form1:richTable:0:collapsibleSubTable')).sub=
TableBridge({"optionsInput":"form1:richTable:0:collapsibleSubTable:options"=
,"formId":"form1","expandMode":"ajax","stateInput":"form1:richTable:0:colla=
psibleSubTable:state","eventOptions":{"incId":"1"} } );RichFaces.javascript=
ServiceComplete();;&lt;/complete&gt;&lt;render&gt;form1:richTable:0:collaps=
ibleSubTable(a)body &lt;/render&gt;&lt;/extension&gt;&lt;/changes&gt;&lt;/p=
artial-response&gt;</span> log.js:195
> RichFaces: <span>Listing content of response <b>changes</b> element:<br>E=
lement <b>update</b> for id=3Dform1:richTable:0:collapsibleSubTable<br><spa=
n class=3D"rf-log-entry-msg-xml">&lt;update id=3D"form1:richTable:0:collaps=
ibleSubTable"&gt;&lt;![CDATA[&lt;tbody id=3D"form1:richTable:0:collapsibleS=
ubTable" class=3D"rf-cst"&gt;&lt;tr id=3D"form1:richTable:0:collapsibleSubT=
able:f" class=3D"rf-cst-ftr"&gt;&lt;td class=3D"rf-cst-ftr-c" colspan=3D"3"=
&gt;footer&lt;ul class=3D"data-scroller " id=3D"form1:richTable:0:collapsib=
leSubTable:subscroller"&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-fir=
st rf-ds-dis" id=3D"form1:richTable:0:collapsibleSubTable:subscroller_ds_f"=
&gt;=C2=AB=C2=AB=C2=AB=C2=AB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"r=
f-ds-btn rf-ds-btn-fastrwd rf-ds-dis" id=3D"form1:richTable:0:collapsibleSu=
bTable:subscroller_ds_fr"&gt;=C2=AB=C2=AB&lt;/a&gt;&lt;/li&gt;&lt;li&gt;&lt=
;a class=3D"rf-ds-btn rf-ds-btn-prev rf-ds-dis" id=3D"form1:richTable:0:col=
lapsibleSubTable:subscroller_ds_prev"&gt;=C2=AB&lt;/a&gt;&lt;/li&gt;&lt;li&=
gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-next rf-ds-dis" id=3D"form1:richTable=
:0:collapsibleSubTable:subscroller_ds_next"&gt;=C2=BB&lt;/a&gt;&lt;/li&gt;&=
lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-fastfwd rf-ds-dis" id=3D"form1:=
richTable:0:collapsibleSubTable:subscroller_ds_ff"&gt;=C2=BB=C2=BB&lt;/a&gt=
;&lt;/li&gt;&lt;li&gt;&lt;a class=3D"rf-ds-btn rf-ds-btn-last rf-ds-dis" id=
=3D"form1:richTable:0:collapsibleSubTable:subscroller_ds_l"&gt;=C2=BB=C2=BB=
=C2=BB=C2=BB&lt;/a&gt;&lt;/li&gt;&lt;script type=3D"text/javascript"&gt;new=
 RichFaces.ui.DataScroller("form1:richTable:0:collapsibleSubTable:subscroll=
er",function(event,element,data){RichFaces.ajax("form1:richTable:0:collapsi=
bleSubTable:subscroller",event,{"parameters":{"form1:richTable:0:collapsibl=
eSubTable:subscroller:page":data.page} ,"incId":"1"} )},{"digitals":{} ,"bu=
ttons":{} ,"currentPage":1} )&lt;/script&gt;&lt;/ul&gt;&lt;/td&gt;&lt;/tr&g=
t;&lt;tr id=3D"form1:richTable:0:collapsibleSubTable:sc" style=3D"display: =
none;"&gt;&lt;td&gt;&lt;input id=3D"form1:richTable:0:collapsibleSubTable:s=
tate" name=3D"form1:richTable:0:collapsibleSubTable:state" type=3D"hidden" =
value=3D"0" /&gt;&lt;input id=3D"form1:richTable:0:collapsibleSubTable:opti=
ons" name=3D"form1:richTable:0:collapsibleSubTable:options" type=3D"hidden"=
 /&gt;&lt;/td&gt;&lt;/tr&gt;&lt;/tbody&gt;]]&gt;&lt;/update&gt;</span><br>E=
lement <b>update</b> for id=3Dj_id1:javax.faces.ViewState:0<br><span class=
=3D"rf-log-entry-msg-xml">&lt;update id=3D"j_id1:javax.faces.ViewState:0"&g=
t;&lt;![CDATA[-7868019542578483246:-4058924891838140372]]&gt;&lt;/update&gt=
;</span><br>Element <b>extension</b> for id=3Dorg.richfaces.extension<br><s=
pan class=3D"rf-log-entry-msg-xml">&lt;extension id=3D"org.richfaces.extens=
ion"&gt;&lt;complete&gt;RichFaces.jQuery(document.getElementById('form1:ric=
hTable:0:collapsibleSubTable')).subTableBridge({"optionsInput":"form1:richT=
able:0:collapsibleSubTable:options","formId":"form1","expandMode":"ajax","s=
tateInput":"form1:richTable:0:collapsibleSubTable:state","eventOptions":{"i=
ncId":"1"} } );RichFaces.javascriptServiceComplete();;&lt;/complete&gt;&lt;=
render&gt;form1:richTable:0:collapsibleSubTable(a)body &lt;/render&gt;&lt;/=
extension&gt;</span><br></span> log.js:195
> Create called for sub-table-bridge of element: form1:richTable:0:collapsi=
bleSubTable sub-table-bridge.js:42
> Create called for sub-table of element: form1:richTable:0:collapsibleSubT=
able sub-table.js:22
> RichFaces: richfaces.queue: ajax submit successfull log.js:195
> RichFaces: richfaces.queue: Nothing to submit log.js:195
> RichFaces: Received 'success' event from <tbody id=3Dform1:richTable:0:co=
llapsibleSubTable class=3Drf-cst ...> log.js:195
> RichFaces: Received 'complete' event from <tbody id=3Dform1:richTable:0:c=
ollapsibleSubTable class=3Drf-cst ...> log.js:195
> {code}
> Note the "create" debug statements called from the plugin _create methods=
 occur before we get to the complete event.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira


--===============5232110196876396486==--