[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Jiří Štefek edited comment on RFPL-3195 at 1/28/14 9:52 AM:
------------------------------------------------------------
Some notable notes I forget to put here:
ITTestJsFunction:
the test was failing on WildFly but not on EAP
The problem was in listener method of backing bean. There is a different behaviour between containers:
* EAP 6.1.0: no listener method is invoked (if there is no proper one), but param IS PASSED to bean
* WildFly: error javax.el.MethodNotFoundException: Method not found: org.richfaces.ui.ajax.AjaxBean(a)426dc56c.listener() is thrown and param IS NOT PASSED to bean
Resolution: the bean has to contain a proper listener method: either listener(ActionEvent event) or listener().
----
ITPanelMenu:
* ok on EAP
* on Wildfly:
{code}
java.lang.RuntimeException: Could not inject members
java.lang.IllegalArgumentException: Can not set org.richfaces.ui.toggle.panelMenu.PanelMenuBean field org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur.panelMenuBean to org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur
{code}
Seems that it was injecting the wrong instance to the field. Resolution: imported both classes from static class to WAR.
was (Author: jstefek):
Some notable notes I forget to put here:
ITTestJsFunction:
the test was failing on WildFly but not on EAP
The problem was in listener method of backing bean. there is a different behaviour between containers:
* EAP 6.1.0: no listener method is invoked, but param IS passed to bean
* WildFly: error javax.el.MethodNotFoundException: Method not found: org.richfaces.ui.ajax.AjaxBean(a)426dc56c.listener() is thrown and param IS NOT passed to bean
Resolution: the bean has to contain a proper listener method: either listener(ActionEvent event) or listener().
----
ITPanelMenu:
* ok on EAP
* on Wildfly:
{code}
java.lang.RuntimeException: Could not inject members
java.lang.IllegalArgumentException: Can not set org.richfaces.ui.toggle.panelMenu.PanelMenuBean field org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur.panelMenuBean to org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur
{code}
Seems that it was injecting the wrong instance to the field. Resolution: imported both classes from static class to WAR.
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Jiří Štefek commented on RFPL-3195:
-----------------------------------
Some notable notes I forget to put here:
ITTestJsFunction:
the test was failing on WildFly but not on EAP
The problem was in listener method of backing bean. there is a different behaviour between containers:
* EAP 6.1.0: no listener method is invoked, but param IS passed to bean
* WildFly: error javax.el.MethodNotFoundException: Method not found: org.richfaces.ui.ajax.AjaxBean(a)426dc56c.listener() is thrown and param IS NOT passed to bean
Resolution: the bean has to contain a proper listener method: either listener(ActionEvent event) or listener().
----
ITPanelMenu:
* ok on EAP
* on Wildfly:
{code}
java.lang.RuntimeException: Could not inject members
java.lang.IllegalArgumentException: Can not set org.richfaces.ui.toggle.panelMenu.PanelMenuBean field org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur.panelMenuBean to org.richfaces.ui.toggle.panelMenu.VerifyMenuAction$DidOccur
{code}
Seems that it was injecting the wrong instance to the field. Resolution: imported both classes from static class to WAR.
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Lukáš Fryč edited comment on RFPL-3195 at 1/28/14 8:43 AM:
-----------------------------------------------------------
1.) Ah, okay, it means *Skin those tests fail sporadically as well.
2.) Nice catch - I'm creating an issue for 5.0.0.Alpha3 - RF-13519
was (Author: lfryc):
1.) Ah, okay, it means *Skin those tests fail sporadically as well.
2.) Nice catch - I'm creating an issue for 5.0.0.Alpha3.
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Lukáš Fryč commented on RFPL-3195:
----------------------------------
1.) Ah, okay, it means *Skin those tests fail sporadically as well.
2.) Nice catch - I'm creating an issue for 5.0.0.Alpha3.
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Jiří Štefek commented on RFPL-3195:
-----------------------------------
[~lfryc]:
# the *Skin tests -- I am not able to reproduce it. Locally it works correctly. Can you send me some link with staktraces?
# the charts samples are not working. There is a StackOverflowError in renderer on this [line|https://github.com/richfaces/richfaces/blob/b5a76f13544dda707ce2a634...]
Stacktrace:
{code}
java.lang.StackOverflowError
at java.util.EnumMap.isValidKey(EnumMap.java:313)
at java.util.EnumMap.get(EnumMap.java:245)
at org.richfaces.log.JavaLogger.isLogEnabled(JavaLogger.java:207)
at org.richfaces.log.JavaLogger.isDebugEnabled(JavaLogger.java:111)
at org.richfaces.renderkit.RendererBase.encodeBegin(RendererBase.java:106)
at org.richfaces.ui.output.chart.ChartRendererBase.doEncodeBegin(ChartRendererBase.java:188)
at org.richfaces.renderkit.RendererBase.encodeBegin(RendererBase.java:116)
at org.richfaces.ui.output.chart.ChartRendererBase.doEncodeBegin(ChartRendererBase.java:188)
...
{code}
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (RFPL-3195) Stabilize Framework Tests on supported containers
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RFPL-3195?page=com.atlassian.jira.plugin.... ]
Lukáš Fryč commented on RFPL-3195:
----------------------------------
Great stabilization work, [~jstefek]!
We need to introduce a new category for excluding JSF 2.2 tests - I will do that, it's hard to explain, but I will post a commit here later.
Additionally I can see still some tests failing on both EAP and WildFly, could you please look into them?
{code}
org.richfaces.ui.chart.ITChartEvents.ServerSideClick
org.richfaces.ui.chart.ITChartEvents.ChartCreated
org.richfaces.ui.chart.ITChartEvents.particularSeriesServerSideClick
org.richfaces.ui.chart.ITChartEvents.ClientSideClick
org.richfaces.skin.ITBlueSkySkin.test_skin
org.richfaces.skin.ITSkin.changing_skins
{code}
Current branch before merging to master:
https://github.com/richfaces/richfaces/tree/RFPL-3195-stabilizing-framewo...
> Stabilize Framework Tests on supported containers
> -------------------------------------------------
>
> Key: RFPL-3195
> URL: https://issues.jboss.org/browse/RFPL-3195
> Project: RichFaces Planning
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: QE
> Reporter: Lukáš Fryč
> Assignee: Jiří Štefek
> Fix For: 5.0.0.Alpha3
>
>
> Lot of tests are currently failing on EAP and WildFly:
> https://gist.github.com/lfryc/962b0eab11e8d0536a33
> We should stabilize the tests on containers where we expect 100% compatibility - JBoss EAP 6.2 at the moment, so we could use the tests for regression testing.
> We should either:
> 1) fix a framework test
> 2) find an framework issue and report it
> Subsequently we may want to mark some tests as Failing or FailingOnCertainEnvironment, but that is preliminary atm.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months