9:41 a.m.
Apply Eng Review Results (1st half)
-----------------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:43 a.m.
New subject: [JBoss JIRA] Updated: (RFPL-1350) Apply Eng Review Results (1st half)
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky updated RFPL-1350:
----------------------------------
Attachment: dev guide ishaikovsky review 2 - ready.doc
first half of the doc.
look to comments and also consider please corrections(I used track changes so should see
all)
Apply Eng Review Results (1st half)
-----------------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 a.m.
New subject: [JBoss JIRA] Assigned: (RFPL-1350) Apply Eng Review Results (1st half)
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Sean Rogers reassigned RFPL-1350:
---------------------------------
Assignee: Ilya Shaikovsky (was: Sean Rogers)
Thanks Ilya, great review!
I have a question:
- In the "Compiling source code" section, you say JBoss developer settings
aren't required. Can I cut this whole step from the procedure, or is some other Maven
configuration necessary?
And a couple of notes:
- I need to check with Jay about the build location when using -P release
- In the "Changing skins at runtime" section, I've removed the example
because you pointed out a number of problems with it. We can add it back in later with an
updated example.
Apply Eng Review Results (1st half)
-----------------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 a.m.
New subject: [JBoss JIRA] Updated: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky updated RFPL-1350:
----------------------------------
Summary: Apply Eng Review Results (was: Apply Eng Review Results (1st half))
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 a.m.
New subject: [JBoss JIRA] Updated: (RFPL-1350) Apply Eng Review Results (1st half)
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky updated RFPL-1350:
----------------------------------
Attachment: dev guide ishaikovsky review (second half).doc
Sean, here is the second half of the review. (will just rename the task and not create
separate one for it)
Apply Eng Review Results (1st half)
-----------------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:03 a.m.
New subject: [JBoss JIRA] Commented: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky commented on RFPL-1350:
---------------------------------------
In the "Compiling source code" section, you say JBoss developer settings
aren't required. Can I cut this whole step from the procedure, or is some other Maven
configuration necessary?
Ideally only settings from 2.4.2 should be
there.(http://community.jboss.org/docs/DOC-15169) Could be some issues with that :/ but if
so we should just resolve on our side. And the build should be available with just user
settings.
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:05 a.m.
New subject: [JBoss JIRA] Assigned: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky reassigned RFPL-1350:
-------------------------------------
Assignee: Sean Rogers (was: Ilya Shaikovsky)
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:36 a.m.
New subject: [JBoss JIRA] Assigned: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Sean Rogers reassigned RFPL-1350:
---------------------------------
Assignee: Ilya Shaikovsky (was: Sean Rogers)
Thanks Ilya.
I've incorporated all your suggestions. I've rearranged and changed the skinning
section a lot, as it was very out of date. I think it flows a lot better now too.
Have a look over and see if you have any more suggestions. If you haven't got time
just now, just assign back to me and I can close the Jira and create a review Jira for
later.
The new version is at
http://docs.jboss.org/richfaces/nightly_4_0_X/Developer_Guide/en-US/html_...
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Ilya Shaikovsky
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 a.m.
New subject: [JBoss JIRA] Updated: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky updated RFPL-1350:
----------------------------------
Assignee: Sean Rogers (was: Ilya Shaikovsky)
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 a.m.
New subject: [JBoss JIRA] Commented: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Ilya Shaikovsky commented on RFPL-1350:
---------------------------------------
Sean, being busy (and actually even out of schedule for final) I really will not be able
to look prior to final. So let the other guys will do their review if have time. Create
please separate jira and I will do as far as will have time.
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
New subject: [JBoss JIRA] Resolved: (RFPL-1350) Apply Eng Review Results
[
https://issues.jboss.org/browse/RFPL-1350?page=com.atlassian.jira.plugin....
]
Sean Rogers resolved RFPL-1350.
-------------------------------
Resolution: Done
Revised according to review.
Apply Eng Review Results
------------------------
Key: RFPL-1350
URL: https://issues.jboss.org/browse/RFPL-1350
Project: RichFaces Planning
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: doc
Reporter: Ilya Shaikovsky
Assignee: Sean Rogers
Fix For: 4.0.0.Final
Attachments: dev guide ishaikovsky review (second half).doc, dev guide
ishaikovsky review 2 - ready.doc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5520
days inactive
5527
days old
richfaces-planning-issues@lists.jboss.org
10 comments
2 participants
participants (2)
-
Ilya Shaikovsky (JIRA) -
Sean Rogers (JIRA)