Op 23-02-13 11:00, Charles Moulliard schreef:
I have only added

<packaging>bundle</packaging>
Looks like most of this was already done on master in December 2012.
The confusion stems from the pull requests being for 5.5.x, instead of master.

and modify or add this plugin

            <plugin>
                <groupId>org.apache.felix</groupId>
                <artifactId>maven-bundle-plugin</artifactId>
                <extensions>true</extensions>
                <version>${maven-felix-plugin.version}</version>
                <executions>
                    <execution>
                        <id>manifest</id>
                        <phase>process-classes</phase>
                        <goals>
                            <goal>manifest</goal>
                        </goals>
                    </execution>
<execution> is no longer needed due to <packaging>bundle</packaging> and parent pom inheritence on master
                </executions>
                <configuration>
                    <manifestLocation>META-INF</manifestLocation>
<manifestLocation> is no longer needed due to <packaging>bundle</packaging> on master
                    <instructions>
                        <Bundle-SymbolicName>org.drools.camel</Bundle-SymbolicName>
Could you make a _minimal_ list of the modules that aren't osgi-fied and would need to get osgi-fied?
                        <Import-Package>
                            !org.drools.camel.component,
                            !org.drools.jax.rs,
                            !org.drools.jax.soap,
                            *
                        </Import-Package>
                        <Export-Package>
                            org.drools.camel.component,
                            org.drools.jax.rs,
                            org.drools.jax.soap
                        </Export-Package>
                        <!-- <DynamicImport-Package>*</DynamicImport-Package> -->
It would be great if we can remove DynamicImport-Package. Have you tested that it's ok to remove this?
It has something to do with reflection, and drools does use reflection at runtime :)
                    </instructions>
                </configuration>
            </plugin>
  


On Fri, Feb 22, 2013 at 10:40 PM, Mark Proctor <mproctor@codehaus.org> wrote:
The XML files aren't diffing well, it's removing and replacing the entire file. Which makes it impossible to review what you've done.

Mark
On 22 Feb 2013, at 17:33, Charles Moulliard <ch007m@gmail.com> wrote:

Hi,

Can somebody has a look on the following pull requests that I send to allow to deploy Drools (https://issues.jboss.org/browse/DROOLS-49) on Apache Karaf :



Regards,
--
Charles Moulliard
Apache Committer / Sr. Enterprise Architect (RedHat)
Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com

_______________________________________________
rules-dev mailing list
rules-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev


_______________________________________________
rules-dev mailing list
rules-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev



--
Charles Moulliard
Apache Committer / Sr. Enterprise Architect (RedHat)
Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com



_______________________________________________
rules-dev mailing list
rules-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev