Ignore my last mail, I interpreted this statement wrong:

Anyway, I'll take care of the tests in drools-decisiontables and drools-template
You mean the @Ignore's probably, not turning them into JUnit4 tests :)

Op 29-12-10 17:07, Geoffrey De Smet schreef:
I also refactored all tests of drools-decisiontables and drools-template.
However, that doesn't include your new tests not pushed to master yet, naturally.

If it's not a new test, you might have had a merge conflict with my changes on the test.
Are you sure "git pull --rebase" did not speak of a merge conflict?
(note git doesn't use the term "merge conflict" always, but more specific terms sometimes)

Op 29-12-10 15:54, Wolfgang Laun schreef:
Geoffrey & Co.,

I called in one of the local Green Berets, and he finally resolved this matter. What I had was

class FooTest extends junit.framework.TestCase {
   //...
}

and this is sufficient to force the JUnit 3 test runner, which ignores all annotations. Using this

class FooTest{
   //...
}

and annotating all testX methods with @Test will use a JUnit4 test runner, which honours @Ignore.

Perhaps I misinterpreted Geoffrey's remark to do a pull --rebase - I thought this would update the XyzTest files he had changed, not some general update? (Also, being in the midst of some rework/refactoring, I didn't want to risk losing any of my work.)

Anyway, I'll take care of the tests in drools-decisiontables and drools-template.

Cheers
Wolfgang

_______________________________________________ rules-dev mailing list rules-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-dev

-- 
With kind regards,
Geoffrey De Smet
_______________________________________________ rules-dev mailing list rules-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-dev

-- 
With kind regards,
Geoffrey De Smet