Hey, didn't mean to come off as critical today.  You are doing a good job on this, and the basic rules stuff is spot on as far as functionality goes.  Words like *refactor* and *scrub* are just artifacts of code that has gone through several revision cycles (and I helped).  Functionally, it's working great, as intended, with no compromises in the design - or at least tiny ones.  If the code is a little hard to modify (due to a couple of years of active maintenance), that's not a big deal.
 
It really may be a very small deal.  It looks to me like this code is about to enter a fairly stable time.  It's pretty close to feature-complete, and it's working.  So then it's your call if and when you want to spend the time and effort to pretty it up a bit.  In a code base as big as this one, with as many things as need to be done, there's plenty of other low hanging fruit...  :-)
 
Have a good weekend, and try not to work on this stuff.
 

Jason Smith
Software Engineer
InfoTrust Group, Inc.

500 Discovery Parkway, Suite 200
Superior, CO 80027
Office 303-627-6571
Fax 303-666-6711
Email jsmith@infotrustgroup.com

WEB www.infotrustgroup.com

This e-mail and all information included herein do not constitute a legal agreement accorded by INFOTRUST GROUP and its affiliates and subsidiaries.  All legal agreements must be formulated in writing by a legal representative of INFOTRUST GROUP. This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed.  If you have received this e-mail by mistake, please inform us and destroy this e-mail and any documents it might contain.  Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.  Thank you for your cooperation.

From: rules-users-bounces@lists.jboss.org [rules-users-bounces@lists.jboss.org] On Behalf Of Paul R. [reverselogic@gmail.com]
Sent: Friday, April 30, 2010 5:40 PM
To: Rules Users List
Subject: Re: [rules-users] Missing space when using DSL and Guvnor

Hi Jeff,

I logged a bug for this one a while back, here's the JIRA, patch details included.

https://jira.jboss.org/jira/browse/GUVNOR-520

I would appreciate it if somebody could commit this for me :)

Cheers,

Paul

2010/4/30 Esteban Aliverti <esteban.aliverti@gmail.com>
It sounds like a bug. Can you double check it and create a jira issue please?

best,

2010/4/29 Doyel,Jeff <JDOYEL@cerner.com>
I am setting up a very simple example using a DSL and Guvnor.  My DSL is as follows:
 
[when]Age is less than {age} years old=AgeFact(ageInYears < {age})
 
When I attempt to create a new Business Rule using the Guvnor I can select the above expression just fine and the sentence displays as expected.  I then fill in the years with a numeric value (4) and validate.  Upon validation I receive the following error.
 
[Age Test Rule] [ERR 101] Line 4:2 no viable alternative at input 'Age' in rule "Age Test Rule"
 
I then view the source and it looks like this.
 
rule "Age Test Rule"
        dialect "mvel"
        when
                Age is less than 4years old
        then
end
 
I noticed that there is no space between the ‘4’ and the word ‘years’.  However, in my DSL sentence there is a space between {age} and years.  Another interesting thing, if I enter the number 4 followed by a space in the Guvnor form then the rule validates correctly.  Is this a bug or is it something I am doing wrong in my DSL?
 
Thanks,
Jeff
 
CONFIDENTIALITY NOTICE This message and any included attachments are from Cerner Corporation and are intended only for the addressee. The information contained in this message is confidential and may constitute inside or non-public information under international, federal, or state securities laws. Unauthorized forwarding, printing, copying, distribution, or use of such information is strictly prohibited and may be unlawful. If you are not the addressee, please promptly delete this message and notify the sender of the delivery error by e-mail or you may call Cerner's corporate offices in Kansas City, Missouri, U.S.A at (+1) (816)221-1024.

_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users




--
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

Esteban Aliverti

_______________________________________________
rules-users mailing list
rules-users@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users