From seam-commits at lists.jboss.org Fri Jan 22 16:22:05 2010
Content-Type: multipart/mixed; boundary="===============4940329666322308843=="
MIME-Version: 1.0
From: seam-commits at lists.jboss.org
To: seam-commits at lists.jboss.org
Subject: [seam-commits] Seam SVN: r11986 - in modules/xml/trunk:
src/main/java/org/jboss/seam/xml/bootstrap and 6 other directories.
Date: Fri, 22 Jan 2010 16:22:05 -0500
Message-ID: <201001222122.o0MLM5sU029355@svn01.web.mwc.hst.phx2.redhat.com>
--===============4940329666322308843==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Author: swd847
Date: 2010-01-22 16:22:04 -0500 (Fri, 22 Jan 2010)
New Revision: 11986
Added:
modules/xml/trunk/src/main/java/org/jboss/seam/xml/util/XmlConfiguration=
Exception.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/util/XmlParseExceptio=
n.java
Modified:
modules/xml/trunk/docs/src/main/en-US/xml-general.xml
modules/xml/trunk/src/main/java/org/jboss/seam/xml/bootstrap/XmlExtensio=
n.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/BeanResult.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/XmlResult.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/CollectionFi=
eldSet.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/DirectFieldS=
etter.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/FieldValueSe=
tter.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/MapFieldSet.=
java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/MethodFieldS=
etter.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/SimpleFieldV=
alue.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/AbstractXmlItem=
.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/AnnotationXmlIt=
em.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/ArrayXmlItem.ja=
va
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/ClassXmlItem.ja=
va
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/DependsXmlItem.=
java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/KeyXmlItem.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/MethodXmlItem.j=
ava
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/ModelBuilder.ja=
va
modules/xml/trunk/src/main/java/org/jboss/seam/xml/model/ValueXmlItem.ja=
va
modules/xml/trunk/src/main/java/org/jboss/seam/xml/parser/ParserMain.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/parser/namespace/Name=
spaceUtils.java
modules/xml/trunk/src/main/java/org/jboss/seam/xml/parser/namespace/Pack=
ageNamespaceElementResolver.java
Log:
improved handling of parse errors
Modified: modules/xml/trunk/docs/src/main/en-US/xml-general.xml
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/xml/trunk/docs/src/main/en-US/xml-general.xml 2010-01-22 19:28:=
28 UTC (rev 11985)
+++ modules/xml/trunk/docs/src/main/en-US/xml-general.xml 2010-01-22 21:22:=
04 UTC (rev 11986)
@@ -4,7 +4,7 @@
Seam XML Configuration
=
- Seam provides a method for configuring JSR-299 beans using XML. =
para>
+ Seam provides a method for configuring JSR-299 beans using XML. By=
default the XML configuration old defines new beans, it does not
=
=
Modified: modules/xml/trunk/src/main/java/org/jboss/seam/xml/bootstrap/XmlE=
xtension.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/xml/trunk/src/main/java/org/jboss/seam/xml/bootstrap/XmlExtensi=
on.java 2010-01-22 19:28:28 UTC (rev 11985)
+++ modules/xml/trunk/src/main/java/org/jboss/seam/xml/bootstrap/XmlExtensi=
on.java 2010-01-22 21:22:04 UTC (rev 11986)
@@ -16,6 +16,7 @@
import java.util.Map.Entry;
=
import javax.enterprise.event.Observes;
+import javax.enterprise.inject.spi.AfterBeanDiscovery;
import javax.enterprise.inject.spi.AnnotatedType;
import javax.enterprise.inject.spi.BeforeBeanDiscovery;
import javax.enterprise.inject.spi.Extension;
@@ -31,6 +32,7 @@
import org.jboss.seam.xml.parser.ParserMain;
import org.jboss.seam.xml.parser.SaxNode;
import org.jboss.seam.xml.util.FileDataReader;
+import org.jboss.seam.xml.util.XmlParseException;
import org.jboss.weld.extensions.util.AnnotationInstanceProvider;
=
public class XmlExtension implements Extension
@@ -42,9 +44,9 @@
=
List results =3D new ArrayList();
=
- Set veto =3D new HashSet();
+ Set> veto =3D new HashSet>();
=
- Map types =3D new HashMap();
+ Map, AnnotatedType>> types =3D new HashMap, Annotat=
edType>>();
=
int count =3D 0;
=
@@ -53,6 +55,8 @@
*/
Map> fieldValues =3D new HashMap>();
=
+ List parseErrors =3D new ArrayList();
+
/**
* This is the entry point for the extension
*/
@@ -73,7 +77,7 @@
{
ParserMain parser =3D new ParserMain();
ModelBuilder builder =3D new ModelBuilder();
- SaxNode parentNode =3D parser.parse(d.getInputSource(), d.g=
etFileUrl());
+ SaxNode parentNode =3D parser.parse(d.getInputSource(), d.g=
etFileUrl(), parseErrors);
;
results.add(builder.build(parentNode));
}
@@ -95,7 +99,7 @@
problemString.append("\n");
}
}
- for (BeanResult b : r.getFieldValues().keySet())
+ for (BeanResult> b : r.getFieldValues().keySet())
{
int val =3D count++;
fieldValues.put(val, r.getFieldValues().get(b));
@@ -105,11 +109,11 @@
b.getBuilder().addToClass(a);
}
=
- for (Class b : r.getQualifiers())
+ for (Class extends Annotation> b : r.getQualifiers())
{
event.addQualifier(b);
}
- for (Class b : r.getInterceptorBindings())
+ for (Class extends Annotation> b : r.getInterceptorBindings())
{
event.addInterceptorBinding(b);
}
@@ -117,7 +121,7 @@
{
event.addStereotype(b.getKey(), b.getValue());
}
- for (BeanResult bb : r.getBeans())
+ for (BeanResult> bb : r.getBeans())
{
boolean install =3D true;
for (Object className : bb.getDependencies())
@@ -134,7 +138,7 @@
}
if (install)
{
- AnnotatedType tp =3D bb.getBuilder().create();
+ AnnotatedType> tp =3D bb.getBuilder().create();
event.addAnnotatedType(tp);
types.put(tp.getJavaClass(), tp);
}
@@ -148,7 +152,7 @@
}
}
=
- public void processAnotated(@Observes ProcessAnnotatedType event)
+ public void processAnotated(@Observes ProcessAnnotatedType event)
{
// veto implementation
if (veto.contains(event.getAnnotatedType().getJavaClass()))
@@ -157,19 +161,27 @@
}
}
=
- public void processInjectionTarget(@Observes ProcessInjectionTarget eve=
nt)
+ public void processInjectionTarget(@Observes ProcessInjectionTarget=
event)
{
=
- AnnotatedType at =3D event.getAnnotatedType();
+ AnnotatedType at =3D event.getAnnotatedType();
XmlId xid =3D at.getAnnotation(XmlId.class);
if (xid !=3D null)
{
List fvs =3D fieldValues.get(xid.value());
- event.setInjectionTarget(new InjectionTargetWrapper(event.getInje=
ctionTarget(), fvs));
+ event.setInjectionTarget(new InjectionTargetWrapper(event.getI=
njectionTarget(), fvs));
}
=
}
=
+ public void processAfterBeanDeployment(@Observes AfterBeanDiscovery eve=
nt)
+ {
+ for (XmlParseException t : parseErrors)
+ {
+ event.addDefinitionError(t);
+ }
+ }
+
public List> getDocumentProviders()
{
List> ret =3D new ArrayList>();
@@ -207,5 +219,4 @@
}
return ret;
}
-
}
Modified: modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/BeanResul=
t.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/BeanResult.java=
2010-01-22 19:28:28 UTC (rev 11985)
+++ modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/BeanResult.java=
2010-01-22 21:22:04 UTC (rev 11986)
@@ -12,17 +12,17 @@
=
public class BeanResult
{
- NewAnnotatedTypeBuilder builder;
+ NewAnnotatedTypeBuilder builder;
List dependencies =3D new ArrayList();
- Class type;
+ Class type;
=
- public BeanResult(Class type)
+ public BeanResult(Class type)
{
this.type =3D type;
builder =3D new NewAnnotatedTypeBuilder(type);
}
=
- public NewAnnotatedTypeBuilder getBuilder()
+ public NewAnnotatedTypeBuilder getBuilder()
{
return builder;
}
@@ -37,7 +37,7 @@
return Collections.unmodifiableList(dependencies);
}
=
- public Class getType()
+ public Class getType()
{
return type;
}
Modified: modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/XmlResult=
.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/XmlResult.java =
2010-01-22 19:28:28 UTC (rev 11985)
+++ modules/xml/trunk/src/main/java/org/jboss/seam/xml/core/XmlResult.java =
2010-01-22 21:22:04 UTC (rev 11986)
@@ -27,13 +27,13 @@
=
List> interceptorBindings =3D new ArrayList=
>();
=
- List veto =3D new ArrayList();
+ List> veto =3D new ArrayList>();
=
List problems =3D new ArrayList();
=
- List beans =3D new ArrayList();
+ List> beans =3D new ArrayList>();
=
- Map> fieldValues =3D new HashMap>();
+ Map, List> fieldValues =3D new HashMap<=
BeanResult>, List>();
=
public Map, Annotation[]> getStereotypes()
{
@@ -50,7 +50,7 @@
return interceptorBindings;
}
=
- public List getBeans()
+ public List> getBeans()
{
return beans;
}
@@ -65,17 +65,17 @@
problems.add(p);
}
=
- public Map> getFieldValues()
+ public Map, List> getFieldValues()
{
return fieldValues;
}
=
- public void addVeto(Class clazz)
+ public void addVeto(Class> clazz)
{
veto.add(clazz);
}
=
- public List getVeto()
+ public List> getVeto()
{
return veto;
}
Modified: modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/Colle=
ctionFieldSet.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/CollectionF=
ieldSet.java 2010-01-22 19:28:28 UTC (rev 11985)
+++ modules/xml/trunk/src/main/java/org/jboss/seam/xml/fieldset/CollectionF=
ieldSet.java 2010-01-22 21:22:04 UTC (rev 11986)
@@ -32,7 +32,7 @@
{
FieldValueSetter field;
List values;
- Class elementType;
+ Class> elementType;
Class extends Collection> collectionType;
=
public CollectionFieldSet(FieldValueSetter field, List items)
@@ -48,7 +48,7 @@
=
setter =3D new CFS()
{
- public void add(Collection o) throws IllegalAccessException
+ public void add(Collection