Re: [security-dev] Refactoring of picketlink-integration-tests

Very nice. I have only a few questions for now: - Today we're able to execute a specific group of tests (saml, ws-trust, xacml, etc) for a specific container or all of them. Is this still possible ? - Is there any profile to run arquillian using a remote container ? That would make a lot easier to add and debug things. - The ServerSetup is only for SecurityDomains or it can be used to any other configuration in standalone.xml ? - Is it possible to run the test against a specific PicketLink Version ? Without having to change poms or any config file ? I would like to start using this new repo for some PicketLink 2.5 tests. That way I can give more feedbacks. Thanks. Pedro Igor ----- Original Message ----- From: "Ondra Lukas" <olukas(a)redhat.com&gt; To: security-dev(a)lists.jboss.org Sent: Wednesday, June 26, 2013 9:25:10 AM Subject: Re: [security-dev] Refactoring of picketlink-integration-tests Hi, I have some progress in refactoring of PicketLink testsuite. Most important part for us is EAP 6 and for this reason all changes are connected with eap-6 profile meanwhile. It's still working version. Take a look at https://github.com/jboss-security-qe/picketlink-integration-tests/tree/pl.... What's new? 1) I copied ServerSetup from Wildfly testsuite and modified it for using in PicketLink testsuite. It is used for adding security domains instead of XSLT in jbas7/eap6 (addSecurityDomain.xslt). Every test which use some security domains adds that domains by annotation @ServerSetup({names_of_domains}). Security domains are defined in SecurityDomainServerSetupTask - there are domains which are currently used by tests and new domain can be added later. However ServerSetup is compatible only with EAP 6.1 (there is little difference in adding security domain via Management API in EAP 6.0 and EAP 6.1), using with EAP 6.0 will be added later. 2) Tests are divided into packages according to containers. We have 5 types of packages: jbas7, eap6, jbas5, eap5 and common. Every profile runs test in some package according to: - profile jbas7 - runs jbas7 and some includes from commons - eap6 - eap6, jbas7 and some includes from commons - jbas5 - jbas5, commons - eap5 - eap5, jbas5, commons - jbas6 - commons and some excludes - tomcat6 - commons and some excludes Which tests are actually running is defined in maven-failsafe-plugin in integration-tests/CONTAINER/pom.xml. 3) Using of Ant file is removed from eap6 profile. Downloading EAP6 is provided by maven-download-plugin and copying PicketLink libraries is provided by maven-resources-plugin. However it used maven-antrun-plugin for unzip container - it's not satisfying but I didn't find any other way how to unzip something by maven. Due to copying PicketLink libraries there are three new profiles: - copy-picketlink-from-maven - it is activated by default and it copies PicketLink from maven.repo.local - copy-picketlink-from-lib - it copies PicketLink from jboss.as.picketlink.lib.dir and it work only if jboss.as.picketlink.lib.dir is set - skip-copy-picketlink - it doesn't copy anything, original PicketLink from EAP module is used Property picketlink.skip.lib.copy was removed from eap6 profile because it is useless now. 4) Folder dist was added to integration-tests directory - it's only little change, all containers will be located at one place instead of dist folder in every container. You can use your own EAP6 distribution if you copy it to dist folder and running testsuite with property -Deap6-dist-zip=name_of_file_from_dist.zip (and with -Deap6-dir-structure=structure if it isn't use default jboss-eap-6.1) I want to ask you, is anybody have any idea what can be improved in these changes. I'll be happy for every feedback. Thanks, Ondra ----- Original Message ----- _______________________________________________ security-dev mailing list security-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/security-dev