Re: [security-dev] PicketLink IDM JPA Identity Store

Hi guys, which line should I look? From my perspective this line https://github.com/picketlink/picketlink-idm-restored/blob/master/impl/sr... could be refactored to https://github.com/picketlink/picketlink-idm-restored/blob/6e63bc583fa2fa... We're able to implement our own User entity, might be interesting to add getPassword/setPassword methods, in this way this line https://github.com/picketlink/picketlink-idm-restored/blob/master/impl/sr... won't be needed. Just doing would be enough: public class MyCustomUser implements User { …. } myCustomUser.setPassword("…"); //think about the registration process, we don't need DTOs just to pass passwords between entities. im.createUser(myCustomUser); About this line https://github.com/picketlink/picketlink-idm-restored/blob/master/impl/sr... I'll refactor it and send a PR. Currently we don't have groups on AeroGear, so our method is something like: im.grantRole(adminRole, user, null); I'll refactor it to allow users without a group. Wdyt? -- "The measure of a man is what he does with power" - Plato - @abstractj - Volenti Nihil Difficile On Monday, October 8, 2012 at 1:30 PM, Anil Saldhana wrote: > I want to offer continued discussion on the JPA implementation in the > IDM project. > > The work that Pedro did is restored here in the following workspace: > https://github.com/picketlink/picketlink-idm-restored > > A testcase that is useful for JPA implementation in IDM is: > https://github.com/picketlink/picketlink-idm-restored/blob/master/impl/sr... > > It is the exact mirror of the LDAP implementation: > https://github.com/picketlink/picketlink-idm-restored/blob/master/impl/sr... > > These two implementations have very minimal user configuration. > > The challenge is when users bring in complex database schemas and LDAP > DITs into operation. But the goal of balancing complexity with > usability is a tough one. > > On 09/06/2012 10:13 AM, Anil Saldhana wrote: >> Similar challenges exist for LDAP bindings also, since user LDAP DITs >> may be different. But we have to balance complexity with usability. :) >> >> On 09/06/2012 07:37 AM, Pedro Igor Silva wrote: >>> Ok. I'll take a look how he took care of that. >>> >>> Regards. >>> Pedro Igor >>> >>> ----- Original Message ----- >>> From: "Anil Saldhana" <Anil.Saldhana(a)redhat.com >>> <mailto:Anil.Saldhana@redhat.com>> >>> To: security-dev(a)lists.jboss.org <mailto:security-dev@lists.jboss.org> >>> Sent: Wednesday, September 5, 2012 6:52:35 PM >>> Subject: [security-dev] PicketLink IDM JPA Identity Store >>> >>> Pedro, >>> Shane just referred me to the following: >>> >>> https://github.com/seam/security/blob/develop/impl/src/main/java/org/jbos... >>> >>> Can you adapt your work to incorporate all facets of this Seam work? >>> Shane says users have varying db schema structures and the JPA >>> implementation in seam3 took care of the nuances. >>> >>> Regards, >>> Anil