I think you did it right. We should use the IMF for that. We just don't need the test cases you provided. We already have them executed for all stores that support partitions. I think we should also consider a method to obtain all supported partitions. That might be useful if you need to know which of them are already created. I'have started something around that too, but Shane prefers to work on that because of PLINK-130. One question, don't you need to remove partition as well ? ----- Original Message ----- From: "Bill Burke" <bburke(a)redhat.com&gt; To: security-dev(a)lists.jboss.org Sent: Thursday, June 13, 2013 7:17:21 PM Subject: [security-dev] pull request for partition creation - Added partition creation support to File and JPA stores - Added findTier(), findRealm(), createRealm(), createTier() methods to IdentityManagerFactory. - Initialized the DefaultStoreFactory storeCache in the constructor - Changed DefaultStoreFactory hashmaps to ConcurrentHashMaps Won't be slighted if you don't approve the pull request. But it would be cool to at least decide on what the high level interface will be for this. Then I can just implement something in my repository and be unblocked for my other work. Thanks. -- Bill Burke JBoss, a division of Red Hat http://bill.burkecentral.com _______________________________________________ security-dev mailing list security-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/security-dev