From jira-events at lists.jboss.org Mon Nov 8 18:08:01 2010 Content-Type: multipart/mixed; boundary="===============1462831632932998264==" MIME-Version: 1.0 From: Dan Allen (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Created: (SHRINKWRAP-241) remap targets for WebArchive add methods Date: Mon, 08 Nov 2010 18:08:01 -0500 Message-ID: <622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> --===============1462831632932998264== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable remap targets for WebArchive add methods ---------------------------------------- Key: SHRINKWRAP-241 URL: https://jira.jboss.org/browse/SHRINKWRAP-241 Project: ShrinkWrap Issue Type: Feature Request Components: api Affects Versions: 1.0.0-alpha-11 Reporter: Dan Allen Fix For: 1.0.0-alpha-12 The Servlet specification specifically defines static and dynamic served fr= om the web application as "web resources". Hence, the use of "addWebResourc= e" to refer to WEB-INF is a mistake, and reopens the discussion of how each= add* method should be mapped. Currently, the targets for the WebArchive add methods are: add() maps to / addResource() maps to / addWebResource() maps to /WEB-INF addManifestResource() maps to /WEB-INF/classes/META-INF (I know these are being refactor to "addAs". I'm just sticking with the ter= minology that's currently in place for the purpose of this discussion). To start, I think we should explicitly refer to WEB-INF by name, as in: addWebInfResource() maps to /WEB-INF Next, we should honor the "web resource" definition from the Servlet specif= ication addWebResource() maps to / Now, because WebArchive is inheriting addResource() from ResourceArchive, w= e should honor the function of the target location, so: addResource() maps to /WEB-INF/classes Finally, we have to address add() inherited from Archive. In this case, I'm= okay with sticking with add() as meaning the root of whatever archive we h= ave: add() maps to / So, here's what an example might look like: WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") .addWebResource(new StringAsset("Hello World!"= ), "index.html") .addResource(new StringAsset("foo=3Dbar"), "messages.properties); System.out.println(war.toString(true)); prints: app.war /index.html /WEB-INF/beans.xml /WEB-INF/classes/messages.properties To me, this makes so much more sense. Hopefully you share the same opinion. -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1462831632932998264==-- From jira-events at lists.jboss.org Mon Nov 8 18:08:01 2010 Content-Type: multipart/mixed; boundary="===============4329491487318103267==" MIME-Version: 1.0 From: Dan Allen (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Updated: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Mon, 08 Nov 2010 18:08:01 -0500 Message-ID: <451443768.14507.1289257681478.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============4329491487318103267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:all-tabpanel ] Dan Allen updated SHRINKWRAP-241: --------------------------------- Summary: remap targets for WebArchive add* methods (was: remap targets= for WebArchive add methods) > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://jira.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============4329491487318103267==-- From jira-events at lists.jboss.org Mon Nov 8 18:13:01 2010 Content-Type: multipart/mixed; boundary="===============0349215050950646434==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Updated: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Mon, 08 Nov 2010 18:13:01 -0500 Message-ID: <197583822.14514.1289257981556.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0349215050950646434== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:all-tabpanel ] Andrew Rubinger updated SHRINKWRAP-241: --------------------------------------- Priority: Blocker (was: Major) Will block the Beta releases; may be bumped only within Alpha. > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://jira.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0349215050950646434==-- From jira-events at lists.jboss.org Fri Jan 7 22:46:18 2011 Content-Type: multipart/mixed; boundary="===============2058480638304332182==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Assigned: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Fri, 07 Jan 2011 22:46:17 -0500 Message-ID: <1269663846.49061.1294458377965.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2058480638304332182== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Rubinger reassigned SHRINKWRAP-241: ------------------------------------------ Assignee: Andrew Rubinger > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2058480638304332182==-- From jira-events at lists.jboss.org Sat Jan 8 02:41:18 2011 Content-Type: multipart/mixed; boundary="===============0081066370643029011==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Sat, 08 Jan 2011 02:41:17 -0500 Message-ID: <204834298.49097.1294472477958.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0081066370643029011== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125742= 31#comment-12574231 ] = Andrew Rubinger commented on SHRINKWRAP-241: -------------------------------------------- Started up: https://github.com/ALRubinger/shrinkwrap/tree/SHRINKWRAP-241 > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0081066370643029011==-- From jira-events at lists.jboss.org Sun Jan 9 05:23:49 2011 Content-Type: multipart/mixed; boundary="===============2311717113088462928==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Sun, 09 Jan 2011 05:23:49 -0500 Message-ID: <2013284166.283.1294568629710.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2311717113088462928== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125742= 57#comment-12574257 ] = Andrew Rubinger commented on SHRINKWRAP-241: -------------------------------------------- What about "addAsManifestResource"? Does this go away? Is a WebArchive st= ill a ManifestContainer? > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2311717113088462928==-- From jira-events at lists.jboss.org Sun Jan 9 06:40:49 2011 Content-Type: multipart/mixed; boundary="===============2937855808201364293==" MIME-Version: 1.0 From: Aslak Knutsen (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Sun, 09 Jan 2011 06:40:49 -0500 Message-ID: <704867257.296.1294573249623.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2937855808201364293== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125742= 60#comment-12574260 ] = Aslak Knutsen commented on SHRINKWRAP-241: ------------------------------------------ WEB-INF/classes/META-INF i think is valid for persistence.xml > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2937855808201364293==-- From jira-events at lists.jboss.org Sun Jan 9 17:17:49 2011 Content-Type: multipart/mixed; boundary="===============6777035179958481593==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Sun, 09 Jan 2011 17:17:49 -0500 Message-ID: <1714500423.406.1294611469600.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============6777035179958481593== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125742= 73#comment-12574273 ] = Andrew Rubinger commented on SHRINKWRAP-241: -------------------------------------------- OK, so we'll keep WebArchive as a ManifestContainer, with the following map= pings: addAsWebInfResource() - /WEB-INF = addAsWebResource() - / = addAsResource() /WEB-INF/classes addAsManifestResource() - /WEB-INF/classes/META-INF add() - / = > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============6777035179958481593==-- From jira-events at lists.jboss.org Mon Jan 10 04:54:49 2011 Content-Type: multipart/mixed; boundary="===============5871982826573224972==" MIME-Version: 1.0 From: Aslak Knutsen (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Mon, 10 Jan 2011 04:54:49 -0500 Message-ID: <156474517.937.1294653289724.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============5871982826573224972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125743= 07#comment-12574307 ] = Aslak Knutsen commented on SHRINKWRAP-241: ------------------------------------------ looks right > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============5871982826573224972==-- From jira-events at lists.jboss.org Tue Jan 11 10:07:49 2011 Content-Type: multipart/mixed; boundary="===============0007976310326703607==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Tue, 11 Jan 2011 10:07:49 -0500 Message-ID: <708970131.5198.1294758469833.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0007976310326703607== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125746= 76#comment-12574676 ] = Andrew Rubinger commented on SHRINKWRAP-241: -------------------------------------------- Pushed to upstream/master. Aslak and Dan can review this before we resolve. > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0007976310326703607==-- From jira-events at lists.jboss.org Tue Feb 15 12:50:13 2011 Content-Type: multipart/mixed; boundary="===============3163800228240579877==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Resolved: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Tue, 15 Feb 2011 12:50:13 -0500 Message-ID: <599913334.7724.1297792213800.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============3163800228240579877== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Rubinger resolved SHRINKWRAP-241. ---------------------------------------- Resolution: Done With no complaints, resolving. > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --===============3163800228240579877==-- From jira-events at lists.jboss.org Wed Feb 16 12:09:13 2011 Content-Type: multipart/mixed; boundary="===============3122349527738571569==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Reopened: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Wed, 16 Feb 2011 12:09:13 -0500 Message-ID: <86940613.11887.1297876153758.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============3122349527738571569== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Rubinger reopened SHRINKWRAP-241: ---------------------------------------- Reopening. While persistence.xml does go into WEB-INF/classes/META-INF, this does not = infer that the manifest location of a WAR changes. Servlet 3.0 10.6: "Web applications can be packaged and signed into a Web ARchive format (WAR= ) file using the standard Java archive tools. ...When packaged into such a = form, a META-INF directory will be present which contains information usefu= l to Java = archive tools. Servlet 3.0 10.7.1: "The application developer depending on such an extension or extensions mus= t provide a META-INF/MANIFEST.MF entry in the WAR file listing all extensio= ns needed by the WAR." Java EE 6 8.2.1: "A JAR format file (such as a .jar file, .war file, or .rar file) may refer= ence a .jar file or directory by naming the referenced .jar file or directo= ry in a Class-Path header in the referencing JAR file=E2=80=99s Manifest fi= le. The referenced .jar file or directory is named using a URL relative to = the URL of the refer- encing JAR file. The Manifest file is = named META-INF/MANIFEST.MF in the JAR file. The Class-Path entry in the Man= ifest file is of the form" > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --===============3122349527738571569==-- From jira-events at lists.jboss.org Wed Feb 16 15:24:13 2011 Content-Type: multipart/mixed; boundary="===============0773767674078519560==" MIME-Version: 1.0 From: Andrew Rubinger (JIRA) To: shrinkwrap-issues at lists.jboss.org Subject: [shrinkwrap-issues] [JBoss JIRA] Resolved: (SHRINKWRAP-241) remap targets for WebArchive add* methods Date: Wed, 16 Feb 2011 15:24:13 -0500 Message-ID: <183060240.12433.1297887853365.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 622899779.14504.1289257681357.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0773767674078519560== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/SHRINKWRAP-241?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Rubinger resolved SHRINKWRAP-241. ---------------------------------------- Resolution: Done New location mappings: addAsWebInfResource() - /WEB-INF = addAsWebResource() - / = addAsResource() /WEB-INF/classes addAsManifestResource() - /META-INF add() - / > remap targets for WebArchive add* methods > ----------------------------------------- > > Key: SHRINKWRAP-241 > URL: https://issues.jboss.org/browse/SHRINKWRAP-241 > Project: ShrinkWrap > Issue Type: Feature Request > Components: api > Affects Versions: 1.0.0-alpha-11 > Reporter: Dan Allen > Assignee: Andrew Rubinger > Priority: Blocker > Fix For: 1.0.0-alpha-12 > > > The Servlet specification specifically defines static and dynamic served = from the web application as "web resources". Hence, the use of "addWebResou= rce" to refer to WEB-INF is a mistake, and reopens the discussion of how ea= ch add* method should be mapped. > Currently, the targets for the WebArchive add methods are: > add() maps to / > addResource() maps to / > addWebResource() maps to /WEB-INF > addManifestResource() maps to /WEB-INF/classes/META-INF > (I know these are being refactor to "addAs". I'm just sticking with the t= erminology that's currently in place for the purpose of this discussion). > To start, I think we should explicitly refer to WEB-INF by name, as in: > addWebInfResource() maps to /WEB-INF > Next, we should honor the "web resource" definition from the Servlet spec= ification > addWebResource() maps to / > Now, because WebArchive is inheriting addResource() from ResourceArchive,= we should honor the function of the target location, so: > addResource() maps to /WEB-INF/classes > Finally, we have to address add() inherited from Archive. In this case, I= 'm okay with sticking with add() as meaning the root of whatever archive we= have: > add() maps to / > So, here's what an example might look like: > WebArchive war =3D ShrinkWrap.create(WebArchive.class, "app.war") > .addWebInfResource(EmptyAsset.INSTANCE, "beans.xml") > .addWebResource(new StringAsset("Hello World!"), "index.html") > .addResource(new StringAsset("foo=3Dbar"), "messages.properties); > System.out.println(war.toString(true)); > prints: > app.war > /index.html > /WEB-INF/beans.xml > /WEB-INF/classes/messages.properties > To me, this makes so much more sense. Hopefully you share the same opinio= n. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --===============0773767674078519560==--