I frequently see NPEs in the properties code related to this, usually as a result of the associated editing domain being null. I'm guessing this is because the "active" editor is not being updated and we're getting an editor that has been closed.

Regardless, for EditingDomain we should use AdapterFactoryEditingDomain.getEdtitingDomainFor(object). For the editor, we should at least use the SwitchYardSCAEditor.getEditor(object), as this will provide the actual editor associated with the object. This should improve things all around.