[teiid-designer-dev] [Teiid-Designer/teiid-designer] b4d1de: TEIIDDES-1701: Tighten up the checks on resources ...
Branch: refs/heads/master
Home: https://github.com/Teiid-Designer/teiid-designer
Commit: b4d1decccd9aae48c3333fb5a317797074024d62
https://github.com/Teiid-Designer/teiid-designer/commit/b4d1decccd9aae48c...
Author: Paul Richardson <p.g.richardson(a)redhat.com>
Date: 2013-05-07 (Tue, 07 May 2013)
Changed paths:
M
plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/RelatedResourceFinder.java
M
plugins/org.teiid.designer.ui.common/src/org/teiid/designer/ui/common/util/UiUtil.java
M plugins/org.teiid.designer.ui/META-INF/MANIFEST.MF
M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/i18n.properties
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/AbstractResourcesRefactoring.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/RefactorResourcesUtils.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/delete/DeleteResourceActionDelegate.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/delete/DeleteResourcesDescriptor.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/delete/DeleteResourcesRefactoring.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/delete/DeleteResourcesWizard.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/move/MoveRefactorAction.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/move/MoveResourcesRefactoring.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/rename/RenameRefactorAction.java
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/rename/RenameResourceRefactoring.java
M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbModelEntry.java
Log Message:
-----------
TEIIDDES-1701: Tighten up the checks on resources before refactoring
* The error-checking on resources and their dependents prior to their
refactoring is inconsistent and error-prone.
* UiUtil
* Check all workbench window and pages for any editors using the given
file
* AbstractResourcesRefactoring
* Removes workbench window field as unnecessary
* Migrates all check methods to RefactorResourceUtils
* Introduces abstract checkResource method that should implement all
checks required on a given resource for the specific refactoring use-case
* Removes the closeDirtyEditors method due to modification the saving
function creates separate runnables in their own threads leading to
problems with synchronisation. Instead, if their are open editors or
dirty resources, the refactoring bails with a message to the user
* RefactorResourcesUtils
* Renames the resource callback interface to IResourceCallback and removes
its mergeStatus method since it should not hold a status object of its
own
* Provides abstract implementation of IResourceCallback
* Introduces check for open editors
* VdbModelEntry
* Avoid NPE by checking if we have derived a model resource
Commit: eabee813533f3e79daeb1719d22d0ef3c7ae1659
https://github.com/Teiid-Designer/teiid-designer/commit/eabee813533f3e79d...
Author: Paul Richardson <p.g.richardson(a)redhat.com>
Date: 2013-05-07 (Tue, 07 May 2013)
Changed paths:
M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/i18n.properties
M
plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/delete/DeleteResourcesWizard.java
Log Message:
-----------
TEIIDDES-1703: Make it obvious what the delete action will cover
* Places a tree viewer on the 'Are you sure?' dialog box displaying all the
resources and dependencies that will be deleted by the delete refactoring
* Makes it plain to the user that these resources will be deleted if they
click ok but can deselect them if they click preview.
Compare:
https://github.com/Teiid-Designer/teiid-designer/compare/5dea099ed2b7...e...