Branch: refs/heads/master Home: https://github.com/Teiid-Designer/teiid-designer Commit: 58cc54b682de67aeef2d52d9d9e99f2699ca4613 https://github.com/Teiid-Designer/teiid-designer/commit/58cc54b682de67aee... Author: Paul Richardson <p.g.richardson(a)redhat.com&gt; Date: 2013-05-30 (Thu, 30 May 2013) Changed paths: M plugins/org.teiid.designer.relational.ui/META-INF/MANIFEST.MF A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description-error.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description-warning.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql-error.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql-warning.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql.png M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/Messages.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/UiConstants.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalIndexAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalProcedureAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalTableAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalViewAction.java R plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/EditRelationalObjectDialog.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalDialogModel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalEditorPanel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalIndexEditorPanel.java R plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalObjectEditorFactory.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalProcedureEditorPanel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalTableEditorPanel.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/editor/EditRelationalObjectDialog.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/editor/EditRelationalObjectDialogModel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/messages.properties M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/util/RelationalUiUtil.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/Messages.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewIndexAction.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewProcedureAction.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewTableAction.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditRelationalObjectDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditViewProcedureDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditViewTableDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/RelationalObjectEditorFactory.java A plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/TransformationDialogModel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewProcedureEditorPanel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewTableEditorPanel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/messages.properties Log Message: ----------- TEIIDDES-1663: Refactor the relational and transformation dialogs * The child actions for relational and view diagrams create dialogs from classes that duplicate the same functionality. This refactors the classes so that only one class displays the dialog and its factories are replaced with diagram models that provide the small differences in functionality. * [*]Action * The dialog requires a dialog model which encapsulates both the relational object and selected file * Dialog updates * Icons for description and sql tabs * Help text is moved from the main panel to the message area of the dialog * [*]Panel * Extends the use of the abstract parent class to reduce code duplication * The dialog model is passed in as the container for the reference and model file * Replacement of GridData and GridLayout instances with the use of GridDataFactory and GridLayoutFactory * Removes all use of hint heights to address the specific sizing issue. Neither the tab folder nor the name text components have priority over the sizing. * Removes spacers to reduce real-estate requirements of dialogs Commit: a3c8a4c3e51d8c1d68a9e1bd753576f0db230cfa https://github.com/Teiid-Designer/teiid-designer/commit/a3c8a4c3e51d8c1d6... Author: Barry LaFond <blafond(a)redhat.com&gt; Date: 2013-05-30 (Thu, 30 May 2013) Changed paths: M plugins/org.teiid.designer.relational.ui/META-INF/MANIFEST.MF A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description-error.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description-warning.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/edit-description.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql-error.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql-warning.png A plugins/org.teiid.designer.relational.ui/icons/full/obj16/native-sql.png M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/Messages.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/UiConstants.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalIndexAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalProcedureAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalTableAction.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/actions/CreateRelationalViewAction.java R plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/EditRelationalObjectDialog.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalDialogModel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalEditorPanel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalIndexEditorPanel.java R plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalObjectEditorFactory.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalProcedureEditorPanel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/edit/RelationalTableEditorPanel.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/editor/EditRelationalObjectDialog.java A plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/editor/EditRelationalObjectDialogModel.java M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/messages.properties M plugins/org.teiid.designer.relational.ui/src/org/teiid/designer/relational/ui/util/RelationalUiUtil.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/Messages.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewIndexAction.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewProcedureAction.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/actions/CreateViewTableAction.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditRelationalObjectDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditViewProcedureDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/EditViewTableDialog.java R plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/RelationalObjectEditorFactory.java A plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/TransformationDialogModel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewProcedureEditorPanel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/editors/ViewTableEditorPanel.java M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/messages.properties Log Message: ----------- Merge pull request #169 from phantomjinx/master Relational and View Diagram dialog refactoring Compare: https://github.com/Teiid-Designer/teiid-designer/compare/4d2f702aec56...a...