[JBoss JIRA] (TEIIDDES-2477) Nullpointer in WSConnectionInfoProvider.java when user is null
by Andrej Šmigala (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2477?page=com.atlassian.jira.plu... ]
Andrej Šmigala closed TEIIDDES-2477.
------------------------------------
Labels: verified_jbdsis-8.0.2.CR3 (was: )
Resolution: Done
> Nullpointer in WSConnectionInfoProvider.java when user is null
> --------------------------------------------------------------
>
> Key: TEIIDDES-2477
> URL: https://issues.jboss.org/browse/TEIIDDES-2477
> Project: Teiid Designer
> Issue Type: Bug
> Components: Data Preview
> Affects Versions: 8.6, 9.0
> Environment: Windows 7, JBoss Developer Studio 8.1.0, Teiid Designer 9.0.1.Final
> Reporter: Daan Creemers
> Assignee: Ted Jones
> Labels: verified_jbdsis-8.0.2.CR3
> Fix For: 9.1, 8.6.2 Beta1, 9.0.2, 8.6.2
>
>
> In the file https://github.com/Teiid-Designer/teiid-designer/blob/9.0.x/plugins/org.t...
> @line 101:
> if (null != user &! user.equals("")) { //$NON-NLS-1$
> connectionProps.setProperty(ICredentialsCommon.USERNAME_PROP_ID, user);
> }
> It is not correctly captured that user can be null. No short-circuit operator is used and therefore, the right-hand side of the expression is evaluated which gives a NullPointer if user is null.
> Line 101 contains ampersand exclamation mark without a space in between such that short-circuit is not working. ( if (null != user &! user.equals("")) { )
> This should be ( if (null != user && !user.equals("")) { )
> After importing a REST Web Service to create a Source and View model, previewing the data generates the following NullPointer.
> java.lang.NullPointerException
> at org.teiid.designer.datatools.profiles.ws.WSConnectionInfoProvider.getTeiidRelatedProperties(WSConnectionInfoProvider.java:101)
> at org.teiid.designer.runtime.TeiidDataSourceFactory.createDataSource(TeiidDataSourceFactory.java:127)
> at org.teiid.designer.runtime.preview.PreviewManager.ensureConnectionInfoIsValid(PreviewManager.java:527)
> at org.teiid.designer.runtime.preview.PreviewManager.previewSetup(PreviewManager.java:1365)
> at org.teiid.designer.runtime.ui.preview.PreviewDataWorker$1.run(PreviewDataWorker.java:233)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 5 months
[JBoss JIRA] (TEIIDDES-2477) Nullpointer in WSConnectionInfoProvider.java when user is null
by Andrej Šmigala (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2477?page=com.atlassian.jira.plu... ]
Andrej Šmigala reopened TEIIDDES-2477:
--------------------------------------
Reopening to set label
> Nullpointer in WSConnectionInfoProvider.java when user is null
> --------------------------------------------------------------
>
> Key: TEIIDDES-2477
> URL: https://issues.jboss.org/browse/TEIIDDES-2477
> Project: Teiid Designer
> Issue Type: Bug
> Components: Data Preview
> Affects Versions: 8.6, 9.0
> Environment: Windows 7, JBoss Developer Studio 8.1.0, Teiid Designer 9.0.1.Final
> Reporter: Daan Creemers
> Assignee: Ted Jones
> Labels: verified_jbdsis-8.0.2.CR3
> Fix For: 9.1, 8.6.2 Beta1, 9.0.2, 8.6.2
>
>
> In the file https://github.com/Teiid-Designer/teiid-designer/blob/9.0.x/plugins/org.t...
> @line 101:
> if (null != user &! user.equals("")) { //$NON-NLS-1$
> connectionProps.setProperty(ICredentialsCommon.USERNAME_PROP_ID, user);
> }
> It is not correctly captured that user can be null. No short-circuit operator is used and therefore, the right-hand side of the expression is evaluated which gives a NullPointer if user is null.
> Line 101 contains ampersand exclamation mark without a space in between such that short-circuit is not working. ( if (null != user &! user.equals("")) { )
> This should be ( if (null != user && !user.equals("")) { )
> After importing a REST Web Service to create a Source and View model, previewing the data generates the following NullPointer.
> java.lang.NullPointerException
> at org.teiid.designer.datatools.profiles.ws.WSConnectionInfoProvider.getTeiidRelatedProperties(WSConnectionInfoProvider.java:101)
> at org.teiid.designer.runtime.TeiidDataSourceFactory.createDataSource(TeiidDataSourceFactory.java:127)
> at org.teiid.designer.runtime.preview.PreviewManager.ensureConnectionInfoIsValid(PreviewManager.java:527)
> at org.teiid.designer.runtime.preview.PreviewManager.previewSetup(PreviewManager.java:1365)
> at org.teiid.designer.runtime.ui.preview.PreviewDataWorker$1.run(PreviewDataWorker.java:233)
> at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 5 months
[JBoss JIRA] (TEIIDDES-2482) Enable DDL Importer to import Teiid DDL CREATE VIEW statements to capture and set SQL expression in view model
by Andrej Šmigala (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2482?page=com.atlassian.jira.plu... ]
Andrej Šmigala closed TEIIDDES-2482.
------------------------------------
Labels: verified_jbdsis-8.0.2.CR3 (was: )
Resolution: Done
> Enable DDL Importer to import Teiid DDL CREATE VIEW statements to capture and set SQL expression in view model
> --------------------------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2482
> URL: https://issues.jboss.org/browse/TEIIDDES-2482
> Project: Teiid Designer
> Issue Type: Enhancement
> Components: Import/Export, Transformations
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Labels: verified_jbdsis-8.0.2.CR3
> Fix For: 9.1, 9.0.2
>
> Attachments: view_example.ddl
>
>
> Teiid DDL supports CREATE VIEW & CREATE PROCEDURE statements that contain SQL expression. The current DDL Importer does not recognize the SQL expression and will not set that value on a table or procedure when importing to a View model.
> Make the changes necessary to discover the SQL expression and apply to a virtual table/procedure if importing to a View model.
> To Test:
> * Select Designer's simple DDL Importer wizard
> * Make sure *Teiid* dialect is selected
> * Make sure *View* model option is selected
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 5 months
[JBoss JIRA] (TEIIDDES-2482) Enable DDL Importer to import Teiid DDL CREATE VIEW statements to capture and set SQL expression in view model
by Andrej Šmigala (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2482?page=com.atlassian.jira.plu... ]
Andrej Šmigala reopened TEIIDDES-2482:
--------------------------------------
Reopening to set label
> Enable DDL Importer to import Teiid DDL CREATE VIEW statements to capture and set SQL expression in view model
> --------------------------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2482
> URL: https://issues.jboss.org/browse/TEIIDDES-2482
> Project: Teiid Designer
> Issue Type: Enhancement
> Components: Import/Export, Transformations
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.1, 9.0.2
>
> Attachments: view_example.ddl
>
>
> Teiid DDL supports CREATE VIEW & CREATE PROCEDURE statements that contain SQL expression. The current DDL Importer does not recognize the SQL expression and will not set that value on a table or procedure when importing to a View model.
> Make the changes necessary to discover the SQL expression and apply to a virtual table/procedure if importing to a View model.
> To Test:
> * Select Designer's simple DDL Importer wizard
> * Make sure *Teiid* dialect is selected
> * Make sure *View* model option is selected
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
10 years, 5 months