[JBoss JIRA] (TEIIDDES-2612) Cannot delete a model project with a read-only model in it.
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2612?page=com.atlassian.jira.plu... ]
Barry LaFond resolved TEIIDDES-2612.
------------------------------------
Resolution: Done
> Cannot delete a model project with a read-only model in it.
> -----------------------------------------------------------
>
> Key: TEIIDDES-2612
> URL: https://issues.jboss.org/browse/TEIIDDES-2612
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 9.0, 9.1
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch, AbstractRefactorAction.patch, DeleteResourceRefactoring.patch, ModelExplorerResourceNavigator.patch
>
>
> I set up a 2 projects with a single model in it. Project 1 has a read-only -model, Project 2 has a writeable model.
> I can delete Project 2, but Project 1 sends up a error message dialog that it can't delete because the project has a read-only file in it.
> Looking at DeleteResourcesRefactoring.checkResource(), it starts with checking if the resource is in the selected list. If not selected, it'll be an ERROR if a child resources is READ-ONLY, rather than a WARNING.
> Further down the method it checks for read-only state of the resource and will set the message.
> Problem is the Selected/Top-level Project should determine the severity of the read-only check. At most, the message should be an OK/Warning dialog to ask the user "Read-only resources found... do you still wish to delete?"
> adding a method to check that *allProjectsSelected()* and switching the ERROR read-only status to WARNING at the start of the method seems to work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2612) Cannot delete a model project with a read-only model in it.
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2612?page=com.atlassian.jira.plu... ]
Barry LaFond updated TEIIDDES-2612:
-----------------------------------
Fix Version/s: 9.2
> Cannot delete a model project with a read-only model in it.
> -----------------------------------------------------------
>
> Key: TEIIDDES-2612
> URL: https://issues.jboss.org/browse/TEIIDDES-2612
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 9.0, 9.1
> Reporter: Barry LaFond
> Fix For: 9.2
>
> Attachments: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch, AbstractRefactorAction.patch, DeleteResourceRefactoring.patch, ModelExplorerResourceNavigator.patch
>
>
> I set up a 2 projects with a single model in it. Project 1 has a read-only -model, Project 2 has a writeable model.
> I can delete Project 2, but Project 1 sends up a error message dialog that it can't delete because the project has a read-only file in it.
> Looking at DeleteResourcesRefactoring.checkResource(), it starts with checking if the resource is in the selected list. If not selected, it'll be an ERROR if a child resources is READ-ONLY, rather than a WARNING.
> Further down the method it checks for read-only state of the resource and will set the message.
> Problem is the Selected/Top-level Project should determine the severity of the read-only check. At most, the message should be an OK/Warning dialog to ask the user "Read-only resources found... do you still wish to delete?"
> adding a method to check that *allProjectsSelected()* and switching the ERROR read-only status to WARNING at the start of the method seems to work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2612) Cannot delete a model project with a read-only model in it.
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2612?page=com.atlassian.jira.plu... ]
Barry LaFond reassigned TEIIDDES-2612:
--------------------------------------
Assignee: Barry LaFond
> Cannot delete a model project with a read-only model in it.
> -----------------------------------------------------------
>
> Key: TEIIDDES-2612
> URL: https://issues.jboss.org/browse/TEIIDDES-2612
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 9.0, 9.1
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch, AbstractRefactorAction.patch, DeleteResourceRefactoring.patch, ModelExplorerResourceNavigator.patch
>
>
> I set up a 2 projects with a single model in it. Project 1 has a read-only -model, Project 2 has a writeable model.
> I can delete Project 2, but Project 1 sends up a error message dialog that it can't delete because the project has a read-only file in it.
> Looking at DeleteResourcesRefactoring.checkResource(), it starts with checking if the resource is in the selected list. If not selected, it'll be an ERROR if a child resources is READ-ONLY, rather than a WARNING.
> Further down the method it checks for read-only state of the resource and will set the message.
> Problem is the Selected/Top-level Project should determine the severity of the read-only check. At most, the message should be an OK/Warning dialog to ask the user "Read-only resources found... do you still wish to delete?"
> adding a method to check that *allProjectsSelected()* and switching the ERROR read-only status to WARNING at the start of the method seems to work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2612) Cannot delete a model project with a read-only model in it.
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2612?page=com.atlassian.jira.plu... ]
Barry LaFond commented on TEIIDDES-2612:
----------------------------------------
master: https://github.com/Teiid-Designer/teiid-designer/commit/c648e538cd953db18...
> Cannot delete a model project with a read-only model in it.
> -----------------------------------------------------------
>
> Key: TEIIDDES-2612
> URL: https://issues.jboss.org/browse/TEIIDDES-2612
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 9.0, 9.1
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch, AbstractRefactorAction.patch, DeleteResourceRefactoring.patch, ModelExplorerResourceNavigator.patch
>
>
> I set up a 2 projects with a single model in it. Project 1 has a read-only -model, Project 2 has a writeable model.
> I can delete Project 2, but Project 1 sends up a error message dialog that it can't delete because the project has a read-only file in it.
> Looking at DeleteResourcesRefactoring.checkResource(), it starts with checking if the resource is in the selected list. If not selected, it'll be an ERROR if a child resources is READ-ONLY, rather than a WARNING.
> Further down the method it checks for read-only state of the resource and will set the message.
> Problem is the Selected/Top-level Project should determine the severity of the read-only check. At most, the message should be an OK/Warning dialog to ask the user "Read-only resources found... do you still wish to delete?"
> adding a method to check that *allProjectsSelected()* and switching the ERROR read-only status to WARNING at the start of the method seems to work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2614) Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2614?page=com.atlassian.jira.plu... ]
Barry LaFond resolved TEIIDDES-2614.
------------------------------------
Resolution: Done
> Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
> -------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2614
> URL: https://issues.jboss.org/browse/TEIIDDES-2614
> Project: Teiid Designer
> Issue Type: Enhancement
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: TeiidDdlImporter.patch
>
>
> Teiid Connection importer will return all PK/UC definitions exposed by the DB. Some DB's auto-create a unique constraint for an defined PK, which is really redundant.
> Teiid Designer has a validation check that looks for PK/UC who share common column ID's and generates an error. This prevents a lot of DDL to end up being imported with errors.
> Suggest looking for this use-case in the Teiid DDL Importer logic and removing the redundant UC prior to generating the XMI model
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2614) Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2614?page=com.atlassian.jira.plu... ]
Barry LaFond updated TEIIDDES-2614:
-----------------------------------
Fix Version/s: 9.2
> Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
> -------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2614
> URL: https://issues.jboss.org/browse/TEIIDDES-2614
> Project: Teiid Designer
> Issue Type: Enhancement
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: TeiidDdlImporter.patch
>
>
> Teiid Connection importer will return all PK/UC definitions exposed by the DB. Some DB's auto-create a unique constraint for an defined PK, which is really redundant.
> Teiid Designer has a validation check that looks for PK/UC who share common column ID's and generates an error. This prevents a lot of DDL to end up being imported with errors.
> Suggest looking for this use-case in the Teiid DDL Importer logic and removing the redundant UC prior to generating the XMI model
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2614) Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2614?page=com.atlassian.jira.plu... ]
Barry LaFond reassigned TEIIDDES-2614:
--------------------------------------
Assignee: Barry LaFond
> Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
> -------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2614
> URL: https://issues.jboss.org/browse/TEIIDDES-2614
> Project: Teiid Designer
> Issue Type: Enhancement
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 9.2
>
> Attachments: TeiidDdlImporter.patch
>
>
> Teiid Connection importer will return all PK/UC definitions exposed by the DB. Some DB's auto-create a unique constraint for an defined PK, which is really redundant.
> Teiid Designer has a validation check that looks for PK/UC who share common column ID's and generates an error. This prevents a lot of DDL to end up being imported with errors.
> Suggest looking for this use-case in the Teiid DDL Importer logic and removing the redundant UC prior to generating the XMI model
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2612) Cannot delete a model project with a read-only model in it.
by Paul Richardson (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2612?page=com.atlassian.jira.plu... ]
Paul Richardson updated TEIIDDES-2612:
--------------------------------------
Attachment: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch
Patch attached that checks whether read-only resource is a child of the selected resources. If so then set the read-only message to a be a warning rather than an error.
> Cannot delete a model project with a read-only model in it.
> -----------------------------------------------------------
>
> Key: TEIIDDES-2612
> URL: https://issues.jboss.org/browse/TEIIDDES-2612
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 9.0, 9.1
> Reporter: Barry LaFond
> Attachments: 0001-TEIIDES-2612-Refactor-deleting-response-to-related-r.patch, AbstractRefactorAction.patch, DeleteResourceRefactoring.patch, ModelExplorerResourceNavigator.patch
>
>
> I set up a 2 projects with a single model in it. Project 1 has a read-only -model, Project 2 has a writeable model.
> I can delete Project 2, but Project 1 sends up a error message dialog that it can't delete because the project has a read-only file in it.
> Looking at DeleteResourcesRefactoring.checkResource(), it starts with checking if the resource is in the selected list. If not selected, it'll be an ERROR if a child resources is READ-ONLY, rather than a WARNING.
> Further down the method it checks for read-only state of the resource and will set the message.
> Problem is the Selected/Top-level Project should determine the severity of the read-only check. At most, the message should be an OK/Warning dialog to ask the user "Read-only resources found... do you still wish to delete?"
> adding a method to check that *allProjectsSelected()* and switching the ERROR read-only status to WARNING at the start of the method seems to work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (TEIIDDES-2614) Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2614?page=com.atlassian.jira.plu... ]
Barry LaFond updated TEIIDDES-2614:
-----------------------------------
Attachment: TeiidDdlImporter.patch
Basically added a filter prior to creating EMF objects to look for UC's if a PK exists and check if the column ID's exactly match, then remove.
> Add option to remove redundant Unique Constraint in DDL importing if column ID's match a PK
> -------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2614
> URL: https://issues.jboss.org/browse/TEIIDDES-2614
> Project: Teiid Designer
> Issue Type: Enhancement
> Reporter: Barry LaFond
> Attachments: TeiidDdlImporter.patch
>
>
> Teiid Connection importer will return all PK/UC definitions exposed by the DB. Some DB's auto-create a unique constraint for an defined PK, which is really redundant.
> Teiid Designer has a validation check that looks for PK/UC who share common column ID's and generates an error. This prevents a lot of DDL to end up being imported with errors.
> Suggest looking for this use-case in the Teiid DDL Importer logic and removing the redundant UC prior to generating the XMI model
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months