[ https://issues.jboss.org/browse/TEIIDDES-1098?page=com.atlassian.jira.plu... ] Barry LaFond updated TEIIDDES-1098: ----------------------------------- Fix Version/s: 7.6 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1098?page=com.atlassian.jira.plu... ] Barry LaFond updated TEIIDDES-1098: ----------------------------------- Summary: Name refactoring issues for parameters and columns (was: Procedure parameter name refactoring issues) Description: I encountered a couple of issues when refactoring a procedure parameter name. 1. The procedure transformation sql is not updated with the new name. For example given a procedure with a parameter param and a definition that just returns that value: CREATE VIRTUAL PROCEDURE BEGIN SELECT param AS foo; END refactoring to param1 leaves the select as "select param as foo" rather than updating to select param1 as foo. Note that if this is implemented, then aliases may need to be added to, e.g. "select param" would become "select param1 as param". There is existing logic in the Teiid ExpressionMappingVisitor to handle that. 2. If you undo the refactoring of the name, then even after a save and rebuild the model is still marked with an error. I had to edit the already valid SQL to clear the error. Also tested with renaming a simple relational column with the same results/issues was: I encountered a couple of issues when refactoring a procedure parameter name. 1. The procedure transformation sql is not updated with the new name. For example given a procedure with a parameter param and a definition that just returns that value: CREATE VIRTUAL PROCEDURE BEGIN SELECT param AS foo; END refactoring to param1 leaves the select as "select param as foo" rather than updating to select param1 as foo. Note that if this is implemented, then aliases may need to be added to, e.g. "select param" would become "select param1 as param". There is existing logic in the Teiid ExpressionMappingVisitor to handle that. 2. If you undo the refactoring of the name, then even after a save and rebuild the model is still marked with an error. I had to edit the already valid SQL to clear the error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1098?page=com.atlassian.jira.plu... ] Barry LaFond updated TEIIDDES-1098: ----------------------------------- Fix Version/s: Future (was: 7.7) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira