[JBoss JIRA] (TEIIDDES-2396) Renaming a source model does not fullly update import statements to view models
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2396?page=com.atlassian.jira.plu... ]
Barry LaFond reassigned TEIIDDES-2396:
--------------------------------------
Assignee: Barry LaFond (was: Paul Richardson)
> Renaming a source model does not fullly update import statements to view models
> -------------------------------------------------------------------------------
>
> Key: TEIIDDES-2396
> URL: https://issues.jboss.org/browse/TEIIDDES-2396
> Project: Teiid Designer
> Issue Type: Bug
> Components: Modeling
> Affects Versions: 8.6
> Reporter: Barry LaFond
> Assignee: Barry LaFond
> Fix For: 8.6.1, 9.0.1, 9.0
>
>
> # Create Source model with table (SourceModel and ViewModel)
> # Create View model from source model (create transform option)
> # Save all and close editors
> # Select source model and Refactor > Rename... the it to "SourceModel_XXX"
> On Linux, the refactoring will be successful EXCEPT for the <modelImports> element holding the reference to the SourceModel. The "name" attribute is *NOT* getting updated, even though the *modelLocation* is changed correctly. Note that the *name* attribute is basically the model name *without* the *.xmi* extension.
> I it appears we're missing a little step that replaces the model name *without* file extension with the new model name.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2376) On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2376?page=com.atlassian.jira.plu... ]
Barry LaFond commented on TEIIDDES-2376:
----------------------------------------
There is an Eclipse Platform class that can check for OS type
So adding the following in RefactorResourcesUtils methods that are keeping track of *docOffset* values would need to :
if( Platform.getOS().equalsIgnoreCase(Platform.WS_WIN32) ) {
docOffset++
}
I've tested on Windows and it fixes this issue.
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2376
> URL: https://issues.jboss.org/browse/TEIIDDES-2376
> Project: Teiid Designer
> Issue Type: Bug
> Components: Eclipse Integration
> Affects Versions: 8.3.4
> Environment: - JBDS 7.1.1
> - JBDSIS 7.0.3
> - Windows 7
> Reporter: hisao furuichi
> Assignee: Barry LaFond
> Fix For: 8.6.1, 9.0.1, 9.0
>
>
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2376) On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2376?page=com.atlassian.jira.plu... ]
Barry LaFond commented on TEIIDDES-2376:
----------------------------------------
I think it's an issue with the BufferReader.readLine(). On Windows, the line feed chars incude both "\r" and "\n", but Linux only "\". When calculating the XMLDocument's "doc regions, the cached regions (lines) INCLUDE both characters, so when the document region get's edited, the document OFFSET is different. Basically it's off by #chars == #lines to that region/line.
The *RefactorResourcesUtils.calculateTextChanges()* and probably *calculateSQLChanges()* methods are assuming that there is only ONE carriage return char with each line when calculating the OFFSET value. Not sure what do do here because it's OS dependent?
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2376
> URL: https://issues.jboss.org/browse/TEIIDDES-2376
> Project: Teiid Designer
> Issue Type: Bug
> Components: Eclipse Integration
> Affects Versions: 8.3.4
> Environment: - JBDS 7.1.1
> - JBDSIS 7.0.3
> - Windows 7
> Reporter: hisao furuichi
> Assignee: Barry LaFond
> Fix For: 8.6.1, 9.0.1, 9.0
>
>
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2398) Inconsistent column datatypes when importing
by Andrej Šmigala (JIRA)
Andrej Šmigala created TEIIDDES-2398:
----------------------------------------
Summary: Inconsistent column datatypes when importing
Key: TEIIDDES-2398
URL: https://issues.jboss.org/browse/TEIIDDES-2398
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Reporter: Andrej Šmigala
There are multiple discrepancies in the column datatypes when importing using JDBC importer vs when using Teiid Connection importer.
Also some of the imported datatypes seem completely wrong (e.g. bigdecimal for almost all numeric datatypes in oracle)
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2299) LDAP import dialog very slow
by Andrej Šmigala (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2299?page=com.atlassian.jira.plu... ]
Andrej Šmigala commented on TEIIDDES-2299:
------------------------------------------
It appears that any interaction with the dialog causes communication with the LDAP server.
> LDAP import dialog very slow
> ----------------------------
>
> Key: TEIIDDES-2299
> URL: https://issues.jboss.org/browse/TEIIDDES-2299
> Project: Teiid Designer
> Issue Type: Bug
> Components: Dialogs
> Affects Versions: 8.3.3
> Environment: JBDS 7.1.1
> Windows, Linux
> Reporter: Andrej Šmigala
> Assignee: Barry LaFond
>
> In the LDAP import dialog in steps "Select the LDAP entries to be modelled as tables" and "Select the LDAP attributes to be modelled as table columns", checkboxes only change their state about one second after they are clicked.
> Also, typing anything into e. g. Column Name input takes several seconds.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2396) Renaming a source model does not fullly update import statements to view models
by Barry LaFond (JIRA)
Barry LaFond created TEIIDDES-2396:
--------------------------------------
Summary: Renaming a source model does not fullly update import statements to view models
Key: TEIIDDES-2396
URL: https://issues.jboss.org/browse/TEIIDDES-2396
Project: Teiid Designer
Issue Type: Bug
Components: Modeling
Affects Versions: 8.6
Reporter: Barry LaFond
Assignee: Paul Richardson
Fix For: 8.6.1, 9.0.1, 9.0
# Create Source model with table (SourceModel and ViewModel)
# Create View model from source model (create transform option)
# Save all and close editors
# Select source model and Refactor > Rename... the it to "SourceModel_XXX"
On Linux, the refactoring will be successful EXCEPT for the <modelImports> element holding the reference to the SourceModel. The "name" attribute is *NOT* getting updated, even though the *modelLocation* is changed correctly. Note that the *name* attribute is basically the model name *without* the *.xmi* extension.
I it appears we're missing a little step that replaces the model name *without* file extension with the new model name.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months
[JBoss JIRA] (TEIIDDES-2376) On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
by Barry LaFond (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2376?page=com.atlassian.jira.plu... ]
Barry LaFond edited comment on TEIIDDES-2376 at 11/19/14 12:15 PM:
-------------------------------------------------------------------
When I renamed the *SourceModel_AAAAA.xmi* to *SourceModel_XXXXX* it appears that the modelImport *name* attribute isn't updated as shown below.
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocation="SourceModel_XXXXX.xmi"
On Windows the rename will incorrectly change the
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocation="SourceModel_AAAAA.xmi"
to
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocatiSourceModel_XXXXX.xmi.xmi"
So it's OFF by *4* characters
There's an <annotatedObject> href that's hosed too:
<annotatedObject href="SourceModel_AAAAA.xmi#mmuuid/7291fb4c-da39-4bbc-9787-d2edd9b9551c"/>
becomes
SourceModel_XXXXX.xmif="SourceModel_AAAAA.xmi#mmuuid/7291fb4c-da39-4bbc-9787-d2edd9b9551c"/>
I tracked the character offsets in the *RefactorResourcesUtils.calculateTextChanges()* method and for the modelImport line above, the offsets are the same on Windows AND Linux
was (Author: blafond):
When I renamed the *SourceModel_AAAAA.xmi* to *SourceModel_XXXXX* it appears that the modelImport *name* attribute isn't updated as shown below.
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocation="SourceModel_XXXXX.xmi"
On Windows the rename will incorrectly changed the
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocation="SourceModel_AAAAA.xmi"
to
<modelImports xmi:uuid="mmuuid:cb26ab75-2877-4cee-8efa-5de4732d18f7" name="SourceModel_AAAAA" modelLocatiSourceModel_XXXXX.xmi.xmi"
So it's OFF by *4* characters
There's an <annotatedObject> href that's hosed too:
<annotatedObject href="SourceModel_AAAAA.xmi#mmuuid/7291fb4c-da39-4bbc-9787-d2edd9b9551c"/>
becomes
SourceModel_XXXXX.xmif="SourceModel_AAAAA.xmi#mmuuid/7291fb4c-da39-4bbc-9787-d2edd9b9551c"/>
I tracked the character offsets in the *RefactorResourcesUtils.calculateTextChanges()* method and for the modelImport line above, the offsets are the same on Windows AND Linux
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: TEIIDDES-2376
> URL: https://issues.jboss.org/browse/TEIIDDES-2376
> Project: Teiid Designer
> Issue Type: Bug
> Components: Eclipse Integration
> Affects Versions: 8.3.4
> Environment: - JBDS 7.1.1
> - JBDSIS 7.0.3
> - Windows 7
> Reporter: hisao furuichi
> Assignee: Barry LaFond
> Fix For: 8.6.1, 9.0.1, 9.0
>
>
> On windows environment, renamig a source model file's name using JBDS will broke a view model which uses the renamed source model
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
11 years, 5 months