[JBoss JIRA] (TEIIDDES-2665) Add an option to not widen comparisons to string
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2665?page=com.atlassian.jira.plu... ]
Van Halbert edited comment on TEIIDDES-2665 at 9/13/16 4:15 PM:
----------------------------------------------------------------
Based on Teiid's comments, the UI only needs to add an option that will set the system property org.teiid.widenComparisonToString to true. The resolving logic could check if that property is set to report differently.
was (Author: van.halbert):
Based on Teiid's comments, the UI only needs to add an option that will set the system property org.teiid.widenComparisonToString to true. I don't see any bigger change than that.
> Add an option to not widen comparisons to string
> ------------------------------------------------
>
> Key: TEIIDDES-2665
> URL: https://issues.jboss.org/browse/TEIIDDES-2665
> Project: Teiid Designer
> Issue Type: Quality Risk
> Components: Patch Release, Teiid Integration
> Reporter: Steven Hawkins
> Assignee: Barry LaFond
> Fix For: 10.0.3
>
>
> Our resolving logic considers anything with an implicit conversion to string to be a valid widening conversion in a comparison. For example:
> int_col = '1a'
> will effectively become cast(int_col as string) = '1a'
> Or with timestamps:
> timestamp_col = '1970-01-01'
> becomes cast(timestamp_col as string) = '1970-01-01'
> In equality cases the optimizer will infer that the predicate is simply false, but when used with greater/less than comparison we'll still attempt the query with the widening conversion.
> This is most likely not the intent of the user. It would be best to provide an option that would allow an exception to be thrown rather than assuming a query that may not match the user's expectations.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 8 months
[JBoss JIRA] (TEIIDDES-2665) Add an option to not widen comparisons to string
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIIDDES-2665?page=com.atlassian.jira.plu... ]
Van Halbert commented on TEIIDDES-2665:
---------------------------------------
Based on Teiid's comments, the UI only needs to add an option that will set the system property org.teiid.widenComparisonToString to true. I don't see any bigger change than that.
> Add an option to not widen comparisons to string
> ------------------------------------------------
>
> Key: TEIIDDES-2665
> URL: https://issues.jboss.org/browse/TEIIDDES-2665
> Project: Teiid Designer
> Issue Type: Quality Risk
> Components: Patch Release, Teiid Integration
> Reporter: Steven Hawkins
> Assignee: Barry LaFond
> Fix For: 10.0.3
>
>
> Our resolving logic considers anything with an implicit conversion to string to be a valid widening conversion in a comparison. For example:
> int_col = '1a'
> will effectively become cast(int_col as string) = '1a'
> Or with timestamps:
> timestamp_col = '1970-01-01'
> becomes cast(timestamp_col as string) = '1970-01-01'
> In equality cases the optimizer will infer that the predicate is simply false, but when used with greater/less than comparison we'll still attempt the query with the widening conversion.
> This is most likely not the intent of the user. It would be best to provide an option that would allow an exception to be thrown rather than assuming a query that may not match the user's expectations.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 8 months
[JBoss JIRA] (TEIIDDES-2915) Not all the data types are show in drop down when creating column
by Van Halbert (JIRA)
Van Halbert created TEIIDDES-2915:
-------------------------------------
Summary: Not all the data types are show in drop down when creating column
Key: TEIIDDES-2915
URL: https://issues.jboss.org/browse/TEIIDDES-2915
Project: Teiid Designer
Issue Type: Bug
Components: Dialogs
Affects Versions: 9.0.2
Reporter: Van Halbert
Priority: Minor
In the new table wizard, click on the Columns tab, then press the "Add" button to add a column (which the dialog pops up). The drop down list of data types are not the same list of data types in the drop down as they are in the panel from which the "Add" was called. In the list column listing, select the drop down and many more are available.
Also, from a usability standpoint, when the "Add" button is pressed, go ahead an pop up the add column dialog so the user can start entering, don't make the user have double select the newly added column in the list to get that dialog to pop up.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 8 months