[
https://issues.jboss.org/browse/TEIIDDES-2551?page=com.atlassian.jira.plu...
]
Mark Drilling commented on TEIIDDES-2551:
-----------------------------------------
ResourceRefactorUtils was checking the OS, in order to determine whether to allow
additional 'offsets' due to the Window line terminators. This was not working
because the model files were created on linux, then moved over to windows. So, it is not
enough to check the OS. I changed the Utils to look in the file to determine the line
terminators, instead of checking the OS. Retested on linux and windows and both working
ok now.
The change was committed to master and 9.0.x branches
Renaming source model in a project exported from older version of
designer breaks dependent models
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-2551
URL:
https://issues.jboss.org/browse/TEIIDDES-2551
Project: Teiid Designer
Issue Type: Bug
Components: Modeling
Affects Versions: 9.0.2 Beta2
Environment: Windows 7
Reporter: Andrej Šmigala
Assignee: Mark Drilling
Priority: Blocker
Fix For: 9.1, 9.0.2 Beta2, 9.0.2
Attachments: ModelRefactoringProject.zip
When trying to rename a source model in a model that was exported from older version of
designer, the refactoring fails and the dependent view models are completely broken. This
does not happen when the same models are created from scratch.
Only happens on Windows.
Stacktrace:
{noformat}
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl$1DiagnosticWrappedException:
org.xml.sax.SAXParseExceptionpublicId:
file:/C:/Users/dv/workspaces/jbds-8.1.0.GA_jbdsis-8.0.2.CR1/ModelRefactoringProject/partssupplier_view_3.xmi;
systemId:
file:/C:/Users/dv/workspaces/jbds-8.1.0.GA_jbdsis-8.0.2.CR1/ModelRefactoringProject/partssupplier_view_3.xmi;
lineNumber: 6; columnNumber: 112; Element type "modelImports" must be followed
by either attribute specifications, ">" or "/>".
at
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.handleDemandLoadException(ResourceSetImpl.java:319)
at
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:278)
at
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.getResource(ResourceSetImpl.java:406)
at
org.teiid.designer.core.resource.EmfResourceSetImpl.getResource(EmfResourceSetImpl.java:235)
at org.teiid.designer.core.container.ContainerImpl.getResource(ContainerImpl.java:819)
at
org.teiid.designer.core.container.ContainerImpl.getOrCreateResource(ContainerImpl.java:204)
at org.teiid.designer.core.workspace.ModelBufferImpl.open(ModelBufferImpl.java:237)
at
org.teiid.designer.core.workspace.ModelResourceImpl.openBuffer(ModelResourceImpl.java:445)
at org.teiid.designer.core.workspace.OpenableImpl.getBuffer(OpenableImpl.java:405)
at org.teiid.designer.core.workspace.OpenableImpl.getBufferHack(OpenableImpl.java:378)
at
org.teiid.designer.core.workspace.ModelResourceImpl.getModelAnnotation(ModelResourceImpl.java:634)
at
org.teiid.designer.core.extension.ModelExtensionUtils.getResourceAnnotationImpl(ModelExtensionUtils.java:422)
at
org.teiid.designer.core.extension.ModelExtensionUtils.getResourceAnnotation(ModelExtensionUtils.java:474)
at
org.teiid.designer.core.extension.ModelExtensionUtils.getSupportedNamespaces(ModelExtensionUtils.java:503)
at
org.teiid.designer.core.extension.ModelExtensionUtils.isSupportedNamespace(ModelExtensionUtils.java:533)
at
org.teiid.designer.core.extension.EmfModelObjectExtensionAssistant.supportsMyNamespace(EmfModelObjectExtensionAssistant.java:598)
at
org.teiid.designer.metamodels.relational.extension.RelationalModelExtensionAssistant.applyMedIfNecessary(RelationalModelExtensionAssistant.java:94)
at
org.teiid.designer.metamodels.relational.RelationalPlugin.handleNewModelEvent(RelationalPlugin.java:208)
at
org.teiid.designer.metamodels.relational.RelationalPlugin$2.notifyAdd(RelationalPlugin.java:174)
at
org.teiid.designer.core.workspace.ModelWorkspaceManager.fire(ModelWorkspaceManager.java:631)
at
org.teiid.designer.core.workspace.DeltaProcessor.fireNotification(DeltaProcessor.java:140)
at
org.teiid.designer.core.workspace.DeltaProcessor.resourceChanged(DeltaProcessor.java:70)
at
org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at
org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
at
org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
at
org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:378)
at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1498)
at
org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:45)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: org.xml.sax.SAXParseExceptionpublicId:
file:/C:/Users/dv/workspaces/jbds-8.1.0.GA_jbdsis-8.0.2.CR1/ModelRefactoringProject/partssupplier_view_3.xmi;
systemId:
file:/C:/Users/dv/workspaces/jbds-8.1.0.GA_jbdsis-8.0.2.CR1/ModelRefactoringProject/partssupplier_view_3.xmi;
lineNumber: 6; columnNumber: 112; Element type "modelImports" must be followed
by either attribute specifications, ">" or "/>".
at
com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:198)
at
com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:177)
at
com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:441)
at
com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:368)
at
com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1436)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.seekCloseOfStartTag(XMLDocumentFragmentScannerImpl.java:1395)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1328)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2786)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:648)
at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:332)
at org.eclipse.emf.ecore.xmi.impl.XMLLoadImpl.load(XMLLoadImpl.java:175)
at
org.teiid.designer.core.resource.xmi.MtkXmiResourceImpl.doLoad(MtkXmiResourceImpl.java:284)
at org.eclipse.emf.ecore.resource.impl.ResourceImpl.load(ResourceImpl.java:1518)
at org.eclipse.emf.ecore.resource.impl.ResourceImpl.load(ResourceImpl.java:1297)
at
org.teiid.designer.core.resource.xmi.MtkXmiResourceImpl.load(MtkXmiResourceImpl.java:224)
at
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoad(ResourceSetImpl.java:259)
at
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:274)
... 28 more
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)