[JBoss JIRA] (TEIIDDES-1259) USABILITY: When reconciling transformation and reserved word is encountered, can the error message indicate its a reserved word
9:54 a.m.
Van Halbert created TEIIDDES-1259:
-------------------------------------
Summary: USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of the
invalidation, could the error message indicate as such? This may have already been done,
but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 a.m.
[
https://issues.jboss.org/browse/TEIIDDES-1259?page=com.atlassian.jira.plu...
]
Barry LaFond commented on TEIIDDES-1259:
----------------------------------------
Please add a simple use-case that will end up with the "unclear" error message
USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
-------------------------------------------------------------------------------------------------------------------------------
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of
the invalidation, could the error message indicate as such? This may have already been
done, but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
[
https://issues.jboss.org/browse/TEIIDDES-1259?page=com.atlassian.jira.plu...
]
Van Halbert commented on TEIIDDES-1259:
---------------------------------------
SELECT
AllCustomerAccounts.customer.customerid, AllCustomerAccounts.account.accountid,
Sum(value)
FROM
AllCustomerAccounts.customer, AllCustomerAccounts.account,
BrokerageModel.AccountHoldings
WHERE
(AllCustomerAccounts.customer.customerid = AllCustomerAccounts.account.customerid) AND
(AllCustomerAccounts.account.accountid = BrokerageModel.AccountHoldings.accountid)
GROUP BY AllCustomerAccounts.customer.customerid, AllCustomerAccounts.account.accountid
Error Detail:
ERROR: Parsing error: Encountered "value" at line 2, column 101.
Was expecting one of:
"all" ...
"distinct" ...
"exists" ...
"has" ...
"not" ...
"*" ...
"translate" ...
"?" ...
<POS_REF> ...
<STRINGVAL> ...
<INTEGERVAL> ...
<FLOATVAL> ...
"false" ...
"true" ...
"unknown" ...
"null" ...
<BOOLEANTYPE> ...
<TIMESTAMPTYPE> ...
<DATETYPE> ...
<TIMETYPE> ...
"{" ...
<ID> ...
"any" ...
"some" ...
"xmlagg" ...
"array_agg" ...
"convert" ...
"cast" ...
"left" ...
"right" ...
"char" ...
"user" ...
"year" ...
"month" ...
"hour" ...
"minute" ...
"second" ...
"xmlconcat" ...
"xmlcomment" ...
"insert" ...
"xmlparse" ...
"xmlelement" ...
"xmlpi" ...
"xmlforest" ...
"xmlserialize" ...
"xmlquery" ...
"(" ...
"case" ...
"for" ...
USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
-------------------------------------------------------------------------------------------------------------------------------
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of
the invalidation, could the error message indicate as such? This may have already been
done, but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:13 a.m.
[
https://issues.jboss.org/browse/TEIIDDES-1259?page=com.atlassian.jira.plu...
]
Van Halbert commented on TEIIDDES-1259:
---------------------------------------
I think getting that massive error message when all that's needed is to indicate that
"value" is a reserved word, is a good use case.
USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
-------------------------------------------------------------------------------------------------------------------------------
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of
the invalidation, could the error message indicate as such? This may have already been
done, but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:13 a.m.
[
https://issues.jboss.org/browse/TEIIDDES-1259?page=com.atlassian.jira.plu...
]
Van Halbert edited comment on TEIIDDES-1259 at 2/27/12 11:13 AM:
-----------------------------------------------------------------
I think getting that massive error message when all that's needed is to indicate that
"value" is a reserved word, is a good use case. And it was resolved by putting
double quotes around "value".
was (Author: van.halbert):
I think getting that massive error message when all that's needed is to indicate
that "value" is a reserved word, is a good use case.
USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
-------------------------------------------------------------------------------------------------------------------------------
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of
the invalidation, could the error message indicate as such? This may have already been
done, but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:33 a.m.
[
https://issues.jboss.org/browse/TEIIDDES-1259?page=com.atlassian.jira.plu...
]
Steven Hawkins commented on TEIIDDES-1259:
------------------------------------------
Starting with Designer 7.5 the error message will no longer be massive (TEIID-1655). The
detection of this situation tightly coupled with javacc. The QueryParserException would
need caught, getParseException would need to be called to get the actual javacc exception,
then ParseException.currentToken.kind would need to be checked to see if the token is not
a SQLParserConstants.ID, LPAREN, or any other non-reseved word token. Then you would have
to check the ParseException.expectedTokenSequences (which also reference
SQLParserConstants) to see if any valid expansions start with SQLParserConstants.ID. Even
then, that does not guarantee the situation will actually be the simple case of just
expecting a double quoted identifier.
USABILITY: When reconciling transformation and reserved word is
encountered, can the error message indicate its a reserved word
-------------------------------------------------------------------------------------------------------------------------------
Key: TEIIDDES-1259
URL: https://issues.jboss.org/browse/TEIIDDES-1259
Project: Teiid Designer
Issue Type: Enhancement
Components: Transformations
Affects Versions: 7.4.2
Reporter: Van Halbert
Priority: Minor
When the reconciler is validating the sql and a use of a reserved word is the cause of
the invalidation, could the error message indicate as such? This may have already been
done, but I didn't see a jira indicating it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4637
days inactive
4637
days old
teiid-designer-issues@lists.jboss.org
5 comments
3 participants
participants (3)
-
Barry LaFond (JIRA) -
Steven Hawkins (JIRA)
-
Van Halbert (JIRA)