[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Barry LaFond reassigned TEIIDDES-1300: -------------------------------------- Assignee: Paul Richardson Per conversation today. Scope will be to add logic to convert the column name to replace the ":" character (if exists) with an underscore "_". This will maintain some reference to the namespace prefixe's of some columns (i.e. d:value >> d_value) Also need to add basic name validation. See validation used for new WSDL Importer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Work on TEIIDDES-1300 started by Paul Richardson. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Paul Richardson commented on TEIIDDES-1300: ------------------------------------------- The columns are derived from TeiidColumnInfo objects, which already have validation checking performed on construction. It seems that this validation is already failing due to the ":" in the name and the TeiidColumnInfo instance's status set to Error. This status is in turn assigned to the status of the encompassing TeiidXMLFileInfo instance. However, this info object's status is never checked by the xml import wizard (TeiidXMLImportWizard), unlike the flat file wizard (TeiidMetadataImportWizard) (see TeiidMetadataImportFormatPage.validatePage()). Proposals: a) Have the XML wizard page (TeiidXmlImportXmlConfigurationPage) observe the status of the info object and error until the columns have been changed by the user. b) TeiidColumnInfo has a nameValidator inside it used for the validation. This also has the ability to 'fix' the name to make it valid. Modify the constructor responsible for setting the name, to fix the name before assigning it. This would impact both the xml and file wizards, but I think would be helpful to both. Personally, favour option b but I think the page validation, mentioned in option a, does need fixing as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Paul Richardson commented on TEIIDDES-1300: ------------------------------------------- Allowing ':' is possible since extra characters can be included in StringNameValidator (but currently not in RelationalStringNameValidator, which is used by TeiidColumnInfo). Difficult to see at the moment how to get hold of the validation rules for teiid columns as the SQL string is converted into a tree then visited by teiid's validator visitor. May be able to tease out the functions relating to just the columns. Not sure it gets us very much and may well be slower than the quick string find/replace the StringNameValidator is doing at the moment. Will commit workaround for the moment. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1300: -------------------------------------- Attachment: 0001-Handle-XML-namespace-syntax-in-XML-file-importer.patch 0002-Create-quoted-column-names-if-names-are-invalid.patch Proposed implementations subject to resolution of [2012|https://issues.jboss.org/browse/TEIID-2012] 0001 - Converts all invalid columns names into legal names using '_'s 0002 - Wraps all invalid columns names, including teiid keywords, with double quotes -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1300: -------------------------------------- Attachment: 0001-Modify-column-info-name-to-use-element-symbol.patch 0002-String-Validator-does-not-check-for-reserved-words.patch Latest patches for review. 0001-Modify-column-info-name-to-use-element-symbol.patch - Main patch for fixing the column and ensuring the names are valid 0002-String-Validator-does-not-check-for-reserved-words.patch - A nice to have, ensuring that the StringNameValidator checks against reserved words -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1300?page=com.atlassian.jira.plu... ] Barry LaFond updated TEIIDDES-1300: ----------------------------------- Attachment: (was: 0001-Handle-XML-namespace-syntax-in-XML-file-importer.patch) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira