[JBoss JIRA] Created: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
2:38 a.m.
StringNameValidator.createUniqueName() method is performing multiple unnecessary string
operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [JBoss JIRA] Updated: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-960:
----------------------------------
Attachment: docbook.xsd
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [JBoss JIRA] Updated: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-960:
----------------------------------
Attachment: xml.xsd
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
New subject: [JBoss JIRA] Updated: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-960:
----------------------------------
Attachment: xlink.xsd
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 p.m.
New subject: [JBoss JIRA] Resolved: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Dan Florian resolved TEIIDDES-960.
----------------------------------
Resolution: Done
Rewrote StringNameValidator so that it will be much more efficient creating unique names.
JDBC importing of big models should happen much more quickly now.
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:11 a.m.
New subject: [JBoss JIRA] Reopened: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Dan Florian reopened TEIIDDES-960:
----------------------------------
When importing a model with tables containing columns of the same name, a unique column
name is being created when it shouldn't since the columns are in different tables.
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 a.m.
New subject: [JBoss JIRA] Resolved: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Dan Florian resolved TEIIDDES-960.
----------------------------------
Resolution: Done
To determine uniqueness, names are now only compared to sibling names.
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:27 a.m.
New subject: [JBoss JIRA] Reopened: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Barry LaFond reopened TEIIDDES-960:
-----------------------------------
Looks like there's a minor naming issue with the new changes.
Import from MySQL Products and the productsymbols table is imported with the
"SYMBOL" column resulting in a "SYMBOL1" name.
There is another column "SYMBOL_TYPE" that gets created first and for some
reason the new logic is thinking that "SYMBOL" already is a column.
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:29 a.m.
New subject: [JBoss JIRA] Updated: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-960:
----------------------------------
Fix Version/s: 7.5
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.4, 7.5
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:24 a.m.
New subject: [JBoss JIRA] Resolved: (TEIIDDES-960) StringNameValidator.createUniqueName() method is performing multiple unnecessary string operations
[
https://issues.jboss.org/browse/TEIIDDES-960?page=com.atlassian.jira.plug...
]
Dan Florian resolved TEIIDDES-960.
----------------------------------
Fix Version/s: (was: 7.4)
Resolution: Done
Fixed a bug in StringNameValidator's existing name data structures. Also added a
toString() to the data structures to help with debugging.
StringNameValidator.createUniqueName() method is performing multiple
unnecessary string operations
--------------------------------------------------------------------------------------------------
Key: TEIIDDES-960
URL: https://issues.jboss.org/browse/TEIIDDES-960
Project: Teiid Designer
Issue Type: Bug
Components: Import/Export, Modeling
Affects Versions: 7.4
Reporter: Barry LaFond
Assignee: Dan Florian
Fix For: 7.5
Attachments: docbook.xsd, xlink.xsd, xml.xsd
Discovered that StringNameValidator.createUniqueName() method is performing an interative
existingName.toUpperCase() call.
Importing BQT2 tables from SQL Server, for instance resulted in 2200+ calls to
existingName.toUpperCase().
jdbc:sqlserver://slntdb02.mw.lab.eng.bos.redhat.com:1433;databaseName=bqt2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4719
days inactive
4763
days old
teiid-designer-issues@lists.jboss.org
9 comments
2 participants
participants (2)
-
Barry LaFond (JIRA) -
Dan Florian (JIRA)