[
https://issues.jboss.org/browse/TEIIDDES-2333?page=com.atlassian.jira.plu...
]
Paul Richardson commented on TEIIDDES-2333:
-------------------------------------------
Proposal to remove this class since it does not appear to add anything useful to the
classes it is used in.
ControlledPopupMenuExtender's purpose it to seach out other menu commands in other
menus and append them to a given menu if they are relevant to either the menu or the
selected object, eg. IResource. This functionality is used in 3 locations:
# DiagramActionContributor
# MappingDiagramActionAdapter
# TransformationActionAdapter
The first and last classes are called on when displaying the content menu in package,
mapping and transformation diagrams. It is not yet clear whether the
MappingDiagramActionAdapter is ever used.
The result of the 'Extender class is that lots of seemingly unrelated menu actions are
added to the context menu, cluttering it up. See attached screenshot. If these actions are
truly required then it would seem a better idea to find their associated global action and
append them explicitly.
An Additions element is already included on these context menus if other plugins really
want to add functionality to these context menus.
Use of eclipse internal classes in ControlledPopupMenuExtender
--------------------------------------------------------------
Key: TEIIDDES-2333
URL:
https://issues.jboss.org/browse/TEIIDDES-2333
Project: Teiid Designer
Issue Type: Bug
Reporter: Paul Richardson
Assignee: Paul Richardson
Priority: Blocker
Fix For: 8.6.1
Upgrading the Target Platform to Luna, the
[
ControllerPopupMenuExtender|https://github.com/Teiid-Designer/teiid-desig...]
shows a compile error due a change in API of the contributeObjectActions() method.
Since this method is internal, it is within scope for Eclipse to change its API. In
retrospect, Designer should rewrite this class to avoid the use of the internal API, which
would increase the chances of transitioning, between target platforms, being much more
seamless.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)