[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Steven Hawkins commented on TEIIDDES-806: ----------------------------------------- Teiid expects a null value to indicate default handling. If use default is selected, rather than blanking it out, you could just leave whatever sql they have greyed out, and write a null in the index and ensure that your workspace metadata also returns null. The specific insert/update/delete enabled toggle should be removed, and, as you say, the tab icon can be updated if default handling is insufficient for a given procedure. The org.teiid.query.validator.UpdateValidator should be used to perform the validation with the validate method. The methods getReport and get[Insert/Update/Delete]Report can then be used to obtain the resulting ValidationReports for general errors/warnings and errors/warnings that are particular to a procedure type. The ValidatorFailures contained in the reports have a Status flag to determine if they are an error or a warning. One possibility is to display errors and warnings on the insert/update/delete panels themselves. Teiid also now has support for "for each row" procedures that can be used instead of update procedures. These are represented by the TriggerAction class. The initial plan is to support both our old update procedures and the new for each row handling. Any logic that is assuming the presence of a CreateUpdateProcedureCommand may need to be changed to reflect that triggeractions are also supported. The designer resolving logic will need to be updated as well to supply the external metadata expected by a triggeraction (see the reference). Ideally we would take a pass at refactoring the designer logic for creating external metadata so that the responsibility can be pushed to Teiid. The 7.3 final jars are posted on sf http://sourceforge.net/projects/teiid/files/teiid/7.3/ or can be obtained through maven. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Barry LaFond edited comment on TEIIDDES-806 at 2/2/11 9:41 PM: --------------------------------------------------------------- Screen cap of Transformation Editor with Insert/Update/Delete tabs decorated to show which types of procedures allow updates based on: 1) Use Default == TRUE 2) The Select query is understood by the Teiid Query engine and can create a default update procedure. If a specific update type is deemed "not updatable", then the tooltip (shown in screen pic) will indicate the first error or warning provided via the Select SQL validation. If any update type is set to "Use Default == FALSE" then it is assumed that the user will define the update SQL in that tab was (Author: blafond): Screen cap of Transformation Editor with Insert/Update/Delete tabs decorated to show which types of procedures allow updates based on 1) Use Default == TRUE and 2) The Select query is understood by the Teiid Query engine and can create a default update procedure. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Steven Hawkins commented on TEIIDDES-806: ----------------------------------------- Other test cases can be gleaned from TestUpdateValidator and from the reference chapter on updatable views. examples: 1. for an otherwise updatable view "select * from table", adding a non-updatable column "select 1 as col, ... from ..." should generate a general warning. 2. a union can support update/delete if each of the branches support those operations e.g. "select col from table1 union all select col from table2", but it will not be insertable unless it is a partitioned union e.g. "select 1 as source, col from table1 union all select 2, col from table2" 3. insert is not supported unless all required columns are projected. It's not clear to me yet where you are putting the general/specific warnings/errors. Are they on the individual panels? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Barry LaFond updated TEIIDDES-806: ---------------------------------- Attachment: new-update-tabs-decoration_REV_A.png Revision to decorating Update tabs in Transformation Editor. Tab includes (default) text if "Use Default" checked. NOT ALLOWED icon is displayed if SELECT SQL prevents Teiid from performing DEFAULT updates. If Use Default is UNCHECKED, then the first "validation status" is available in tooltip (see figure) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Steven Hawkins updated TEIIDDES-806: ------------------------------------ Attachment: UpdateValidator.patch Here is the Teiid patch for cleaning up the UpdateValidator messages. I think that it would be good to clean these up with the initial Teiid Designer 7.3 release. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Steven Hawkins updated TEIIDDES-806: ------------------------------------ Attachment: (was: status.patch) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-806?page=com.atlassian.jira.plug... ] Steven Hawkins commented on TEIIDDES-806: ----------------------------------------- Added support for trigger action. There is a new parsing hook via an override of the SQL/QueryParser that will be added to Teiid 7.4. That approach seemed easier since there were many callers of the static parsing routine that were not aware of the transformation type. also overrode the UpdateValidator logic, which will also be added to Teiid 7.4 Here again all the teiid_embbedded_query classes will be removed for Teiid Designer 7.4 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira