[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1492: -------------------------------------- Attachment: transformation-validation-errors.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1492: -------------------------------------- Description: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit [#1e044a90|https://github.com/Teiid-Designer/teiid-designer/commit/1e044a90] fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Therefore, originally the commands were modified to not be 'update procedures'. With the reduction of API and the compilation fixes, the commands are incorrectly labelled as validation problems. was: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit #1e044a90 fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Therefore, originally the commands were modified to not be 'update procedures'. Without the reduction of API and the compilation fixes, the commands are incorrectly labelled as validation problems. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Paul Richardson updated TEIIDDES-1492: -------------------------------------- Description: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. The US_States StateService example when this bug was encountered. This State Service was installed in jboss 7 so was modified accordingly. The new version can be downloaded from [here|https://github.com/phantomjinx/teiid-soap-example]. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit [#1e044a90|https://github.com/Teiid-Designer/teiid-designer/commit/1e044a90] fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Thus, originally the commands were instantiated and changed to not be 'update procedures'. This is enough to avoid the test and line 589. With the reduction of API and the compilation fixes, the commands incorrectly generate the validation errors. was: Use the SOAP-based model importer to create source and view models based on a wsdl, already configured in a jboss 7 server. Both the source and view models are created successfully yet 6 errors are generated in the Problems view. See the attached screenshot. h4. Investigation # The 6 problems are generated from SqlTransformationMappingRootValidationRule (lines 589-596) # The test (at line 589) checks the command's type, ie. {code} if (cmdType == Command.TYPE_UPDATE_PROCEDURE) {code} # The virtual procedure command instance is of the class CreateProcedureCommand * TransformationSqlHelper is responsible for creating the CreateProcedureCommand using the createVirtualProcCommmandForCommand() method * The CreateProcedureCommand command used to be CreateUpdateProcedureCommand but this was renamed in Teiid 8.0 * The new command class had the API isUpdateProcedure() and setUpdateProcedure() methods removed * Commit [#1e044a90|https://github.com/Teiid-Designer/teiid-designer/commit/1e044a90] fixed the compilation errors resulting from this API change by ** removing the setUpdateProcedure(false) call in TransformSqlHelper ** removing the isUpdateProcedure() test and the end of line 589 in SqlTransformationMappingRootValidationRule Thus, originally the commands were instantiated and changed to not be 'update procedures'. This is enough to avoid the test and line 589. With the reduction of API and the compilation fixes, the commands incorrectly generate the validation errors. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Dan Florian commented on TEIIDDES-1492: --------------------------------------- Steve H, In the old code we used to call CreateUpdateProcedureCommand.setUpdateProcedure(false). Then in our validation code if the command type was Command.TYPE_UPDATE_PROCEDURE we would create a validation error. The CreateUpdateProcedureCommand no longer exists and has been replaced by CreateProcedureCommand. As stated in the description, when we run the SOAP WSDL importer we are getting view model validation errors when the command type is Command.TYPE_UPDATE_PROCEDURE. Can I assume if the CreateProcedureCommand.getVirtualGroup() is null then the command is for an update procedure and not a virtual stored procedure? Then, in that case (virtual group is null), I would create the validation error. Please advise. Thanks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIIDDES-1492?page=com.atlassian.jira.plu... ] Dan Florian updated TEIIDDES-1492: ---------------------------------- Git Pull Request: https://github.com/Teiid-Designer/teiid-designer/pull/40 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira