[JBoss JIRA] Created: (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
9:51 a.m.
Designer removes parentheses around criteria in ansi join when using compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://jira.jboss.org/jira/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Affects Versions: 6.1.0
Reporter: Marc Shirley
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:08 p.m.
New subject: [JBoss JIRA] Commented: (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://jira.jboss.org/jira/browse/TEIIDDES-216?page=com.atlassian.jira.p...
]
Larry O'Leary commented on TEIIDDES-216:
----------------------------------------
This may have something to do with how JoinPredicate is constructed. When adding some
test cases to a UnitTest I noticed that JoinPredicate may get constructed in two different
ways depending on who is constructing it. One way is to pass the criteria as as Criteria
which may (or may not) contain compound criteria. The other is to pass the criteria as a
List of Criteria in which case it appears the List normally contains one element of type
Criteria which may (or may not) be CompundCriteria. In the first instance, the
CompoundCriteria is broken apart into a List separated by the ANDs of the CompundCriteria.
Of course at a glance it does not appear it takes into consideration that order of
operations may be broken. If this is the case, this issue may need to be moved to Teiid.
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://jira.jboss.org/jira/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Affects Versions: 6.1.0
Reporter: Marc Shirley
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:58 p.m.
New subject: [JBoss JIRA] Updated: (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://jira.jboss.org/jira/browse/TEIIDDES-216?page=com.atlassian.jira.p...
]
Barry LaFond updated TEIIDDES-216:
----------------------------------
Component/s: Transformations
Fix Version/s: Future
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://jira.jboss.org/jira/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Fix For: Future
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:20 a.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-216:
----------------------------------
Fix Version/s: 7.8
Assignee: Mark Drilling
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 7.8, Future
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-216:
----------------------------------
Fix Version/s: 8.0
(was: Future)
(was: 7.8)
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.0
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Steven Hawkins commented on TEIIDDES-216:
-----------------------------------------
Tested all the way back on 7.1 and this was resolved probably due to the language object
and presentation overhaul.
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.0
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:01 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Barry LaFond commented on TEIIDDES-216:
---------------------------------------
Tested with Teiid Designer 7.8 and resulting SQL after validating is:
{code:sql}
SELECT
b.INTKEY, b.STRINGKEY, b.INTNUM, b.STRINGNUM, b.FLOATNUM, b.LONGNUM, b.DOUBLENUM,
b.BYTENUM, b.DATEVALUE, b.TIMEVALUE, b.TIMESTAMPVALUE, b.BOOLEANVALUE, b.CHARVALUE,
b.SHORTVALUE, b.BIGINTEGERVALUE, b.BIGDECIMALVALUE, b.OBJECTVALUE, a.INTKEY AS INTKEY_1,
a.STRINGKEY AS STRINGKEY_1, a.INTNUM AS INTNUM_1, a.STRINGNUM AS STRINGNUM_1, a.FLOATNUM
AS FLOATNUM_1, a.LONGNUM AS LONGNUM_1, a.DOUBLENUM AS DOUBLENUM_1, a.BYTENUM AS BYTENUM_1,
a.DATEVALUE AS DATEVALUE_1, a.TIMEVALUE AS TIMEVALUE_1, a.TIMESTAMPVALUE AS
TIMESTAMPVALUE_1, a.BOOLEANVALUE AS BOOLEANVALUE_1, a.CHARVALUE AS CHARVALUE_1,
a.SHORTVALUE AS SHORTVALUE_1, a.BIGINTEGERVALUE AS BIGINTEGERVALUE_1, a.BIGDECIMALVALUE AS
BIGDECIMALVALUE_1, a.OBJECTVALUE AS OBJECTVALUE_1
FROM
bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND ((a.INTNUM IS
NULL) OR (a.INTNUM = 11))
{code}
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.0
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:03 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Barry LaFond edited comment on TEIIDDES-216 at 8/6/12 3:02 PM:
---------------------------------------------------------------
Tested with Teiid Designer 7.8 and resulting SQL after validating is:
{code:sql}
SELECT
b.INTKEY, b.STRINGKEY, b.INTNUM, b.STRINGNUM, b.FLOATNUM,
b.LONGNUM, b.DOUBLENUM, b.BYTENUM, b.DATEVALUE, b.TIMEVALUE,
b.TIMESTAMPVALUE, b.BOOLEANVALUE, b.CHARVALUE, b.SHORTVALUE,
b.BIGINTEGERVALUE, b.BIGDECIMALVALUE, b.OBJECTVALUE
FROM
bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND ((a.INTNUM IS NULL)
OR (a.INTNUM = 11))
{code}
was (Author: blafond):
Tested with Teiid Designer 7.8 and resulting SQL after validating is:
{code:sql}
SELECT
b.INTKEY, b.STRINGKEY, b.INTNUM, b.STRINGNUM, b.FLOATNUM, b.LONGNUM, b.DOUBLENUM,
b.BYTENUM, b.DATEVALUE, b.TIMEVALUE, b.TIMESTAMPVALUE, b.BOOLEANVALUE, b.CHARVALUE,
b.SHORTVALUE, b.BIGINTEGERVALUE, b.BIGDECIMALVALUE, b.OBJECTVALUE, a.INTKEY AS INTKEY_1,
a.STRINGKEY AS STRINGKEY_1, a.INTNUM AS INTNUM_1, a.STRINGNUM AS STRINGNUM_1, a.FLOATNUM
AS FLOATNUM_1, a.LONGNUM AS LONGNUM_1, a.DOUBLENUM AS DOUBLENUM_1, a.BYTENUM AS BYTENUM_1,
a.DATEVALUE AS DATEVALUE_1, a.TIMEVALUE AS TIMEVALUE_1, a.TIMESTAMPVALUE AS
TIMESTAMPVALUE_1, a.BOOLEANVALUE AS BOOLEANVALUE_1, a.CHARVALUE AS CHARVALUE_1,
a.SHORTVALUE AS SHORTVALUE_1, a.BIGINTEGERVALUE AS BIGINTEGERVALUE_1, a.BIGDECIMALVALUE AS
BIGDECIMALVALUE_1, a.OBJECTVALUE AS OBJECTVALUE_1
FROM
bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND ((a.INTNUM IS
NULL) OR (a.INTNUM = 11))
{code}
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.0
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Barry LaFond updated TEIIDDES-216:
----------------------------------
Fix Version/s: 8.1
(was: 8.0)
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.1
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:22 p.m.
New subject: [JBoss JIRA] (TEIIDDES-216) Designer removes parentheses around criteria in ansi join when using compound ON
[
https://issues.jboss.org/browse/TEIIDDES-216?page=com.atlassian.jira.plug...
]
Mark Drilling resolved TEIIDDES-216.
------------------------------------
Fix Version/s: 8.0
(was: 8.1)
Resolution: Done
I retested this in 8.0 alpha1 and it is working as expected, so assuming this was resolved
as indicated previously.
Designer removes parentheses around criteria in ansi join when using
compound ON
--------------------------------------------------------------------------------
Key: TEIIDDES-216
URL: https://issues.jboss.org/browse/TEIIDDES-216
Project: Teiid Designer
Issue Type: Bug
Components: Transformations
Affects Versions: 6.1.0
Reporter: Marc Shirley
Assignee: Mark Drilling
Fix For: 8.0
In Designer, when validating a transformation that has compound criteria in an ansi join
statement's ON, the parentheses are removed and the order of operations is modified as
a result. This does not appear to occur when using the same parentheses structure in
WHERE criteria.
Before validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON (a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL OR a.INTNUM = 11)
After validation:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON a.INTKEY = b.INTKEY AND
(a.INTNUM IS NULL) OR (a.INTNUM = 11)
After validating a second time:
SELECT * FROM bqt.SMALLA AS a INNER JOIN bqt.SMALLB AS b ON ((a.INTKEY = b.INTKEY) AND
(a.INTNUM IS NULL)) OR (a.INTNUM = 11)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4198
days inactive
5392
days old
teiid-designer-issues@lists.jboss.org
9 comments
5 participants
participants (5)
-
Barry LaFond (JIRA) -
Larry O'Leary (JIRA)
-
Marc Shirley (JIRA)
-
Mark Drilling (JIRA)
-
Steven Hawkins (JIRA)