On Mon, Apr 15, 2019 at 8:59 PM Darran Lofthouse <darran.lofthouse@jboss.com> wrote:
I have been looking at the steps required to migrate the WildFly Elytron integration to Undertow 3 from Undertow 2.

Overall it seems minimal changes are required but I was thinking if there could be an opportunity to evolve the API within Undertow 2 making migration to 3 easier in the future.

One example being on SSSessionInfo we make use of the following method: -

void renegotiate(HttpServerExchange exchange, SslClientAuthMode sslClientAuthMode) throws IOException;

which has now been changed to: -

void renegotiate(HttpServerExchange exchange, ClientAuth sslClientAuthMode) throws IOException;

The first form is making use of Xnio API and the second is using Netty API.

If this was deprecated in Undertow 2 and a pure Undertow variant added it could be usable both in 2 and 3.

This is a good idea. If you see areas where this can be done can you file a JIRA (or better yet open a PR)?

In this case I think we should get rid of the Netty one entirely, and just have an agnostic one.

Maybe we also need an Undertow 2.1 branch, which will aim to improve compatibility by adding methods like this that will work in both versions.

Stuart
 

I suspect a number of the other changes breaking API compatibility could be handled in a similar way.

Regards,
Darran Lofthouse.





_______________________________________________
undertow-dev mailing list
undertow-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/undertow-dev