Hello
Pull requests for the updated patch are up :) If anyone has a better name
for the property please let me know.
Regards
Benjamin
From:
Martin Kouba <mkouba@redhat.com>
To:
Benjamin Confino <BENJAMIC@uk.ibm.com>,
weld-dev@lists.jboss.org
Date:
18/04/2018 13:22
Subject:
Re: [weld-dev]
WIP fix for https://issues.jboss.org/browse/WELD-1130
Dne 18.4.2018 v 14:02 Martin Kouba napsal(a):
> Hi Benjamin,
>
> I'm sorry but the Weld team is burried under some high priority issues.
> I've quickly went through your proposal and have few comments.
>
> 1. I think it would be more convenient to modify
> org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.getAttribute(String)
Sorry, I meant
org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.get(BeanIdentifier)
> which is used for both the HTTP session and the conversation contexts
>
> 2. +1 for config property, we probably need a better name though ;-)
>
> 3. You're probably aware that this would not solve the problem
> completely. It should trigger the replication when a @SessionScoped
bean
> instance is obtained from the context, e.g. when a client proxy method
> is invoked. However, there are some optimizations in Weld which prevent
> the context lookup (see also
> org.jboss.weld.bean.ContextualInstanceStrategy). Also the replication
> may happen before the state is actually changed - it really depends
on
> replication impl details. Still, I agree that this would improve the
> usability.
>
> 4. +10 for tests. But I guess it would be tricky to write an automated
> test for this.
>
> Martin
>
> Dne 13.4.2018 v 21:33 Benjamin Confino napsal(a):
>> Hello
>>
>> I posed
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_benjamin-2Dconfino_core_commit_35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=8MGYr6cF9UfBNJIHJLA4qMWaJNF5zfqmbTsMLN6LMjY&e=
>> this lift list month but have not heard any feedback. When can
I
>> expect to hear if this concept is good in principal? If the concept
is
>> good I can begin investigating how to extend the idea to conversation
>> scopes and write a test.
>>
>> Regards
>> Benjamin
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with
>> number 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6
>> 3AU
>>
>>
>> _______________________________________________
>> weld-dev mailing list
>> weld-dev@lists.jboss.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=V5hOUdwYU955kSnYhICFsY4JC-dIfRT_9wxy9_cAsVo&e=
>>
--
Martin Kouba
Senior Software Engineer
Red Hat, Czech Republic
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU