Good morning.

No worries about Weld 2 releases, I've already informed the team of the situation regarding that branch, but I thought it was no trouble to submit a PR anyway.

Regarding your question about verification, my understanding of where things are is that we shifted to looking for a more general solution to make liberty more resilient as we promptly uncovered a different upstream component that had a stream without a closing statement. Tom Bitonti will be taking the lead on that.

Regards
Benjamin



From:        Matej Novotny <manovotn@redhat.com>
To:        Benjamin Confino <BENJAMIC@uk.ibm.com>
Cc:        weld-dev@lists.jboss.org, Thomas Bitonti <bitonti@us.ibm.com>
Date:        09/12/2019 10:12
Subject:        [EXTERNAL] Re: [weld-dev] Pull Request to close weld.properties file sooner

---

Hello,

thanks for the PR. We're totally missing the stream closing statement there.
I take it you verified that this fixes the problem in Liberty?

Otherwise, master branch (Weld 3.1) is totally where these PRs should go.
As for 3.0, we do not plan any releases there, we are going forward with just 3.1 branch.
So I don't really see much value in merging it there.
Last but not least, Weld 2 is not actively developed anymore and doesn't have a set release schedule.
Therefore, we can merge it there, but with no promises on release dates.

I've created a tracking JIRA for this - https://issues.redhat.com/browse/WELD-2606

Regards
Matej

----- Original Message -----
> From: "Benjamin Confino" <BENJAMIC@uk.ibm.com>
> To: weld-dev@lists.jboss.org
> Cc: "Thomas Bitonti" <bitonti@us.ibm.com>
> Sent: Saturday, December 7, 2019 12:34:17 PM
> Subject: [weld-dev] Pull Request to close weld.properties file sooner
>
> Hello
>
> We encountered a bug in liberty which we think is caused by the
> weld.properties file remaining open for longer than liberty expects files to
> be held open. To resolve this I have submitted a trio of small pull requests
> that will close the InputStream in a finally block after weld.properties is
> read. You can find them at:
>
> https://github.com/weld/core/pull/1953
> https://github.com/weld/core/pull/1954
> https://github.com/weld/core/pull/1955
>
> I hope these PRs meet with your approval.
>
> Regards
> Benjamin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
> _______________________________________________
> weld-dev mailing list
> weld-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/weld-dev





Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU