From jira-events at lists.jboss.org Tue Jun 8 09:06:38 2010 Content-Type: multipart/mixed; boundary="===============4422649160846133423==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Tue, 08 Jun 2010 09:06:38 -0400 Message-ID: <633140902.3155.1276002398257.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============4422649160846133423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] David Beaumont updated WELD-549: -------------------------------- Attachment: CdiConvoBug.war Demo that runs on Glassfish of h:link conversation propagation > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============4422649160846133423==-- From jira-events at lists.jboss.org Tue Jun 8 09:06:38 2010 Content-Type: multipart/mixed; boundary="===============3354833791774427035==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Created: (WELD-549) Conversation propagated by default with h:link Date: Tue, 08 Jun 2010 09:06:38 -0400 Message-ID: <1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> --===============3354833791774427035== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Conversation propagated by default with h:link ---------------------------------------------- Key: WELD-549 URL: https://jira.jboss.org/browse/WELD-549 Project: Weld Issue Type: Bug Components: Web Tier integration (JSF, JSP, EL and Servlet) = Affects Versions: 1.0.1.Final Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS = 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) Reporter: David Beaumont Attachments: CdiConvoBug.war I created a long running conversation by running a method on a conversation= scoped bean: private boolean initialized; public void init() { if(initialized) return; conversation.begin(); initialized =3D true; } >From a facelets page using the JSF2 event system: If a conversation has been made long-running, the h:link tag will produce l= inks with the conversation query parameter, thereby propagating the convers= ation whether that was what you wanted or not. I.e:

Link:

produces

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============3354833791774427035==-- From jira-events at lists.jboss.org Tue Jun 8 09:10:38 2010 Content-Type: multipart/mixed; boundary="===============1405531100064068485==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Tue, 08 Jun 2010 09:10:38 -0400 Message-ID: <298314298.3173.1276002638137.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1405531100064068485== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534457#actio= n_12534457 ] = David Beaumont commented on WELD-549: ------------------------------------- Also see: http://seamframework.org/Community/ApparentInaccuraciesInConversa= tionDocumentation > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1405531100064068485==-- From jira-events at lists.jboss.org Wed Jun 9 04:59:38 2010 Content-Type: multipart/mixed; boundary="===============1755502397647957661==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 04:59:38 -0400 Message-ID: <2005100016.5654.1276073978365.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1755502397647957661== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir updated WELD-549: --------------------------- Assignee: Nicklas Karlsson Fix Version/s: 1.0.2.CR1 Nik, could you take a look. I do believe that putting an empty should override conversation propagation. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1755502397647957661==-- From jira-events at lists.jboss.org Wed Jun 9 06:10:38 2010 Content-Type: multipart/mixed; boundary="===============3274614374790277267==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 06:10:38 -0400 Message-ID: <330687378.5782.1276078238356.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============3274614374790277267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534689#actio= n_12534689 ] = David Beaumont commented on WELD-549: ------------------------------------- Isn't the point of the h:link tag to enhance bookmarkability, so you can sh= are links make your site easier for spiders etc. If the default is to propa= gate the conversation you have at best created yourself a memory leak and b= ugs from conflicting state. At worst you will start writing your applicatio= n around this propagation and will have lost all the benefits of the new ta= g anyway and make a poor web site for your users. Whilst understanding you are the JSF experts not me, I really think the def= ault should be not to propagate. = > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============3274614374790277267==-- From jira-events at lists.jboss.org Wed Jun 9 06:14:38 2010 Content-Type: multipart/mixed; boundary="===============2520442056891398927==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 06:14:38 -0400 Message-ID: <597748716.5801.1276078478216.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2520442056891398927== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534692#actio= n_12534692 ] = Pete Muir commented on WELD-549: -------------------------------- Actually, David, yes you are right. Thanks for pointing that out! > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2520442056891398927==-- From jira-events at lists.jboss.org Wed Jun 9 07:58:38 2010 Content-Type: multipart/mixed; boundary="===============5345847995471339109==" MIME-Version: 1.0 From: Nicklas Karlsson (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 07:58:38 -0400 Message-ID: <1353324366.5939.1276084718124.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============5345847995471339109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534714#actio= n_12534714 ] = Nicklas Karlsson commented on WELD-549: --------------------------------------- Dan appears to have been thinking about this at some point. From the header= block of ConversationAwareViewHandler: * QUESTION should we do the same for getResourceURL? * TODO we should enable a way to disable conversation propagation by URL * = * @author Dan Allen */ > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============5345847995471339109==-- From jira-events at lists.jboss.org Wed Jun 9 08:16:38 2010 Content-Type: multipart/mixed; boundary="===============0063986769590522120==" MIME-Version: 1.0 From: Nicklas Karlsson (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 08:16:38 -0400 Message-ID: <1913224401.6038.1276085798472.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0063986769590522120== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534718#actio= n_12534718 ] = Nicklas Karlsson commented on WELD-549: --------------------------------------- So does this essentially mean that we drop the ConversationAwareViewHandler= and ask users to do a (which will be automatically appended by JSF?) = Or should we keep the CAVH and add the cid only for non-transient conversat= ions? Or something else? > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0063986769590522120==-- From jira-events at lists.jboss.org Wed Jun 9 08:18:38 2010 Content-Type: multipart/mixed; boundary="===============7123092911711332468==" MIME-Version: 1.0 From: Nicklas Karlsson (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 08:18:38 -0400 Message-ID: <2026911808.6043.1276085918123.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============7123092911711332468== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534719#actio= n_12534719 ] = Nicklas Karlsson commented on WELD-549: --------------------------------------- #{javax.enterprise.context.conversation.id} in the previous comment > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============7123092911711332468==-- From jira-events at lists.jboss.org Wed Jun 9 13:12:38 2010 Content-Type: multipart/mixed; boundary="===============5942427407249490663==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 13:12:38 -0400 Message-ID: <689661367.6588.1276103558123.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============5942427407249490663== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534788#actio= n_12534788 ] = Pete Muir commented on WELD-549: -------------------------------- The spec requires an explicit f:param for h:link. Automatic add should be part of the Seam navigation system. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============5942427407249490663==-- From jira-events at lists.jboss.org Wed Jun 9 14:54:38 2010 Content-Type: multipart/mixed; boundary="===============3477767672385394328==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 14:54:38 -0400 Message-ID: <1282487781.6734.1276109678140.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============3477767672385394328== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534799#actio= n_12534799 ] = David Beaumont commented on WELD-549: ------------------------------------- I think changing the behaviour according to whether there is a long-running= conversation would be confusing. Imagine a navigation bar with h:links to = different parts of your site that is stored in a template or otherwise incl= uded into the current view. On views where there is not a long-running conv= ersation these links would not include the cid; On views where there is, th= e cid parameter would be automatically added, possibly changing how the tar= get page of the h:link functions. Suppose a site has a search list page and an entity home page. The entity h= ome page has a long-running conversation so users can save changes. This me= ans that an h:link back to the list page propagates the conversation. The u= ser then clicks on a second entity, but is very confused to see the first e= ntity they just looked at again, because the conversation has propagated ri= ght round a loop of views. Since I am waiting for a working JBAS6 to test o= n, my understanding of how you would write a CDI crud application is probab= ly lacking. Changing the behaviour with Seam would be a bit strange too - adding Seam t= o your CDI application could make it function differently, perhaps wrongly,= without having changed a single line of code. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============3477767672385394328==-- From jira-events at lists.jboss.org Wed Jun 9 16:49:38 2010 Content-Type: multipart/mixed; boundary="===============3843475034578788657==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 09 Jun 2010 16:49:38 -0400 Message-ID: <1868030734.6846.1276116578109.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============3843475034578788657== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534817#actio= n_12534817 ] = Pete Muir commented on WELD-549: -------------------------------- Of course, you would need to tell Seam to add the cid propagation automatic= ally :-) > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============3843475034578788657==-- From jira-events at lists.jboss.org Thu Jun 10 04:21:38 2010 Content-Type: multipart/mixed; boundary="===============1800528944604211990==" MIME-Version: 1.0 From: David Beaumont (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Thu, 10 Jun 2010 04:21:38 -0400 Message-ID: <555442324.7497.1276158098159.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1800528944604211990== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12534893#actio= n_12534893 ] = David Beaumont commented on WELD-549: ------------------------------------- Ah, that sounds perfect. Thanks Pete. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.0.2.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1800528944604211990==-- From jira-events at lists.jboss.org Wed Aug 11 12:19:49 2010 Content-Type: multipart/mixed; boundary="===============0204571473702417972==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Wed, 11 Aug 2010 12:19:49 -0400 Message-ID: <805407667.22897.1281543589309.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0204571473702417972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12544330#actio= n_12544330 ] = Pete Muir commented on WELD-549: -------------------------------- Nik, any updates to this? > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.1.0.BETA1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0204571473702417972==-- From jira-events at lists.jboss.org Wed Aug 11 19:06:52 2010 Content-Type: multipart/mixed; boundary="===============0629316369541603829==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Wed, 11 Aug 2010 19:06:52 -0400 Message-ID: <45138382.23840.1281568012160.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0629316369541603829== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir updated WELD-549: --------------------------- Fix Version/s: 1.1.0.BETA2 (was: 1.1.0.BETA1) > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Nicklas Karlsson > Fix For: 1.1.0.BETA2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0629316369541603829==-- From jira-events at lists.jboss.org Sun Aug 15 14:51:12 2010 Content-Type: multipart/mixed; boundary="===============2855658582628031296==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Sun, 15 Aug 2010 14:51:12 -0400 Message-ID: <1397333954.392.1281898272360.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2855658582628031296== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir updated WELD-549: --------------------------- Assignee: (was: Nicklas Karlsson) > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Fix For: 1.1.0.BETA2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2855658582628031296==-- From jira-events at lists.jboss.org Sun Aug 15 17:10:12 2010 Content-Type: multipart/mixed; boundary="===============6322028833527402657==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Sun, 15 Aug 2010 17:10:11 -0400 Message-ID: <1891885595.475.1281906611907.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============6322028833527402657== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir updated WELD-549: --------------------------- Priority: Critical (was: Major) > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Priority: Critical > Fix For: 1.1.0.BETA2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============6322028833527402657==-- From jira-events at lists.jboss.org Thu Sep 16 06:19:28 2010 Content-Type: multipart/mixed; boundary="===============1292951218641235871==" MIME-Version: 1.0 From: Marcel Kolsteren (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 06:19:28 -0400 Message-ID: <1195187678.3273.1284632368598.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1292951218641235871== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12551245#actio= n_12551245 ] = Marcel Kolsteren commented on WELD-549: --------------------------------------- Just a comment related to the possibility of dropping the ConversationAware= ViewHandler. The getActionURL method now covers four cases: 1. form actions 2. link hrefs 3. Ajax calls, and 4. redirect URLs According the the Weld documentation (5.3.2. Conversation propagation), the= conversation is automatically propagated in all cases except 2. So I think= dropping the ConversationAwareViewHandler is only possible if there is ano= ther solution for covering 1, 3 and 4. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1292951218641235871==-- From jira-events at lists.jboss.org Thu Sep 16 15:35:28 2010 Content-Type: multipart/mixed; boundary="===============7215089615297732523==" MIME-Version: 1.0 From: Marcel Kolsteren (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 15:35:28 -0400 Message-ID: <1877495740.4717.1284665728620.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============7215089615297732523== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12551378#actio= n_12551378 ] = Marcel Kolsteren commented on WELD-549: --------------------------------------- Some more analysis. The JSF 2.0 version of the ViewHandler class has two ne= w methods for generating bookmarkable and redirect URLs, which are not in J= SF 1.2. In JSF 2.0, the four cases of my previous post map to the following= ViewHandler methods: 1. getActionURL 2. getBookmarkableURL 3. getActionURL 4. getRedirectURL Remark that in Mojorra's view handler implementation (MultiViewHandler), bo= th getBookmarkableURL and getRedirectURL call getActionURL on the installed= view handler. That's why Dan could cover all four cases, by only overridin= g the getActionURL method (I hope this is portable to other JSF implementat= ions). How to prevent that getBookmarkableURL adds the cid parameter? I think that= a solution would be to change ConversationAwareViewHandler so that it not = only overrides getActionURL, but also getBookmarkableURL. The ConversationA= wareViewHandler could be a copy of MultiViewHandler.getBookmarkableURL, whe= re getActionURL is called on the delegate instead of on the installed view = handler. Unfortunately, there is a difficulty: the Weld core is built against the JS= F 1.2 API, which doesn't contain the getBookmarkableURL method, so how to o= verride it? > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============7215089615297732523==-- From jira-events at lists.jboss.org Thu Sep 16 15:37:28 2010 Content-Type: multipart/mixed; boundary="===============1681131432800952670==" MIME-Version: 1.0 From: Marcel Kolsteren (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Issue Comment Edited: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 15:37:28 -0400 Message-ID: <146047756.4718.1284665848486.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1681131432800952670== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12551378#actio= n_12551378 ] = Marcel Kolsteren edited comment on WELD-549 at 9/16/10 3:36 PM: ---------------------------------------------------------------- Some more analysis. The JSF 2.0 version of the ViewHandler class has two ne= w methods for generating bookmarkable and redirect URLs, which are not in J= SF 1.2. In JSF 2.0, the four cases of my previous post map to the following= ViewHandler methods: 1. getActionURL 2. getBookmarkableURL 3. getActionURL 4. getRedirectURL Remark that in Mojorra's view handler implementation (MultiViewHandler), bo= th getBookmarkableURL and getRedirectURL call getActionURL on the installed= view handler. That's why Dan could cover all four cases, by only overridin= g the getActionURL method (I hope this is portable to other JSF implementat= ions). How to prevent that getBookmarkableURL adds the cid parameter? I think that= a solution would be to change ConversationAwareViewHandler so that it not = only overrides getActionURL, but also getBookmarkableURL. This override cou= ld be a copy of MultiViewHandler.getBookmarkableURL, where getActionURL is = called on the delegate instead of on the installed view handler. Unfortunately, there is a difficulty: the Weld core is built against the JS= F 1.2 API, which doesn't contain the getBookmarkableURL method, so how to o= verride it? was (Author: marcelkolsteren): Some more analysis. The JSF 2.0 version of the ViewHandler class has tw= o new methods for generating bookmarkable and redirect URLs, which are not = in JSF 1.2. In JSF 2.0, the four cases of my previous post map to the follo= wing ViewHandler methods: 1. getActionURL 2. getBookmarkableURL 3. getActionURL 4. getRedirectURL Remark that in Mojorra's view handler implementation (MultiViewHandler), bo= th getBookmarkableURL and getRedirectURL call getActionURL on the installed= view handler. That's why Dan could cover all four cases, by only overridin= g the getActionURL method (I hope this is portable to other JSF implementat= ions). How to prevent that getBookmarkableURL adds the cid parameter? I think that= a solution would be to change ConversationAwareViewHandler so that it not = only overrides getActionURL, but also getBookmarkableURL. The ConversationA= wareViewHandler could be a copy of MultiViewHandler.getBookmarkableURL, whe= re getActionURL is called on the delegate instead of on the installed view = handler. Unfortunately, there is a difficulty: the Weld core is built against the JS= F 1.2 API, which doesn't contain the getBookmarkableURL method, so how to o= verride it? = > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1681131432800952670==-- From jira-events at lists.jboss.org Thu Sep 16 17:14:28 2010 Content-Type: multipart/mixed; boundary="===============8173565212305568772==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 17:14:28 -0400 Message-ID: <1035883248.4896.1284671668557.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============8173565212305568772== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12551394#actio= n_12551394 ] = Pete Muir commented on WELD-549: -------------------------------- We can still add the method to the view handler, it will be ignored in JSF = 1.2 > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============8173565212305568772==-- From jira-events at lists.jboss.org Thu Sep 16 17:14:28 2010 Content-Type: multipart/mixed; boundary="===============2340934613885431988==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Assigned: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 17:14:28 -0400 Message-ID: <751827728.4901.1284671668673.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============2340934613885431988== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir reassigned WELD-549: ------------------------------ Assignee: Pete Muir > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Pete Muir > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============2340934613885431988==-- From jira-events at lists.jboss.org Thu Sep 16 17:23:28 2010 Content-Type: multipart/mixed; boundary="===============7896208475605440717==" MIME-Version: 1.0 From: Marcel Kolsteren (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Thu, 16 Sep 2010 17:23:28 -0400 Message-ID: <1860123300.4907.1284672208716.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============7896208475605440717== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12551395#actio= n_12551395 ] = Marcel Kolsteren commented on WELD-549: --------------------------------------- Didn't think of that. Just without an @Override, that should work indeed. C= ool! > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Pete Muir > Priority: Critical > Fix For: 1.1.0.Beta2 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============7896208475605440717==-- From jira-events at lists.jboss.org Fri Oct 15 06:57:01 2010 Content-Type: multipart/mixed; boundary="===============0038838703835653609==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link Date: Fri, 15 Oct 2010 06:57:01 -0400 Message-ID: <873739498.36162.1287140221525.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0038838703835653609== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir updated WELD-549: --------------------------- Fix Version/s: 1.1.0.CR1 (was: 1.1.0.Beta2) > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Pete Muir > Priority: Critical > Fix For: 1.1.0.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0038838703835653609==-- From jira-events at lists.jboss.org Sat Nov 13 11:37:43 2010 Content-Type: multipart/mixed; boundary="===============6827677781525827896==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link Date: Sat, 13 Nov 2010 11:37:43 -0500 Message-ID: <226397336.149.1289666263714.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============6827677781525827896== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plug= in.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12563244#comme= nt-12563244 ] = Pete Muir commented on WELD-549: -------------------------------- Initial work at https://github.com/pmuir/weld-core/tree/WELD-549 Unfortunately this is not sufficient as it interferes with redirect URLs, a= nd we can't revert to Seam 2 behavior as we need conversations active durin= g restore view. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Pete Muir > Priority: Critical > Fix For: 1.1.0.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============6827677781525827896==-- From jira-events at lists.jboss.org Sat Nov 13 11:39:43 2010 Content-Type: multipart/mixed; boundary="===============4419516287417257250==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Assigned: (WELD-549) Conversation propagated by default with h:link Date: Sat, 13 Nov 2010 11:39:43 -0500 Message-ID: <1971182399.155.1289666383713.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============4419516287417257250== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir reassigned WELD-549: ------------------------------ Assignee: Dan Allen (was: Pete Muir) Dan, can you take a look at this? the new test org.jboss.weld.tests.context= s.conversation.ClientConversationContextTest.testConversationNotPropagatedB= yHLink() needs to pass. > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Dan Allen > Priority: Critical > Fix For: 1.1.0.CR1 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============4419516287417257250==-- From jira-events at lists.jboss.org Mon Dec 6 12:08:01 2010 Content-Type: multipart/mixed; boundary="===============8399624706528946545==" MIME-Version: 1.0 From: Pete Muir (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Closed: (WELD-549) Conversation propagated by default with h:link Date: Mon, 06 Dec 2010 12:08:01 -0500 Message-ID: <1710755185.1497.1291655281497.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 1420522965.3152.1276002398134.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============8399624706528946545== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://jira.jboss.org/browse/WELD-549?page=3Dcom.atlassian.jira.plu= gin.system.issuetabpanels:all-tabpanel ] Pete Muir closed WELD-549. -------------------------- Assignee: Pete Muir (was: Dan Allen) Fix Version/s: 1.1.0.Beta3 (was: 1.1.0.CR1) Resolution: Done > Conversation propagated by default with h:link > ---------------------------------------------- > > Key: WELD-549 > URL: https://jira.jboss.org/browse/WELD-549 > Project: Weld > Issue Type: Bug > Components: Web Tier integration (JSF, JSP, EL and Servlet) = > Affects Versions: 1.0.1.Final > Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS= 10.6 and Windows 7. WELD-000900 1.0.1 (SP2) > Reporter: David Beaumont > Assignee: Pete Muir > Priority: Critical > Fix For: 1.1.0.Beta3 > > Attachments: CdiConvoBug.war > > > I created a long running conversation by running a method on a conversati= on scoped bean: > private boolean initialized; > public void init() { > if(initialized) return; > conversation.begin(); > initialized =3D true; > } > From a facelets page using the JSF2 event system: > > > > If a conversation has been made long-running, the h:link tag will produce= links with the conversation query parameter, thereby propagating the conve= rsation whether that was what you wanted or not. > I.e: >

Link:

> produces >

Link: a link

-- = This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============8399624706528946545==--