From jira-events at lists.jboss.org Mon May 23 11:37:01 2011 Content-Type: multipart/mixed; boundary="===============0509425812286098272==" MIME-Version: 1.0 From: Nicklas Karlsson (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] Created: (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 23 May 2011 11:37:00 -0400 Message-ID: <919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> --===============0509425812286098272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Dual faces mapping and cid parameter for conversational redirect ---------------------------------------------------------------- Key: WELD-909 URL: https://issues.jboss.org/browse/WELD-909 Project: Weld Issue Type: Bug Components: Conversations Affects Versions: 1.1.1.Final Reporter: Nicklas Karlsson Given a page like {code} Concept {code} and a backing bean like {code} package fi.nik.concept; import javax.enterprise.context.Conversation; import javax.inject.Inject; import javax.inject.Named; @Named public class BackingBean = { @Inject private Conversation conversation; public String nonTransient() = { conversation.begin(); return "page?faces-redirect=3Dtrue"; } } {code} clicking "redirect" with non-transient conversations work fine but clicking= "non-transient" duplicates the faces mappings and cid to something like ht= tp://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and clic= king "redirect" after keeps the URL like that. It works normally after that (since the faces mapping is still hit and the = cid is repeated with the same value) but it looks a bit odd. Would have written a test for it but git on Windows is... a bit nonlinear a= t times. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0509425812286098272==-- From jira-events at lists.jboss.org Fri Oct 28 09:04:45 2011 Content-Type: multipart/mixed; boundary="===============0518297602169680480==" MIME-Version: 1.0 From: Ales Justin (Commented) (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Fri, 28 Oct 2011 09:04:45 -0400 Message-ID: <1837681499.37575.1319807085554.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0518297602169680480== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.pl= ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12638284#com= ment-12638284 ] = Ales Justin commented on WELD-909: ---------------------------------- Does fixing WELD-877 help somehow here? = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============0518297602169680480==-- From jira-events at lists.jboss.org Sat Jan 28 16:33:49 2012 Content-Type: multipart/mixed; boundary="===============1291898353114580468==" MIME-Version: 1.0 From: Joern Ohmen (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Sat, 28 Jan 2012 16:33:48 -0500 Message-ID: <1701703772.6988.1327786428922.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1291898353114580468== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.pl= ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12662593#com= ment-12662593 ] = Joern Ohmen commented on WELD-909: ---------------------------------- I have the same problem, using this example: http://blog.goyello.com/2011/06/08/jee6-cdi-and-conversation-scope/ = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============1291898353114580468==-- From jira-events at lists.jboss.org Mon Feb 27 09:46:37 2012 Content-Type: multipart/mixed; boundary="===============7134065155331557286==" MIME-Version: 1.0 From: Ales Justin (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 27 Feb 2012 09:46:37 -0500 Message-ID: <1612305201.45328.1330353997078.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============7134065155331557286== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.pl= ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12671204#com= ment-12671204 ] = Ales Justin commented on WELD-909: ---------------------------------- Nicklas, any better luck with git, either test or patch? = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira =20 --===============7134065155331557286==-- From jira-events at lists.jboss.org Mon Mar 19 05:38:47 2012 Content-Type: multipart/mixed; boundary="===============9085193665912496396==" MIME-Version: 1.0 From: Ales Justin (JIRA) To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 19 Mar 2012 05:38:47 -0400 Message-ID: <1232590871.16446.1332149927833.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============9085193665912496396== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.p= lugin.system.issuetabpanels:all-tabpanel ] Ales Justin reassigned WELD-909: -------------------------------- Assignee: Marko Luk=C5=A1a = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > Assignee: Marko Luk=C5=A1a > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============9085193665912496396==-- From jira-events at lists.jboss.org Mon Mar 19 08:56:47 2012 Content-Type: multipart/mixed; boundary="===============1870095936590737420==" MIME-Version: 1.0 From: =?utf-8?q?Marko_Luk=C5=A1a_=28JIRA=29_=3Cjira-events_at_lists=2Ejboss=2Eo?= =?utf-8?q?rg=3E?= To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 19 Mar 2012 08:56:47 -0400 Message-ID: <1563315313.17086.1332161807525.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============1870095936590737420== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.p= lugin.system.issuetabpanels:all-tabpanel ] Marko Luk=C5=A1a updated WELD-909: ----------------------------- Git Pull Request: https://github.com/weld/core/pull/183 Fixed. The problem was in FacesUrlTransformer.toActionUrl(), where the original ur= l already contained the cid parameter. As a result, {{queryParameters}} als= o contained the parameter. Furthermore, {{actionUrl}} (obtained by calling = {{getActionURL()}}) also contained the cid parameter. Since {{actionUrl}} a= nd {{queryParameters}} are simply concatenated, the resulting url will cont= ain the dual cid parameters. I should probably have parsed both query strings and merged them parameter-= by-parameter, but this would be overkill and could have possibly introduced= new bugs (because of the parsing and then rebuilding the query string). I = opted for a simpler solution, since {{actionUrl}} will only contain the cid= parameter (and no other parameters) in all but the most exotic cases. So i= f {{actionUrl}}'s query string is fully contained in {{queryParameters}}, I= simply ignore it and use {{queryParameters}} instead. = = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > Assignee: Marko Luk=C5=A1a > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============1870095936590737420==-- From jira-events at lists.jboss.org Mon Mar 19 09:01:54 2012 Content-Type: multipart/mixed; boundary="===============0026471213138285170==" MIME-Version: 1.0 From: =?utf-8?q?Marko_Luk=C5=A1a_=28JIRA=29_=3Cjira-events_at_lists=2Ejboss=2Eo?= =?utf-8?q?rg=3E?= To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 19 Mar 2012 09:01:54 -0400 Message-ID: <1574804912.17094.1332162114219.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============0026471213138285170== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.p= lugin.system.issuetabpanels:all-tabpanel ] Marko Luk=C5=A1a updated WELD-909: ----------------------------- Fix Version/s: 1.2.0.Beta1 Git Pull Request: https://github.com/weld/core/pull/183 (was: https://= github.com/weld/core/pull/183) = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > Assignee: Marko Luk=C5=A1a > Fix For: 1.2.0.Beta1 > > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============0026471213138285170==-- From jira-events at lists.jboss.org Mon Mar 19 09:53:49 2012 Content-Type: multipart/mixed; boundary="===============8870495899270966528==" MIME-Version: 1.0 From: =?utf-8?q?Marko_Luk=C5=A1a_=28JIRA=29_=3Cjira-events_at_lists=2Ejboss=2Eo?= =?utf-8?q?rg=3E?= To: weld-issues at lists.jboss.org Subject: [weld-issues] [JBoss JIRA] (WELD-909) Dual faces mapping and cid parameter for conversational redirect Date: Mon, 19 Mar 2012 09:53:49 -0400 Message-ID: <243936734.17315.1332165229593.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com> In-Reply-To: 919417920.18945.1306165020903.JavaMail.tomcat@jira02.app.mwc.hst.phx2.redhat.com --===============8870495899270966528== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [ https://issues.jboss.org/browse/WELD-909?page=3Dcom.atlassian.jira.p= lugin.system.issuetabpanels:all-tabpanel ] Marko Luk=C5=A1a resolved WELD-909. ------------------------------ Resolution: Done = > Dual faces mapping and cid parameter for conversational redirect > ---------------------------------------------------------------- > > Key: WELD-909 > URL: https://issues.jboss.org/browse/WELD-909 > Project: Weld > Issue Type: Bug > Components: Conversations > Affects Versions: 1.1.1.Final > Reporter: Nicklas Karlsson > Assignee: Marko Luk=C5=A1a > Fix For: 1.2.0.Beta1 > > > Given a page like > {code} > > > xmlns:ui=3D"http://java.sun.com/jsf/facelets" > xmlns:h=3D"http://java.sun.com/jsf/html" > xmlns:f=3D"http://java.sun.com/jsf/core"> > > > Concept > > > > > > > > > > > {code} > and a backing bean like > {code} > package fi.nik.concept; > import javax.enterprise.context.Conversation; > import javax.inject.Inject; > import javax.inject.Named; > @Named > public class BackingBean = > { > @Inject > private Conversation conversation; > public String nonTransient() = > { > conversation.begin(); > return "page?faces-redirect=3Dtrue"; > } > } > {code} > clicking "redirect" with non-transient conversations work fine but clicki= ng "non-transient" duplicates the faces mappings and cid to something like = http://localhost:8080/concept/faces/faces/page.xhtml?cid=3D1&cid=3D1 and cl= icking "redirect" after keeps the URL like that. > It works normally after that (since the faces mapping is still hit and th= e cid is repeated with the same value) but it looks a bit odd. > Would have written a test for it but git on Windows is... a bit nonlinear= at times. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira = --===============8870495899270966528==--