Hi There,
Looks quite good to me the test you've written. No comments on it though - you're following the paradigm "let the code speak for itself?"
On my local machine I've added the following validation: Assert.assertFalse(ModelBean.class.equals(producer.getIp().getBean().getBeanClass()));
Let me ask the following question, for which I suspect I know the answer already. This fix, once it exists, It will never be merged down to an older release branch? Namely, you will not check which version of WELD is being bundled in glassfish 3.1.2.2, 2.5, 2.9 or weblogic 12.1.2, 12.1.3 etc... and merge the fix into what would be the next patch release of their standing library?
This goes into trunk and that's it?
Kindest regards.
|