To sum up the options here... In JDK 9 there is no way to use the internal (sun.*) modules which blocks us from using BCEL classes. So we are left with 2 options both of which require additional dependency:
-
Add dependency on BCEL
-
last release was 2006, not updated anymore
-
sufficient for our needs
-
easy to refactor - here is a branch with all the modifications needed to make it work
-
Search for another tool which we could use
-
there are others, see this SO answer
-
more up to date, might allow us to do more things (not sure we need it?)
-
we would need to rewrite the formats class
-
we would need to learn how the new tool works
Side note: whichever way we choose, we might want to apply it to 2.3 branch as well so that we make Formats work on ALL JDKs (even as of today, some JDKs - looking at ibm here - do not have BCEL internal classes, so the FormatsTest fails there anyway)
|